mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Saravana Kannan <saravanak@google.com>
Cc: K Prateek Nayak <kprateek.nayak@amd.com>,
	Ingo Molnar <mingo@redhat.com>,
	Juri Lelli <juri.lelli@redhat.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Benjamin Segall <bsegall@google.com>,
	Mel Gorman <mgorman@suse.de>,
	Valentin Schneider <vschneid@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>,
	wuyun.abel@bytedance.com, youssefesmat@chromium.org,
	Thomas Gleixner <tglx@linutronix.de>,
	efault@gmx.de, John Stultz <jstultz@google.com>,
	Vincent Palomares <paillon@google.com>,
	Tobias Huschle <huschle@linux.ibm.com>
Subject: Re: Very high scheduling delay with plenty of idle CPUs
Date: Mon, 11 Nov 2024 11:40:54 +0100	[thread overview]
Message-ID: <20241111104054.GE22801@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <CAGETcx9qDK+QUiP8z1iNYXwjHz39oZzOZmhj4p=icU1BuVtcug@mail.gmail.com>

On Sun, Nov 10, 2024 at 10:15:07PM -0800, Saravana Kannan wrote:

> I actually quickly hacked up the cpu_overutilized() function to return
> true during suspend/resume and the threads are nicely spread out and
> running in parallel. That actually reduces the total of the
> dpm_resume*() phases from 90ms to 75ms on my Pixel 6.

Right, so that kills EAS and makes it fall through to the regular
select_idle_sibling() thing.

> Peter,
> 
> Would you be open to the scheduler being aware of
> dpm_suspend*()/dpm_resume*() phases and triggering the CPU
> overutilized behavior during these phases? I know it's a very use case
> specific behavior but how often do we NOT want to speed up
> suspend/resume? We can make this a CONFIG or a kernel command line
> option -- say, fast_suspend or something like that.

Well, I don't mind if Vincent doesn't. It seems like a very
specific/targeted thing and should not affect much else, so it is a
relatively safe thing to do.

Perhaps a more direct hack in is_rd_overutilized() would be even less
invasive, changing cpu_overutilized() relies on that getting propagated
to rd->overutilized, might as well skip that step, no?

  parent reply	other threads:[~2024-11-11 10:41 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-08  7:28 Saravana Kannan
2024-11-08  8:31 ` Peter Zijlstra
2024-11-10  5:49   ` Saravana Kannan
2024-11-11  5:17     ` K Prateek Nayak
2024-11-11  6:15       ` Saravana Kannan
2024-11-11  8:25         ` Christian Loehle
2024-11-11  9:02           ` Saravana Kannan
2024-11-11  9:08             ` Christian Loehle
2024-11-11 10:40         ` Peter Zijlstra [this message]
2024-11-11 11:15           ` Vincent Guittot
2024-11-11 18:17             ` Saravana Kannan
2024-11-11 19:00               ` Vincent Guittot
2024-11-11 18:23           ` Saravana Kannan
2024-11-11 19:01             ` Vincent Guittot
2024-11-11 19:12               ` Vincent Guittot
2024-11-12  7:23                 ` Saravana Kannan
2024-11-12  9:03                   ` Vincent Guittot
2024-11-12 16:25                     ` Saravana Kannan
2024-11-12 17:00                       ` Vincent Guittot
2024-11-08  9:02 ` Vincent Guittot
2024-11-14  6:36   ` Saravana Kannan
2024-11-14 13:06     ` Vincent Guittot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241111104054.GE22801@noisy.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=efault@gmx.de \
    --cc=huschle@linux.ibm.com \
    --cc=jstultz@google.com \
    --cc=juri.lelli@redhat.com \
    --cc=kprateek.nayak@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=paillon@google.com \
    --cc=rostedt@goodmis.org \
    --cc=saravanak@google.com \
    --cc=tglx@linutronix.de \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    --cc=wuyun.abel@bytedance.com \
    --cc=youssefesmat@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®