mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Gaurav Jain <gaurav.jain@nxp.com>
To: "Horia Geantă" <horia.geanta@nxp.com>,
	"Pankaj Gupta" <pankaj.gupta@nxp.com>,
	"Herbert Xu" <herbert@gondor.apana.org.au>,
	"David S . Miller" <davem@davemloft.net>,
	"Silvano Di Ninno" <silvano.dininno@nxp.com>,
	"Varun Sethi" <V.Sethi@nxp.com>,
	"Meenakshi Aggarwal" <meenakshi.aggarwal@nxp.com>,
	"Sahil Malhotra" <sahil.malhotra@nxp.com>,
	"Nikolaus Voss" <nikolaus.voss@haag-streit.com>,
	"Ahmad Fatoum" <a.fatoum@pengutronix.de>
Cc: =linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
	Gaurav Jain <gaurav.jain@nxp.com>
Subject: [PATCH] crypto: caam - use JobR's space to access page 0 regs
Date: Mon, 11 Nov 2024 17:40:20 +0530	[thread overview]
Message-ID: <20241111121020.4013077-1-gaurav.jain@nxp.com> (raw)

Access to controller region is not permitted.
use JobR's register space to access page 0 registers.

Fixes: 6a83830f649a ("crypto: caam - warn if blob_gen key is insecure")
Signed-off-by: Gaurav Jain <gaurav.jain@nxp.com>
---
 drivers/crypto/caam/blob_gen.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/crypto/caam/blob_gen.c b/drivers/crypto/caam/blob_gen.c
index 87781c1534ee..079a22cc9f02 100644
--- a/drivers/crypto/caam/blob_gen.c
+++ b/drivers/crypto/caam/blob_gen.c
@@ -2,6 +2,7 @@
 /*
  * Copyright (C) 2015 Pengutronix, Steffen Trumtrar <kernel@pengutronix.de>
  * Copyright (C) 2021 Pengutronix, Ahmad Fatoum <kernel@pengutronix.de>
+ * Copyright 2024 NXP
  */
 
 #define pr_fmt(fmt) "caam blob_gen: " fmt
@@ -104,7 +105,7 @@ int caam_process_blob(struct caam_blob_priv *priv,
 	}
 
 	ctrlpriv = dev_get_drvdata(jrdev->parent);
-	moo = FIELD_GET(CSTA_MOO, rd_reg32(&ctrlpriv->ctrl->perfmon.status));
+	moo = FIELD_GET(CSTA_MOO, rd_reg32(&ctrlpriv->jr[0]->perfmon.status));
 	if (moo != CSTA_MOO_SECURE && moo != CSTA_MOO_TRUSTED)
 		dev_warn(jrdev,
 			 "using insecure test key, enable HAB to use unique device key!\n");
-- 
2.25.1


             reply	other threads:[~2024-11-11 12:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-11 12:10 Gaurav Jain [this message]
2024-11-11 12:22 ` Ahmad Fatoum
2024-11-13 16:22   ` Horia Geanta
2024-11-18  9:31   ` [EXT] " Gaurav Jain
2024-11-21 10:44     ` Ahmad Fatoum
2024-11-21 11:25       ` Gaurav Jain
2024-11-11 12:12 Gaurav Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241111121020.4013077-1-gaurav.jain@nxp.com \
    --to=gaurav.jain@nxp.com \
    --cc==linux-crypto@vger.kernel.org \
    --cc=V.Sethi@nxp.com \
    --cc=a.fatoum@pengutronix.de \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=horia.geanta@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=meenakshi.aggarwal@nxp.com \
    --cc=nikolaus.voss@haag-streit.com \
    --cc=pankaj.gupta@nxp.com \
    --cc=sahil.malhotra@nxp.com \
    --cc=silvano.dininno@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®