mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Suraj Sonawane <surajsonawane0215@gmail.com>
To: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>,
	linux-kernel@vger.kernel.org,
	Suraj Sonawane <surajsonawane0215@gmail.com>
Subject: [PATCH] regulator: aat2870-regulator: replace division condition with direct comparison
Date: Wed, 13 Nov 2024 01:50:41 +0530	[thread overview]
Message-ID: <20241112202041.16980-1-surajsonawane0215@gmail.com> (raw)

Fix an issue detected by the Smatch tool:

drivers/regulator/aat2870-regulator.c:142 aat2870_get_regulator() warn:
replace divide condition '(id - 1) / 2' with '(id - 1) >= 2'

The division '(id - 1) / 2' was used to check if the regulator ID
is greater than or equal to 2, which can be confusing and less
readable. Replacing it with '(id - 1) >= 2' makes the code clearer
by directly comparing the regulator ID. This change also removes
reliance on integer division, which could be harder to understand
and may introduce subtle bugs.

Signed-off-by: Suraj Sonawane <surajsonawane0215@gmail.com>
---
 drivers/regulator/aat2870-regulator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/aat2870-regulator.c b/drivers/regulator/aat2870-regulator.c
index 970d86f2b..b48d2987a 100644
--- a/drivers/regulator/aat2870-regulator.c
+++ b/drivers/regulator/aat2870-regulator.c
@@ -139,7 +139,7 @@ static struct aat2870_regulator *aat2870_get_regulator(int id)
 	ri->enable_shift = id - AAT2870_ID_LDOA;
 	ri->enable_mask = 0x1 << ri->enable_shift;
 
-	ri->voltage_addr = (id - AAT2870_ID_LDOA) / 2 ?
+	ri->voltage_addr = (id - AAT2870_ID_LDOA) >= 2 ?
 			   AAT2870_LDO_CD : AAT2870_LDO_AB;
 	ri->voltage_shift = (id - AAT2870_ID_LDOA) % 2 ? 0 : 4;
 	ri->voltage_mask = 0xF << ri->voltage_shift;
-- 
2.34.1


             reply	other threads:[~2024-11-12 20:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-12 20:20 Suraj Sonawane [this message]
2024-11-13 13:39 ` Mark Brown
2024-11-14  8:54   ` Suraj Sonawane

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241112202041.16980-1-surajsonawane0215@gmail.com \
    --to=surajsonawane0215@gmail.com \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®