From: Daniel Yang <danielyangkang@gmail.com>
To: Kent Overstreet <kent.overstreet@linux.dev>,
linux-bcachefs@vger.kernel.org (open list:BCACHEFS),
linux-kernel@vger.kernel.org (open list)
Cc: Daniel Yang <danielyangkang@gmail.com>
Subject: [PATCH] bcachefs: replace deprecated strncpy with strscpy
Date: Tue, 12 Nov 2024 23:42:48 -0800 [thread overview]
Message-ID: <20241113074248.175133-1-danielyangkang@gmail.com> (raw)
The function strncpy is deprecated due to not guaranteeing the
destination buffer will be NULL-terminated. The recommended replacement
is to use strscpy().
Signed-off-by: Daniel Yang <danielyangkang@gmail.com>
---
fs/bcachefs/btree_trans_commit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/bcachefs/btree_trans_commit.c b/fs/bcachefs/btree_trans_commit.c
index 9bf471fa4..37e98695b 100644
--- a/fs/bcachefs/btree_trans_commit.c
+++ b/fs/bcachefs/btree_trans_commit.c
@@ -364,7 +364,7 @@ static noinline void journal_transaction_name(struct btree_trans *trans)
struct jset_entry_log *l =
container_of(entry, struct jset_entry_log, entry);
- strncpy(l->d, trans->fn, JSET_ENTRY_LOG_U64s * sizeof(u64));
+ strscpy(l->d, trans->fn, JSET_ENTRY_LOG_U64s * sizeof(u64));
}
static inline int btree_key_can_insert(struct btree_trans *trans,
--
2.39.5
next reply other threads:[~2024-11-13 7:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-13 7:42 Daniel Yang [this message]
2024-11-14 2:21 ` Kent Overstreet
2024-11-14 7:55 ` Daniel Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241113074248.175133-1-danielyangkang@gmail.com \
--to=danielyangkang@gmail.com \
--cc=kent.overstreet@linux.dev \
--cc=linux-bcachefs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®