mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Phil Auld <pauld@redhat.com>
To: Joseph Salisbury <joseph.salisbury@oracle.com>
Cc: peterz@infradead.org, mingo@kernel.org, juri.lelli@redhat.com,
	vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
	Steven Rostedt <rostedt@goodmis.org>,
	bsegall@google.com, mgorman@suse.de, vschneid@redhat.com,
	linux-kernel@vger.kernel.org
Subject: Re: [REGRESSION] sched/fair: Add lag based placement
Date: Wed, 13 Nov 2024 13:19:30 -0500	[thread overview]
Message-ID: <20241113181930.GD402105@pauld.westford.csb> (raw)
In-Reply-To: <58289b1c-8a56-4607-8632-d36aef1fc5dd@oracle.com>

Hi,

On Wed, Nov 13, 2024 at 01:03:00PM -0500 Joseph Salisbury wrote:
> Hello,
> 
> During performance testing, we found a regression of ~9% performance with
> the TPCC benchmark.   This performance regression was introduced in
> v6.6-rc1.  After a bisect, the following commit was identified as the cause
> of the regression:
> 
> 86bfbb7ce4f6 ("sched/fair: Add lag based placement")
> 
> I was hoping to get some feedback from the scheduler folks.  Do you think
> gathering any additional data will help diagnose this issue?  Are there any
> tunable options that can changed to see how performance is affected?
> 

You can try turning off the PLACE_LAG sched feature:

    echo NO_PLACE_LAG > /sys/kernel/debug/sched/features

It's not what I'd call a tunable but it would allow you to test w/o it and
see what it does.  It should allow you to switch back and forth easily for
testing. 


Cheers,
Phil

> 
> Thanks,
> 
> Joe
> 
> 
> 
> 
> 
> 
> 
> 

-- 


  reply	other threads:[~2024-11-13 18:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-13 18:03 Joseph Salisbury
2024-11-13 18:19 ` Phil Auld [this message]
2024-11-13 18:22   ` [External] : " Joseph Salisbury
2024-11-13 18:33     ` Joseph Salisbury
2024-11-14 19:50       ` [External] : " Joseph Salisbury

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241113181930.GD402105@pauld.westford.csb \
    --to=pauld@redhat.com \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=joseph.salisbury@oracle.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®