From: Brian Johannesmeyer <bjohannesmeyer@gmail.com>
To: Ronak Doshi <ronak.doshi@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Andy King <acking@vmware.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Brian Johannesmeyer <bjohannesmeyer@gmail.com>,
Raphael Isemann <teemperor@gmail.com>
Subject: [PATCH 1/2] vmxnet3: Fix inconsistent DMA accesses in vmxnet3_probe_device()
Date: Wed, 13 Nov 2024 21:00:00 +0100 [thread overview]
Message-ID: <20241113200001.3567479-2-bjohannesmeyer@gmail.com> (raw)
In-Reply-To: <20241113200001.3567479-1-bjohannesmeyer@gmail.com>
After mapping `adapter` to streaming DMA, but before accessing it,
synchronize it to the CPU. Then, before returning, synchronize it back to
the device. This mitigates any inconsistent accesses to it from
vmxnet3_probe_device().
Co-developed-by: Raphael Isemann <teemperor@gmail.com>
Signed-off-by: Raphael Isemann <teemperor@gmail.com>
Signed-off-by: Brian Johannesmeyer <bjohannesmeyer@gmail.com>
---
drivers/net/vmxnet3/vmxnet3_drv.c | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c
index 7fa74b8b2100..cc76134c7db4 100644
--- a/drivers/net/vmxnet3/vmxnet3_drv.c
+++ b/drivers/net/vmxnet3/vmxnet3_drv.c
@@ -3623,6 +3623,8 @@ vmxnet3_probe_device(struct pci_dev *pdev,
int num_rx_queues;
int queues;
unsigned long flags;
+ struct device *dev;
+ dma_addr_t adapter_pa;
if (!pci_msi_enabled())
enable_mq = 0;
@@ -3662,14 +3664,19 @@ vmxnet3_probe_device(struct pci_dev *pdev,
}
spin_lock_init(&adapter->cmd_lock);
- adapter->adapter_pa = dma_map_single(&adapter->pdev->dev, adapter,
+ dev = &adapter->pdev->dev;
+ adapter_pa = dma_map_single(dev, adapter,
sizeof(struct vmxnet3_adapter),
DMA_TO_DEVICE);
- if (dma_mapping_error(&adapter->pdev->dev, adapter->adapter_pa)) {
+ if (dma_mapping_error(dev, adapter_pa)) {
dev_err(&pdev->dev, "Failed to map dma\n");
err = -EFAULT;
goto err_set_mask;
}
+ dma_sync_single_for_cpu(dev, adapter_pa,
+ sizeof(struct vmxnet3_adapter), DMA_TO_DEVICE);
+ adapter->adapter_pa = adapter_pa;
+
adapter->shared = dma_alloc_coherent(
&adapter->pdev->dev,
sizeof(struct Vmxnet3_DriverShared),
@@ -3928,6 +3935,8 @@ vmxnet3_probe_device(struct pci_dev *pdev,
}
vmxnet3_check_link(adapter, false);
+ dma_sync_single_for_device(dev, adapter_pa,
+ sizeof(struct vmxnet3_adapter), DMA_TO_DEVICE);
return 0;
err_register:
--
2.34.1
next prev parent reply other threads:[~2024-11-13 20:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-13 19:59 [PATCH 0/2] vmxnet3: Fix inconsistent DMA accesses Brian Johannesmeyer
2024-11-13 20:00 ` Brian Johannesmeyer [this message]
2024-11-13 20:00 ` [PATCH 2/2] vmxnet3: Remove adapter from DMA region Brian Johannesmeyer
2024-11-15 3:38 ` [PATCH 0/2] vmxnet3: Fix inconsistent DMA accesses Jakub Kicinski
2024-11-18 15:31 ` Brian Johannesmeyer
2024-11-19 0:16 ` Jakub Kicinski
2024-11-19 17:10 ` Brian Johannesmeyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241113200001.3567479-2-bjohannesmeyer@gmail.com \
--to=bjohannesmeyer@gmail.com \
--cc=acking@vmware.com \
--cc=andrew+netdev@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ronak.doshi@broadcom.com \
--cc=teemperor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®