From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85C8B1E3DC9 for ; Thu, 14 Nov 2024 01:40:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=124.126.103.232 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731548417; cv=none; b=Yi3gn8bUh1MhE/RZRzIXRgjD2FvSREmFzXDv2nBhA6UQ3jblUNDIWgYchxkyPWaJs2kzB+dtlPOkPdHiyaogXTLT7yh3drbyQFlPtsoGxm7p9mGe5kz9r/4xPZ9JTpyvO5hnFPiJ1OlhbBo/sjWpIiKLgdyvkqK0/acq2F8+Tk4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731548417; c=relaxed/simple; bh=ZJ/ujmIN1i9K9n54X6yUfiA9sCxlY+oOdFSHdgyuRVk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=E+l05t26jmUbSzTKljazZolP19dGGsHqNZ7FcLtnwIlTiBSfKhD/1sz7RTMUyxfzDwFKsAtZYDyNFOA8XrAXYrc/rDBwEmnQzPNoDaIrE3/hlkC6OpejvohqKMIpQvaWVrUAvVkyTYY0i62InktHK4QLRKDLT0Ojo1nnNC5Rj0Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn; spf=pass smtp.mailfrom=kylinos.cn; arc=none smtp.client-ip=124.126.103.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kylinos.cn X-UUID: 5fe5a8bea22911efa216b1d71e6e1362-20241114 X-CTIC-Tags: HR_CC_AS_FROM, HR_CC_COUNT, HR_CC_DOMAIN_COUNT, HR_CC_NO_NAME, HR_CTE_8B HR_CTT_MISS, HR_DATE_H, HR_DATE_WKD, HR_DATE_ZONE, HR_FROM_DIGIT_LEN HR_FROM_NAME, HR_SJ_DIGIT_LEN, HR_SJ_LANG, HR_SJ_LEN, HR_SJ_LETTER HR_SJ_NOR_SYM, HR_SJ_PHRASE, HR_SJ_PHRASE_LEN, HR_SJ_PRE_RE, HR_SJ_QUESTION HR_SJ_WS, HR_TO_COUNT, HR_TO_DOMAIN_COUNT, HR_TO_NO_NAME, IP_TRUSTED SRC_TRUSTED, DN_TRUSTED, SA_TRUSTED, SA_EXISTED, SN_TRUSTED SN_EXISTED, SPF_NOPASS, DKIM_NOPASS, DMARC_NOPASS, CIE_BAD CIE_GOOD_SPF, GTI_FG_BS, GTI_RG_INFO, GTI_C_BU, AMN_T1 AMN_GOOD, AMN_C_TI, AMN_C_BU X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.38,REQID:ac839e93-d55e-4b78-9437-6f2722978294,IP:0,U RL:0,TC:0,Content:-5,EDM:25,RT:0,SF:-5,FILE:0,BULK:0,RULE:Release_Ham,ACTI ON:release,TS:15 X-CID-INFO: VERSION:1.1.38,REQID:ac839e93-d55e-4b78-9437-6f2722978294,IP:0,URL :0,TC:0,Content:-5,EDM:25,RT:0,SF:-5,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:15 X-CID-META: VersionHash:82c5f88,CLOUDID:602ae245ff980491ed08d2a9c02dbb2e,BulkI D:241113230005088VC21T,BulkQuantity:4,Recheck:0,SF:17|19|66|841|38|102,TC: nil,Content:0,EDM:5,IP:nil,URL:0,File:nil,RT:nil,Bulk:40,QS:nil,BEC:nil,CO L:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_FAS,TF_CID_SPAM_FSD X-UUID: 5fe5a8bea22911efa216b1d71e6e1362-20241114 X-User: xiaopei01@kylinos.cn Received: from xiaopei-pc.. [(10.44.16.150)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 1245650665; Thu, 14 Nov 2024 09:40:05 +0800 From: Pei Xiao To: syzbot+3fa2af55f15bd21cada9@syzkaller.appspotmail.com, linux-kernel@vger.kernel.org Cc: xiaopei01@kylinos.cn Subject: Re: [syzbot] [input?] [usb?] UBSAN: shift-out-of-bounds in s32ton Date: Thu, 14 Nov 2024 09:40:02 +0800 Message-Id: <20241114014002.7435-2-xiaopei01@kylinos.cn> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241114014002.7435-1-xiaopei01@kylinos.cn> References: <67321ded.050a0220.a83d0.0016.GAE@google.com> <20241114014002.7435-1-xiaopei01@kylinos.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index 81d6c734c8bc..ead1d338fa58 100644 --- a/drivers/hid/hid-core.c +++ b/drivers/hid/hid-core.c @@ -66,8 +66,11 @@ static s32 snto32(__u32 value, unsigned int n) static u32 s32ton(__s32 value, unsigned int n) { - s32 a = value >> (n - 1); + s32 a; + if (n >= 32) + return value; + a = value >> (n - 1); if (a && a != -1) return value < 0 ? 1 << (n - 1) : (1 << (n - 1)) - 1; return value & ((1 << n) - 1);