From: Michal Wajdeczko <michal.wajdeczko@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>,
Matthew Wilcox <willy@infradead.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Matthew Brost <matthew.brost@intel.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: [PATCH v3 1/4] iov_iter: Provide copy_iomem_to|from_iter()
Date: Thu, 14 Nov 2024 15:12:38 +0100 [thread overview]
Message-ID: <20241114141238.2255-1-michal.wajdeczko@intel.com> (raw)
In-Reply-To: <20241112200454.2211-2-michal.wajdeczko@intel.com>
Define simple copy helpers that work on I/O memory. This will
allow reuse of existing framework functions in new use cases.
Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Matthew Wilcox <willy@infradead.org>
---
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: linux-kernel@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org
---
v2: use iterate_and_advance to treat user_iter separately (Matthew)
v3: add explicit casts to make sparse happy (kernel test robot)
---
include/linux/uio.h | 3 +++
lib/iov_iter.c | 66 +++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 69 insertions(+)
diff --git a/include/linux/uio.h b/include/linux/uio.h
index 853f9de5aa05..354a6b2d1e94 100644
--- a/include/linux/uio.h
+++ b/include/linux/uio.h
@@ -183,6 +183,9 @@ size_t _copy_to_iter(const void *addr, size_t bytes, struct iov_iter *i);
size_t _copy_from_iter(void *addr, size_t bytes, struct iov_iter *i);
size_t _copy_from_iter_nocache(void *addr, size_t bytes, struct iov_iter *i);
+size_t copy_iomem_to_iter(const void __iomem *from, size_t bytes, struct iov_iter *i);
+size_t copy_iomem_from_iter(void __iomem *to, size_t bytes, struct iov_iter *i);
+
static inline size_t copy_folio_to_iter(struct folio *folio, size_t offset,
size_t bytes, struct iov_iter *i)
{
diff --git a/lib/iov_iter.c b/lib/iov_iter.c
index 908e75a28d90..a6eae4063366 100644
--- a/lib/iov_iter.c
+++ b/lib/iov_iter.c
@@ -323,6 +323,72 @@ size_t _copy_from_iter_flushcache(void *addr, size_t bytes, struct iov_iter *i)
EXPORT_SYMBOL_GPL(_copy_from_iter_flushcache);
#endif
+static __always_inline
+size_t memcpy_iomem_to_iter(void *iter_to, size_t progress, size_t len,
+ void *from, void *priv2)
+{
+ memcpy_fromio(iter_to, (const void __iomem *)from + progress, len);
+ return 0;
+}
+
+static __always_inline
+size_t memcpy_iomem_from_iter(void *iter_from, size_t progress, size_t len,
+ void *to, void *priv2)
+{
+ memcpy_toio((void __iomem *)to + progress, iter_from, len);
+ return 0;
+}
+
+static __always_inline
+size_t copy_iomem_to_user_iter(void __user *iter_to, size_t progress,
+ size_t len, void *from, void *priv2)
+{
+ unsigned char buf[SMP_CACHE_BYTES];
+ size_t chunk = min(len, sizeof(buf));
+
+ memcpy_fromio(buf, (const void __iomem *)from + progress, chunk);
+ chunk -= copy_to_user_iter(iter_to, progress, chunk, buf, priv2);
+ return len - chunk;
+}
+
+static __always_inline
+size_t copy_iomem_from_user_iter(void __user *iter_from, size_t progress,
+ size_t len, void *to, void *priv2)
+{
+ unsigned char buf[SMP_CACHE_BYTES];
+ size_t chunk = min(len, sizeof(buf));
+
+ chunk -= copy_from_user_iter(iter_from, progress, chunk, buf, priv2);
+ memcpy_toio((void __iomem *)to, buf, chunk);
+ return len - chunk;
+}
+
+size_t copy_iomem_to_iter(const void __iomem *from, size_t bytes, struct iov_iter *i)
+{
+ if (WARN_ON_ONCE(i->data_source))
+ return 0;
+ if (user_backed_iter(i))
+ might_fault();
+
+ return iterate_and_advance(i, bytes, (void __force *)from,
+ copy_iomem_to_user_iter,
+ memcpy_iomem_to_iter);
+}
+EXPORT_SYMBOL(copy_iomem_to_iter);
+
+size_t copy_iomem_from_iter(void __iomem *to, size_t bytes, struct iov_iter *i)
+{
+ if (WARN_ON_ONCE(!i->data_source))
+ return 0;
+ if (user_backed_iter(i))
+ might_fault();
+
+ return iterate_and_advance(i, bytes, (void __force *)to,
+ copy_iomem_from_user_iter,
+ memcpy_iomem_from_iter);
+}
+EXPORT_SYMBOL(copy_iomem_from_iter);
+
static inline bool page_copy_sane(struct page *page, size_t offset, size_t n)
{
struct page *head;
--
2.43.0
next prev parent reply other threads:[~2024-11-14 14:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-12 20:04 [PATCH v2 0/4] Add iomem helpers for use from debugfs Michal Wajdeczko
2024-11-12 20:04 ` [PATCH v2 1/4] iov_iter: Provide copy_iomem_to|from_iter() Michal Wajdeczko
2024-11-14 1:29 ` kernel test robot
2024-11-14 4:20 ` kernel test robot
2024-11-14 14:12 ` Michal Wajdeczko [this message]
2024-11-12 20:04 ` [PATCH v2 2/4] libfs: Provide simple_read_from|write_to_iomem() Michal Wajdeczko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241114141238.2255-1-michal.wajdeczko@intel.com \
--to=michal.wajdeczko@intel.com \
--cc=akpm@linux-foundation.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.brost@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®