From: Jon Kohler <jon@nutanix.com>
To: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>,
linux-kernel@vger.kernel.org
Cc: Jon Kohler <jon@nutanix.com>
Subject: [PATCH] sched/rt: use for_each_cpu_wrap to iterate over rto_mask
Date: Thu, 14 Nov 2024 15:05:58 -0700 [thread overview]
Message-ID: <20241114220558.1842569-1-jon@nutanix.com> (raw)
When using NO_RT_PUSH_IPI, using for_each_cpu() over rto_mask may cause
many CPUs to attempt to pull load from the same CPU, causing RQ
lock contention.
Use for_each_cpu_wrap instead to spread out which RQ gets evaluated
first, similar to how _nohz_idle_balance iterates over idle_cpus_mask.
This strategy is beneficial when there are many CPUs in rto_mask and
many other CPUs going in and out of schedule() at the same time.
Signed-off-by: Jon Kohler <jon@nutanix.com>
---
kernel/sched/rt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
index 172c588de542..c883ff122f5d 100644
--- a/kernel/sched/rt.c
+++ b/kernel/sched/rt.c
@@ -2308,7 +2308,7 @@ static void pull_rt_task(struct rq *this_rq)
}
#endif
- for_each_cpu(cpu, this_rq->rd->rto_mask) {
+ for_each_cpu_wrap(cpu, this_rq->rd->rto_mask, this_cpu+1) {
if (this_cpu == cpu)
continue;
--
2.43.0
next reply other threads:[~2024-11-14 21:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-14 22:05 Jon Kohler [this message]
2024-11-15 10:04 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241114220558.1842569-1-jon@nutanix.com \
--to=jon@nutanix.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®