From: Su Hui <suhui@nfschina.com>
To: stuyoder@gmail.com, laurentiu.tudor@nxp.com, nathan@kernel.org,
ndesaulniers@google.com, morbo@google.com,
justinstitt@google.com, dan.carpenter@linaro.org
Cc: Su Hui <suhui@nfschina.com>,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev, kernel-janitors@vger.kernel.org
Subject: [PATCH v2 1/2] bus: fsl-mc: Fix the double free in fsl_mc_device_add()
Date: Fri, 15 Nov 2024 10:32:06 +0800 [thread overview]
Message-ID: <20241115023206.3722933-2-suhui@nfschina.com> (raw)
In-Reply-To: <20241115023206.3722933-1-suhui@nfschina.com>
Clang static checker(scan-build) warning：
drivers/bus/fsl-mc/fsl-mc-bus.c: line 909, column 2
Attempt to free released memory.
When 'obj_desc->type' == "dprc" and begin to free 'mc_bus' and 'mc_dev',
there is a double free problem because of 'mc_dev = &mc_bus->mc_dev'.
Add a judgment to fix this problem.
Fixes: a042fbed0290 ("staging: fsl-mc: simplify couple of deallocations")
Signed-off-by: Su Hui <suhui@nfschina.com>
---
v2:
- using is_fsl_mc_bus_dprc().
https://lore.kernel.org/all/20241114082751.3475110-1-suhui@nfschina.com/
drivers/bus/fsl-mc/fsl-mc-bus.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/bus/fsl-mc/fsl-mc-bus.c b/drivers/bus/fsl-mc/fsl-mc-bus.c
index 930d8a3ba722..319a081a29ef 100644
--- a/drivers/bus/fsl-mc/fsl-mc-bus.c
+++ b/drivers/bus/fsl-mc/fsl-mc-bus.c
@@ -905,8 +905,10 @@ int fsl_mc_device_add(struct fsl_mc_obj_desc *obj_desc,
error_cleanup_dev:
kfree(mc_dev->regions);
- kfree(mc_bus);
- kfree(mc_dev);
+ if (is_fsl_mc_bus_dprc(mc_dev))
+ kfree(mc_bus);
+ else
+ kfree(mc_dev);
return error;
}
--
2.30.2
next prev parent reply other threads:[~2024-11-15 2:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-15 2:32 [PATCH v2 0/2] bus: fsl-mc: Fix two double free problems " Su Hui
2024-11-15 2:32 ` Su Hui [this message]
2024-11-15 2:32 ` [PATCH v2 2/2] bus: fsl-mc: using put_device() when add_device() failed " Su Hui
2024-11-15 8:24 ` [PATCH v2 0/2] bus: fsl-mc: Fix two double free problems " Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241115023206.3722933-2-suhui@nfschina.com \
--to=suhui@nfschina.com \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=justinstitt@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=laurentiu.tudor@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=stuyoder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®