From: Antonio Quartulli <antonio@mandelbit.com>
To: linux-mtd@lists.infradead.org
Cc: Antonio Quartulli <antonio@mandelbit.com>,
Richard Weinberger <richard@nod.at>,
Zhihao Cheng <chengzhihao1@huawei.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH] ubifs: fix uninitialized variable usage
Date: Fri, 15 Nov 2024 23:26:34 +0100 [thread overview]
Message-ID: <20241115222634.32259-1-antonio@mandelbit.com> (raw)
In ubifs_jnl_write_inode(), when an inode cannot be deleted
due to too many xattrs, err is passed to ubifs_ro_mode()
uninitialized, thus leading to bogus error reporting.
Fix this case by passing -EPERM, which is the same value that
ubifs_jnl_write_inode() is going to return to the caller.
This fixes 1 UNINIT issue reported by Coverity
Report: CID 1601860: Uninitialized scalar variable (UNINIT)
Cc: Richard Weinberger <richard@nod.at>
Cc: Zhihao Cheng <chengzhihao1@huawei.com>
Cc: linux-kernel@vger.kernel.org (open list)
Signed-off-by: Antonio Quartulli <antonio@mandelbit.com>
---
fs/ubifs/journal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ubifs/journal.c b/fs/ubifs/journal.c
index 8e98be642371..5eedf511880c 100644
--- a/fs/ubifs/journal.c
+++ b/fs/ubifs/journal.c
@@ -983,7 +983,7 @@ int ubifs_jnl_write_inode(struct ubifs_info *c, const struct inode *inode)
if (kill_xattrs && ui->xattr_cnt > ubifs_xattr_max_cnt(c)) {
ubifs_err(c, "Cannot delete inode, it has too much xattrs!");
- ubifs_ro_mode(c, err);
+ ubifs_ro_mode(c, -EPERM);
return -EPERM;
}
--
2.45.2
next reply other threads:[~2024-11-15 22:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-15 22:26 Antonio Quartulli [this message]
2024-11-16 2:02 ` Zhihao Cheng
2024-11-18 10:02 ` Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241115222634.32259-1-antonio@mandelbit.com \
--to=antonio@mandelbit.com \
--cc=chengzhihao1@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®