mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Matt Coster <matt.coster@imgtec.com>
To: Frank Binns <frank.binns@imgtec.com>,
	Matt Coster <matt.coster@imgtec.com>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Nishanth Menon <nm@ti.com>,
	"Vignesh Raghavendra" <vigneshr@ti.com>,
	Tero Kristo <kristo@kernel.org>
Cc: <dri-devel@lists.freedesktop.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, Randolph Sapp <rs@ti.com>,
	Darren Etheridge <detheridge@ti.com>
Subject: [PATCH v2 02/21] dt-bindings: gpu: img: Further constrain clocks
Date: Mon, 18 Nov 2024 13:01:54 +0000	[thread overview]
Message-ID: <20241118-sets-bxs-4-64-patch-v1-v2-2-3fd45d9fb0cf@imgtec.com> (raw)
In-Reply-To: <20241118-sets-bxs-4-64-patch-v1-v2-0-3fd45d9fb0cf@imgtec.com>

All Imagination GPUs use three clocks: core, mem and sys. All reasonably
modern Imagination GPUs also support a single-clock mode where the SoC
only hooks up core and the other two are derived internally. On GPUs which
support this mode, it is the default and most commonly used integration.

Codify this "1 or 3" constraint in our bindings and hang the specifics off
the vendor compatible string to mirror the integration-time choice.

Signed-off-by: Matt Coster <matt.coster@imgtec.com>
---
Changes in v2:
- Simplified clocks constraints (P2)
- Link to v1: https://lore.kernel.org/r/20241105-sets-bxs-4-64-patch-v1-v1-2-4ed30e865892@imgtec.com
---
 .../devicetree/bindings/gpu/img,powervr-rogue.yaml   | 20 +++++++++++---------
 1 file changed, 11 insertions(+), 9 deletions(-)

diff --git a/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml
index ef7070daf213277d0190fe319e202fdc597337d4..3b5a5b966585ac29ad104c7aef19881eca73ce80 100644
--- a/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml
+++ b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml
@@ -29,16 +29,16 @@ properties:
   reg:
     maxItems: 1
 
-  clocks:
-    minItems: 1
-    maxItems: 3
+  clocks: true
 
   clock-names:
-    items:
-      - const: core
-      - const: mem
-      - const: sys
-    minItems: 1
+    oneOf:
+      - items:
+          - const: core
+      - items:
+          - const: core
+          - const: mem
+          - const: sys
 
   interrupts:
     maxItems: 1
@@ -56,11 +56,13 @@ required:
 additionalProperties: false
 
 allOf:
+  # Vendor integrations using a single clock domain
   - if:
       properties:
         compatible:
           contains:
-            const: ti,am62-gpu
+            anyOf:
+              - const: ti,am62-gpu
     then:
       properties:
         clocks:

-- 
2.47.0


  parent reply	other threads:[~2024-11-18 13:29 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-18 13:01 [PATCH v2 00/21] Imagination BXS-4-64 MC1 GPU support Matt Coster
2024-11-18 13:01 ` [PATCH v2 01/21] dt-bindings: gpu: img: More explicit compatible strings Matt Coster
2024-11-20  8:22   ` Krzysztof Kozlowski
2024-11-18 13:01 ` Matt Coster [this message]
2024-11-20  8:25   ` [PATCH v2 02/21] dt-bindings: gpu: img: Further constrain clocks Krzysztof Kozlowski
2024-11-25 18:02   ` Parthiban
2024-11-18 13:01 ` [PATCH v2 03/21] dt-bindings: gpu: img: Power domain details Matt Coster
2024-11-20  8:27   ` Krzysztof Kozlowski
2024-11-18 13:01 ` [PATCH v2 04/21] dt-bindings: gpu: img: Allow dma-coherent Matt Coster
2024-11-20  8:27   ` Krzysztof Kozlowski
2024-11-18 13:01 ` [PATCH v2 05/21] drm/imagination: Use more specific compatible strings Matt Coster
2024-11-20  8:30   ` Krzysztof Kozlowski
2024-11-18 13:01 ` [PATCH v2 06/21] drm/imagination: Add power domain control Matt Coster
2024-11-18 13:01 ` [PATCH v2 07/21] arm64: dts: ti: k3-am62: New GPU binding details Matt Coster
2024-11-20  8:32   ` Krzysztof Kozlowski
2024-11-18 13:02 ` [PATCH v2 08/21] dt-bindings: gpu: img: Add BXS-4-64 devicetree bindings Matt Coster
2024-11-20  8:28   ` Krzysztof Kozlowski
2024-11-18 13:02 ` [PATCH v2 09/21] drm/imagination: Revert to non-threaded IRQs Matt Coster
2024-11-18 13:02 ` [PATCH v2 10/21] drm/imagination: Remove firmware enable_reg Matt Coster
2024-11-18 13:02 ` [PATCH v2 11/21] drm/imagination: Rename event_mask -> status_mask Matt Coster
2024-11-18 13:02 ` [PATCH v2 12/21] drm/imagination: Make has_fixed_data_addr a value Matt Coster
2024-11-18 13:02 ` [PATCH v2 13/21] drm/imagination: Use a lookup table for fw defs Matt Coster
2024-11-18 13:02 ` [PATCH v2 14/21] drm/imagination: Use callbacks for fw irq handling Matt Coster
2024-11-18 13:02 ` [PATCH v2 15/21] drm/imagination: Add register required for RISC-V firmware Matt Coster
2024-11-18 13:02 ` [PATCH v2 16/21] drm/imagination: Move ELF fw utils to common file Matt Coster
2024-11-18 13:02 ` [PATCH v2 17/21] drm/imagination: Add RISC-V firmware processor support Matt Coster
2024-11-18 13:02 ` [PATCH v2 18/21] drm/imagination: Add platform overrides infrastructure Matt Coster
2024-11-18 13:02 ` [PATCH v2 19/21] drm/imagination: Add device_memory_force_cpu_cached override Matt Coster
2024-11-19 18:43   ` Andrew Davis
2024-11-18 13:02 ` [PATCH v2 20/21] drm/imagination: Add support for TI AM68 GPU Matt Coster
2024-11-18 13:02 ` [PATCH v2 21/21] arm64: dts: ti: k3-j721s2: Add GPU node Matt Coster
2024-11-20  8:33   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241118-sets-bxs-4-64-patch-v1-v2-2-3fd45d9fb0cf@imgtec.com \
    --to=matt.coster@imgtec.com \
    --cc=airlied@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=detheridge@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=frank.binns@imgtec.com \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=nm@ti.com \
    --cc=robh@kernel.org \
    --cc=rs@ti.com \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®