From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C12919E998; Mon, 18 Nov 2024 13:34:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.132.182.106 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731936898; cv=none; b=HO1YFxwYvsedTDqvzUsGarufucNPQNHUasBoR5SYm6gaXhTA7LCjA7SClYGS60pbyxiIGTcFdHNbHT/LX2QdDNxDyV5FprFUAhhmxpfD2OSbicChv0IzC1BVpcR6YDLI55/fCgnn32JkFsvK7hiIYIoIr5J1FDmGdXe0Gu3pdxg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731936898; c=relaxed/simple; bh=24/EauieQXJi/pntvKLKiUH0LR79R8xUc5ZSJi/BYeY=; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oGBd7YFOfNPKMy8Q9RAkeKwdCaFfB8Xs/VxM1+wvzziU/urOw/vqw56Ymhk3Z9auj0dQI8YMmy6g4q3Sb7R7GMxYFGU1CJAgofQwYL//gYWC/wQmFhoFbzZGzkTuCL01zYEPAU/Et7A8gwrZjKiZK8GvuQojUIn8ilGUqkoosCI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=ZKjfiG/W; arc=none smtp.client-ip=185.132.182.106 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="ZKjfiG/W" Received: from pps.filterd (m0369458.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4AI92Saa027677; Mon, 18 Nov 2024 14:34:21 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=selector1; bh=kk0fbCm86oNON+VzAknySsP7 MWSV0z1bs5jHXJw47/E=; b=ZKjfiG/Wh8lUk5ragQjXYnM5zxkVWBgG20FGAMTZ bObTmd26MsJl0TVzVROI82uykK1xaUQ8T7cIv9gHxn7bI5v4hoq8irxUkSeYydFl e/R8EadFRHymA3eSpaUeM6mBdGXwrBz1mCoedK/mqsjk+1YN1+qqXHw79/TEwme3 V2EcMlnzkGR5o45io9L3wZdShlLxadvhS0ln4U2wsKh1srWt1a8tBym9/JNLCW6r QJsm4xGwtRmIsNv9M6nEPHQju/eTyDHsvyqCAKsHduaAbGOr9O479i1C4DBwEQ7S k+tYziiyyt4yTdZx8YWiiIvljCf6NwLFnRieisJGu8VHYw== Received: from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 42y5u3n7tn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 18 Nov 2024 14:34:21 +0100 (CET) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id 59F2140052; Mon, 18 Nov 2024 14:33:03 +0100 (CET) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 20D4128AB95; Mon, 18 Nov 2024 14:31:56 +0100 (CET) Received: from gnbcxd0016.gnb.st.com (10.129.178.213) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.37; Mon, 18 Nov 2024 14:31:55 +0100 Date: Mon, 18 Nov 2024 14:31:50 +0100 From: Alain Volmat To: Philipp Zabel CC: Hugues Fruchet , Mauro Carvalho Chehab , Maxime Coquelin , Alexandre Torgue , Hans Verkuil , Sakari Ailus , Rob Herring , Krzysztof Kozlowski , Conor Dooley , , , , , Subject: Re: [PATCH v2 03/15] media: stm32: csi: addition of the STM32 CSI driver Message-ID: <20241118133150.GA2001051@gnbcxd0016.gnb.st.com> References: <20241105-csi_dcmipp_mp25-v2-0-b9fc8a7273c2@foss.st.com> <20241105-csi_dcmipp_mp25-v2-3-b9fc8a7273c2@foss.st.com> <8841158ed61b2b92a92ac6d2afcbd7cff12a6680.camel@pengutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <8841158ed61b2b92a92ac6d2afcbd7cff12a6680.camel@pengutronix.de> X-Disclaimer: ce message est personnel / this message is private X-ClientProxiedBy: EQNCAS1NODE3.st.com (10.75.129.80) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 Hi Philipp On Tue, Nov 05, 2024 at 11:14:47AM +0100, Philipp Zabel wrote: > On Di, 2024-11-05 at 08:49 +0100, Alain Volmat wrote: > > The STM32 CSI controller is tightly coupled with the DCMIPP and act as an > > input stage to receive data coming from the sensor and transferring > > them into the DCMIPP. > > > > Signed-off-by: Alain Volmat > > > > --- > > v2: correct data-lanes handling, using values 1 & 2 > > update yaml filename in MAINTAINERS > > --- > > MAINTAINERS | 8 + > > drivers/media/platform/st/stm32/Kconfig | 14 + > > drivers/media/platform/st/stm32/Makefile | 1 + > > drivers/media/platform/st/stm32/stm32-csi.c | 1144 +++++++++++++++++++++++++++ > > 4 files changed, 1167 insertions(+) > > > [...] > > diff --git a/drivers/media/platform/st/stm32/stm32-csi.c b/drivers/media/platform/st/stm32/stm32-csi.c > > new file mode 100644 > > index 0000000000000000000000000000000000000000..c7f47472c6b3699e94113ce0f38b280a2e45ce15 > > --- /dev/null > > +++ b/drivers/media/platform/st/stm32/stm32-csi.c > > @@ -0,0 +1,1144 @@ > [...] > > +static int stm32_csi_get_resources(struct stm32_csi_dev *csidev, > > + struct platform_device *pdev) > > +{ > > + int irq, ret; > > + > > + csidev->base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL); > > + if (IS_ERR(csidev->base)) > > + return dev_err_probe(&pdev->dev, PTR_ERR(csidev->base), > > + "Failed to ioremap resource\n"); > > + > > + csidev->pclk = devm_clk_get(&pdev->dev, "pclk"); > > + if (IS_ERR(csidev->pclk)) > > + return dev_err_probe(&pdev->dev, PTR_ERR(csidev->pclk), > > + "Couldn't get pclk\n"); > > + > > + csidev->txesc = devm_clk_get(&pdev->dev, "txesc"); > > + if (IS_ERR(csidev->txesc)) > > + return dev_err_probe(&pdev->dev, PTR_ERR(csidev->txesc), > > + "Couldn't get txesc\n"); > > + > > + csidev->csi2phy = devm_clk_get(&pdev->dev, "csi2phy"); > > + if (IS_ERR(csidev->csi2phy)) > > + return dev_err_probe(&pdev->dev, PTR_ERR(csidev->csi2phy), > > + "Couldn't get csi2phy\n"); > > Consider using devm_clk_bulk_get(). Ok, I change this in the v3. > > > + csidev->rstc = devm_reset_control_get_exclusive(&pdev->dev, NULL); > > + if (IS_ERR(csidev->rstc)) > > + return dev_err_probe(&pdev->dev, PTR_ERR(csidev->rstc), > > + "Couldn't get reset control\n"); > > If this wasn't in a separate function, rstc wouldn't have to be stored > on csidev as it's only ever used in stm32_csi_probe(). Ok, whole reset handling moved into the probe function. > > > + > > + csidev->supplies[0].supply = "vdd"; > > + csidev->supplies[1].supply = "vdda18"; > > + ret = devm_regulator_bulk_get(&pdev->dev, ARRAY_SIZE(csidev->supplies), > > + csidev->supplies); > > + if (ret) > > + return dev_err_probe(&pdev->dev, ret, > > + "Failed to request regulator vdd\n"); > > + > > + irq = platform_get_irq(pdev, 0); > > + if (irq < 0) > > + return irq; > > + > > + ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, > > + stm32_csi_irq_thread, IRQF_ONESHOT, > > + dev_name(&pdev->dev), csidev); > > + if (ret) > > + return dev_err_probe(&pdev->dev, ret, > > + "Unable to request irq"); > > + > > + return 0; > > +} > > regards > Philipp Regards Alain