From: Jack Wang <jinpu.wang@ionos.com>
To: yukuai1@huaweicloud.com
Cc: linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org,
song@kernel.org, xni@redhat.com, yangerkun@huawei.com,
yi.zhang@huawei.com, yukuai3@huawei.com
Subject: RE: [PATCH md-6.13 4/5] md/raid5: implement pers->bitmap_sector()
Date: Tue, 19 Nov 2024 10:49:29 +0100 [thread overview]
Message-ID: <20241119094929.148060-1-jinpu.wang@ionos.com> (raw)
In-Reply-To: <20241118114157.355749-6-yukuai1@huaweicloud.com>
Hi Kuai,
Thanks for the patchset, as you mentioned both both hung problem regarding raid5
bitmap, just want to get confirmation, will this patchset fix the hung or just a
performance improvement/code cleanup?
In patch4, as you removed the set/clear bit STRIPE_BITMAP_PENDING, I think you
should also remove the test_bit line in stripe_can_batch, also the definition
enum in raif5.h and the few lines in comments in __add_stripe_bio, same for the
line in break_stripe_batch_list.
Regards!
Jinpu Wang @ IONOS
next prev parent reply other threads:[~2024-11-19 9:49 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-18 11:41 [PATCH md-6.13 0/5] md/md-bitmap: move bitmap_{start,end}write to md upper layer Yu Kuai
2024-11-18 11:41 ` [PATCH md-6.13 1/5] md/md-bitmap: factor behind write counters out from bitmap_{start/end}write() Yu Kuai
2024-11-22 2:16 ` Xiao Ni
2024-11-18 11:41 ` [PATCH md-6.13 2/5] md/md-bitmap: remove the last parameter for bimtap_ops->endwrite() Yu Kuai
2024-11-18 11:41 ` [PATCH md-6.13 3/5] md: add a new callback pers->bitmap_sector() Yu Kuai
2024-11-22 2:17 ` Xiao Ni
2024-11-18 11:41 ` [PATCH md-6.13 4/5] md/raid5: implement pers->bitmap_sector() Yu Kuai
2024-11-18 11:41 ` [PATCH md-6.13 5/5] md/md-bitmap: move bitmap_{start, end}write to md upper layer Yu Kuai
2024-11-19 9:49 ` Jack Wang [this message]
2024-11-19 10:58 ` [PATCH md-6.13 4/5] md/raid5: implement pers->bitmap_sector() Yu Kuai
2024-11-19 15:29 ` Jack Wang
2024-11-21 8:10 ` Jinpu Wang
2024-11-21 8:33 ` Yu Kuai
2024-11-21 8:40 ` Jinpu Wang
2024-11-21 8:44 ` Yu Kuai
2024-11-21 8:46 ` Jinpu Wang
2024-11-21 9:30 ` Christian Theune
2024-11-21 11:01 ` Yu Kuai
2024-11-21 12:05 ` Christian Theune
2024-11-21 12:21 ` Christian Theune
2024-11-21 12:37 ` Yu Kuai
2024-11-21 16:14 ` Christian Theune
2024-11-22 2:06 ` [PATCH md-6.13 5/5] md/md-bitmap: move bitmap_{start, end}write to md upper layer Xiao Ni
2024-11-22 2:45 ` Yu Kuai
2024-11-22 3:14 ` Xiao Ni
2024-11-22 8:32 ` Yu Kuai
2024-11-23 3:55 ` Xiao Ni
2024-11-25 1:15 ` Yu Kuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241119094929.148060-1-jinpu.wang@ionos.com \
--to=jinpu.wang@ionos.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=song@kernel.org \
--cc=xni@redhat.com \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®