From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6358B137775 for ; Tue, 19 Nov 2024 14:00:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732024852; cv=none; b=nqrMpnOz7LkSYB3QEa8M5w3NP1oWSqIUVpnzHu0pKbdxTazuOm44yExLZN7LGkfRJZNEwQ8zdxjGspZOm52RDX3gcAzQTxeqwT9H1AprkYN5NTV3cICHNeq7Ggi5cmtCsSIvJzEzrk97akTI2ENAG+rSuBYqpaEKt6luWzR0kYI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732024852; c=relaxed/simple; bh=kf3Z6I24SKWn5bdSsa1E0NrkCUFicEWYJkJii1hPtGM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WgQ/Io65zvU1O+kxkYamedrsNF7/cKY7RWBKP7NoKBjqhhC3T6KIGL9dn5pFfdgVMVZi17M4mmf2o2Iqk9G75Jm48vC8UwCfkQB4s1V9cOFcMLWG1zdVZcDnhTQLrZh12BC4jyKn8pMJwBr6v+RNpFCJhJ/yiiXMBJ7ZZzAwyu4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=l2kGqu0e; arc=none smtp.client-ip=209.85.160.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="l2kGqu0e" Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-4609c96b2e5so6081811cf.0 for ; Tue, 19 Nov 2024 06:00:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1732024849; x=1732629649; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=utcZjeJ4axtWtuvENXsYE5WdR2pTF/ksB5rq4r17jag=; b=l2kGqu0ew9kLEZ8WGxTHKkWAMn5ZBZ6u+ww4hTH3xTRQ9LmXuNgCScfQtOvI983Bxk PjaIuvkfWom5B0zB5i67cOCOTHag01vtqntwZ/lxxqjSyvCzj7gwtCHtVk/TSicgHhFW 7G0QbALTLC/Bx//oG9yPOIdpQzDX2lPneRc5+bSL83R1mYLM7bElAWhT3gEgCuNRJx2x ZAggA7jqm8RYdhpPovQdoeb1KhvqH0wgCarQYoVIpS2v1YtQw1MrKVFjJVqqviPsCvMn pfgtHvfiCTSudTpF8E17a46YzBK+SBlsGoPeH71oTMmAnwNk2KvKDIRMDuCgnmCgtjq0 jJoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732024849; x=1732629649; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=utcZjeJ4axtWtuvENXsYE5WdR2pTF/ksB5rq4r17jag=; b=afN8ult5KUfxd4UnM9wBBwUt3ScsW35KrvJDDAmz8MHqsitNz6YBwE/Al85WgwZjdr kXyj4DNcSvMQLe/n5wcWHhFEd9rRoXh+0p4AoqSLFlFAQHARVBK+H7up+vb7x4CKF0Uh UxNhCXlk14YhsP/IlIR3nU/m5f7OLMj4pCgeN+Uf+Fp4MP5mHR5glavNK4v3dnx41OTp x9bnrJiHwuiBMERCmdxHmW7MIIonZuHqOBgMixX6WZxq2KTv0cpfsePX33Kl+hRg7oSI LxCwBv58E/EkeKZ8chgIniSn8lzVVGYL/O4zLS6+1aPfqQiad9nH16ft0E5LnKrYxBlm K/Og== X-Forwarded-Encrypted: i=1; AJvYcCVTbwCmbESEdUXGwNejG/6/NtOUtuA4tkWPh+eiH5PVOc0V3bBtfIIM79pMeLMHstVxuWzHjIogFtb2ufE=@vger.kernel.org X-Gm-Message-State: AOJu0YzX1HvCOiMk7NJVCG9dth+uPPMhcgiCMF63HGaC/D5KZx0UUnJa ICLydSyfjS6Xc0JVQTfi5gnuKC2b4KydM90aSznCNGxP18Si15VSPI2HHH0pfu5PbADmI/9finf 6 X-Google-Smtp-Source: AGHT+IHKbzbz2zzGHIA7vNzQrKdrVbH22etzYZttFKms0g8ZJKuTulmGaSp4Zqq0m5k19nTsP7U0iw== X-Received: by 2002:a05:622a:10f:b0:45f:788:b1b1 with SMTP id d75a77b69052e-46363e2f7d2mr196949061cf.25.1732024849064; Tue, 19 Nov 2024 06:00:49 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-68-128-5.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.128.5]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-46392c3c22fsm11239771cf.86.2024.11.19.06.00.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Nov 2024 06:00:48 -0800 (PST) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1tDOmd-00000003DsE-272U; Tue, 19 Nov 2024 10:00:47 -0400 Date: Tue, 19 Nov 2024 10:00:47 -0400 From: Jason Gunthorpe To: Andrew Jones Cc: iommu@lists.linux.dev, kvm-riscv@lists.infradead.org, kvm@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, tjeznach@rivosinc.com, zong.li@sifive.com, joro@8bytes.org, will@kernel.org, robin.murphy@arm.com, anup@brainfault.org, atishp@atishpatra.org, tglx@linutronix.de, alex.williamson@redhat.com, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu Subject: Re: [RFC PATCH 08/15] iommu/riscv: Add IRQ domain for interrupt remapping Message-ID: <20241119140047.GC559636@ziepe.ca> References: <20241114161845.502027-17-ajones@ventanamicro.com> <20241114161845.502027-25-ajones@ventanamicro.com> <20241118184336.GB559636@ziepe.ca> <20241119-62ff49fc1eedba051838dba2@orel> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241119-62ff49fc1eedba051838dba2@orel> On Tue, Nov 19, 2024 at 08:49:37AM +0100, Andrew Jones wrote: > On Mon, Nov 18, 2024 at 02:43:36PM -0400, Jason Gunthorpe wrote: > > On Thu, Nov 14, 2024 at 05:18:53PM +0100, Andrew Jones wrote: > > > @@ -1276,10 +1279,30 @@ static int riscv_iommu_attach_paging_domain(struct iommu_domain *iommu_domain, > > > struct riscv_iommu_device *iommu = dev_to_iommu(dev); > > > struct riscv_iommu_info *info = dev_iommu_priv_get(dev); > > > struct riscv_iommu_dc dc = {0}; > > > + int ret; > > > > > > if (!riscv_iommu_pt_supported(iommu, domain->pgd_mode)) > > > return -ENODEV; > > > > > > + if (riscv_iommu_bond_link(domain, dev)) > > > + return -ENOMEM; > > > + > > > + if (iommu_domain->type == IOMMU_DOMAIN_UNMANAGED) { > > > > Drivers should not be making tests like this. > > > > > + domain->gscid = ida_alloc_range(&riscv_iommu_gscids, 1, > > > + RISCV_IOMMU_MAX_GSCID, GFP_KERNEL); > > > + if (domain->gscid < 0) { > > > + riscv_iommu_bond_unlink(domain, dev); > > > + return -ENOMEM; > > > + } > > > + > > > + ret = riscv_iommu_irq_domain_create(domain, dev); > > > + if (ret) { > > > + riscv_iommu_bond_unlink(domain, dev); > > > + ida_free(&riscv_iommu_gscids, domain->gscid); > > > + return ret; > > > + } > > > + } > > > > What are you trying to do? Make something behave different for VFIO? > > That isn't OK, we are trying to remove all the hacky VFIO special > > cases in drivers. > > > > What is the HW issue here? It is very very strange (and probably not > > going to work right) that the irq domains change when domain > > attachment changes. > > > > The IRQ setup should really be fixed before any device drivers probe > > onto the device. > > I can't disagree with the statement that this looks hacky, but considering > a VFIO domain needs to use the g-stage for its single-stage translation > and a paging domain for the host would use s-stage, then it seems we need > to identify the VFIO domains for their special treatment. This is the wrong thinking entirely. There is no such thing as a "VFIO domain". Default VFIO created domains should act excatly the same as a DMA API domain. If you want your system to have irq remapping, then it should be on by default and DMA API gets remapping too. There would need to be a very strong reason not to do that in order to make something special for riscv. If so you'd need to add some kind of flag to select it. Until you reach nested translation there is no "need" for VFIO to use any particular stage. The design is that default VFIO uses the same stage as the DMA API because it is doing the same basic default translation function. Nested translation has a control to select the stage, and you can then force the g-stage for VFIO users at that point. Regardless, you must not use UNMANAGED as some indication of VFIO, that is not what it means, that is not what it is for. > Is there an example of converting VFIO special casing in other > drivers to something cleaner that you can point me at? Nobody has had an issue where they want interrupt remapping on/off depending on VFIO. I think that is inherently wrong. > The IRQ domain will only be useful for device assignment, as that's when > an MSI translation will be needed. I can't think of any problems that > could arise from only creating the IRQ domain when probing assigned > devices, but I could certainly be missing something. Do you have some > potential problems in mind? I'm not an expert in the interrupt subsystem, but my understanding was we expect the interrupt domains/etc to be static once a device driver is probed. Changing things during iommu domain attach is after drivers are probed. I don't really expect it to work correctly in all corner cases. VFIO is allowed to change the translation as it operates and we expect that interrupts are not disturbed. Jason