From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E19E814AD1A for ; Tue, 19 Nov 2024 17:04:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732035869; cv=none; b=IM7kMWLmAqaCO9/zhlCAfv1cN4bqAe0Lhtiuzl2U76Umi6zVQYPQKb0sD9w4smzVAmfmpzqX39pdQOScSR0necAhFnSdcIo7mPX3WapHCsTjXS7FlFiYL5NsMyrAoSgLfcDBprPeXPUV0sG8pb9aoTYkh1kQ+t5GEW+z2uSpSr8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732035869; c=relaxed/simple; bh=JLSO53zWiRurLZgkEVkHh6GEFG2ijbePpRs42IOEJIA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HxnBC7sYngrjpcUTIJf0Wz7URWX1LZUiCEYAjBeVz/zqdcWF0W+6RcBTUf4ZN9nIn2sybQCBLxj52E5JpxPjijxp3BaAC5Zck7F3kP4rnpBAV4TVh2GmYkloZkxmQlOzrbMk6DRxfWHEFSD5PFQG3FhcQMYrSmVFYiwhzrmTD6U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=DNU2Z6tp; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DNU2Z6tp" Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-7f8cc29aaf2so843455a12.3 for ; Tue, 19 Nov 2024 09:04:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1732035867; x=1732640667; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=M7G/ON1XPIM+nLaKFx55E9lPI7ZbdMAymv55tloDTzs=; b=DNU2Z6tph4gXZ6GeQs3i5WDgwQe5UABY77XB+UlSjyZ+p8pXxKIa/EBXcARqsd+lm6 jMVef+Z7XnssZnE3n/GFgESV11awty+2Xe4NGUrVLkEjrfmJYR0SnA9AmJVtFaCwQFmg vi0afBbqkButXEXz5Wx3CCD29xE3pi+OT5iW7ceVS1+WoSgWeeNAKfgH4BUM94zIJQ0Y ErMotzHI395L8a6ZaogXuzlFBjlg8nMSIZPEZjKljd+96B6BnJroBIsBqvSRsLFOHJ6e A4eFBjR0KVj3C9brQKRl2ppHK0WYksUqm+AIUXA9zWmplQKpAX+aNLSAxOhGYyzR+eam ylyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732035867; x=1732640667; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=M7G/ON1XPIM+nLaKFx55E9lPI7ZbdMAymv55tloDTzs=; b=f8C4DAQjIzb4HHUEM05CZ/3lvJuZk53f4Rz4yRUGOi16PEkTIuVxzHJFHQTtT1RQtQ OgDx4KU0UbbU6iQ9jpG3Yoxxd34g45l6sdrmJqLplO/GrkY3F1SkfRurwoeELumMN207 FoAAURdfhqBlvClefLbU315jEGiJB6VMMf+sDaHw6bSJCVFDUjVN58dvy6zW2AcTqy1M wMrQnX/1kqBnCcWPwnRgI8e6BEmzzP1Nmf5YarG6bO72vwYktFnop0flzzSxUZG7q5z0 7PQYW84i8lYa+0hENcrleZ0QipjAsRvkewt+qnfeMUszoKKQKU0sTZL2M5a8k1wgY9qF DunQ== X-Forwarded-Encrypted: i=1; AJvYcCWfrgCbQOxdTlMqL+y5EuJSCRYUux/m9SbF0e6VqtxAV9X9R466Wa3pa6WMAyvg/Uh7lGYszmFeQNWEzZY=@vger.kernel.org X-Gm-Message-State: AOJu0YwYs7cO0mHJDz+YBU4ZvtYdCs+7zhVVfYSQKXvW3VA+Q5EF+5IO b6SlcvmqaRFHHaJRy00Tx6rZ+29tJuS2NZ3QDCt3QOpn3bOtZsUMd9YQ9xIMoQ== X-Google-Smtp-Source: AGHT+IHKqW9avdg6R0UhtuehadqqtqXGT50NzKijPuK4my4mXXocf1FJrKvkRfDHMzoWI6jjr0c1pA== X-Received: by 2002:a05:6a20:7491:b0:1db:f89a:c6fe with SMTP id adf61e73a8af0-1dc90bde9e5mr25294921637.32.1732035867078; Tue, 19 Nov 2024 09:04:27 -0800 (PST) Received: from thinkpad ([36.255.17.169]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7f8c1dada40sm7961710a12.61.2024.11.19.09.04.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Nov 2024 09:04:26 -0800 (PST) Date: Tue, 19 Nov 2024 22:34:21 +0530 From: Manivannan Sadhasivam To: Rob Herring Cc: Jingoo Han , Bjorn Helgaas , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Krzysztof Kozlowski , Conor Dooley , Gustavo Pimentel , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dt-bindings: PCI: snps,dw-pcie: Drop "#interrupt-cells" from example Message-ID: <20241119170421.xxku2gkp3wea2xvf@thinkpad> References: <20241105213217.442809-1-robh@kernel.org> <20241115072604.yre2d7yiclt5d3w5@thinkpad> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Nov 15, 2024 at 08:07:07AM -0600, Rob Herring wrote: > On Fri, Nov 15, 2024 at 1:26 AM Manivannan Sadhasivam > wrote: > > > > On Tue, Nov 05, 2024 at 03:32:16PM -0600, Rob Herring (Arm) wrote: > > > "#interrupt-cells" is not valid without a corresponding "interrupt-map" > > > or "interrupt-controller" property. As the example has neither, drop > > > "#interrupt-cells". This fixes a dtc interrupt_provider warning. > > > > > > > But the DWC controllers have an in-built MSI controller. Shouldn't we add > > 'interrrupt-controller' property then? > > Why? Is that needed for the MSI controller to function? I don't think so. > No. I was asking from bindings perspective. > Now we do have "interrupt-controller" present for a number of MSI > providers. I suspect that's there to get OF_DECLARE to work, but I > doubt we really need MSI controllers initialized early. > Again no, for this case. I was under the assumption that all interrupt providers should have the 'interrupt-controller' property in their nodes. - Mani -- மணிவண்ணன் சதாசிவம்