From: Peter Colberg <peter.colberg@intel.com>
To: Wu Hao <hao.wu@intel.com>, Tom Rix <trix@redhat.com>,
Moritz Fischer <mdf@kernel.org>, Xu Yilun <yilun.xu@intel.com>,
linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Russ Weight <russ.weight@linux.dev>,
Marco Pagani <marpagan@redhat.com>,
Matthew Gerlach <matthew.gerlach@linux.intel.com>,
Basheer Ahmed Muddebihal
<basheer.ahmed.muddebihal@linux.intel.com>,
Peter Colberg <peter.colberg@intel.com>
Subject: [PATCH v5 16/18] fpga: dfl: remove unneeded function build_info_create_dev()
Date: Tue, 19 Nov 2024 20:10:32 -0500 [thread overview]
Message-ID: <20241120011035.230574-17-peter.colberg@intel.com> (raw)
In-Reply-To: <20241120011035.230574-1-peter.colberg@intel.com>
Remove the function build_info_create_dev(), which no longer serves its
original purpose now that the allocation of the platform device has been
moved to feature_dev_register().
Signed-off-by: Peter Colberg <peter.colberg@intel.com>
Reviewed-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
Reviewed-by: Basheer Ahmed Muddebihal <basheer.ahmed.muddebihal@linux.intel.com>
---
Changes since v4:
- Revise commit description to be confirmative, from (the function)
"may be removed" to "Remove the function".
Changes since v3:
- New patch extracted from last patch of v3 series.
---
drivers/fpga/dfl.c | 17 ++---------------
1 file changed, 2 insertions(+), 15 deletions(-)
diff --git a/drivers/fpga/dfl.c b/drivers/fpga/dfl.c
index 91f12272da3e..203b14e292b4 100644
--- a/drivers/fpga/dfl.c
+++ b/drivers/fpga/dfl.c
@@ -858,16 +858,6 @@ binfo_create_feature_dev_data(struct build_feature_devs_info *binfo)
return fdata;
}
-static int
-build_info_create_dev(struct build_feature_devs_info *binfo)
-{
- binfo->feature_num = 0;
-
- INIT_LIST_HEAD(&binfo->sub_features);
-
- return 0;
-}
-
/*
* register current feature device, it is called when we need to switch to
* another feature parsing or we have parsed all features on given device
@@ -1326,11 +1316,8 @@ static int parse_feature_fiu(struct build_feature_devs_info *binfo,
return -EINVAL;
binfo->type = type;
-
- /* create platform device for dfl feature dev */
- ret = build_info_create_dev(binfo);
- if (ret)
- return ret;
+ binfo->feature_num = 0;
+ INIT_LIST_HEAD(&binfo->sub_features);
ret = create_feature_instance(binfo, 0, 0, 0);
if (ret)
--
2.47.0
next prev parent reply other threads:[~2024-11-20 1:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-20 1:10 [PATCH v5 00/18] fpga: dfl: fix kernel warning on port release/assign for SRIOV Peter Colberg
2024-11-20 1:10 ` [PATCH v5 01/18] fpga: dfl: omit unneeded argument pdata from dfl_feature_instance_init() Peter Colberg
2024-11-20 1:10 ` [PATCH v5 02/18] fpga: dfl: return platform data from dfl_fpga_inode_to_feature_dev_data() Peter Colberg
2024-11-20 1:10 ` [PATCH v5 03/18] fpga: dfl: afu: use parent device to log errors on port enable/disable Peter Colberg
2024-11-20 1:10 ` [PATCH v5 04/18] fpga: dfl: afu: define local pointer to feature device Peter Colberg
2024-11-20 1:10 ` [PATCH v5 05/18] fpga: dfl: pass feature platform data instead of device as argument Peter Colberg
2024-11-20 1:10 ` [PATCH v5 06/18] fpga: dfl: factor out feature data creation from build_info_commit_dev() Peter Colberg
2024-11-20 1:10 ` [PATCH v5 07/18] fpga: dfl: store FIU type in feature platform data Peter Colberg
2024-11-20 1:10 ` [PATCH v5 08/18] fpga: dfl: refactor internal DFL APIs to take/return feature device data Peter Colberg
2024-11-20 1:10 ` [PATCH v5 09/18] fpga: dfl: factor out feature device registration Peter Colberg
2024-11-20 1:10 ` [PATCH v5 10/18] fpga: dfl: factor out feature device data from platform device data Peter Colberg
2024-11-20 1:10 ` [PATCH v5 11/18] fpga: dfl: convert features from flexible array member to separate array Peter Colberg
2024-11-20 1:10 ` [PATCH v5 12/18] fpga: dfl: store MMIO resources in feature device data Peter Colberg
2024-11-20 1:10 ` [PATCH v5 13/18] fpga: dfl: store platform device name " Peter Colberg
2024-11-20 1:10 ` [PATCH v5 14/18] fpga: dfl: store platform device id " Peter Colberg
2024-11-20 1:10 ` [PATCH v5 15/18] fpga: dfl: allocate platform device after " Peter Colberg
2024-11-20 1:10 ` Peter Colberg [this message]
2024-11-20 1:10 ` [PATCH v5 17/18] fpga: dfl: drop unneeded get_device() and put_device() of feature device Peter Colberg
2024-11-20 1:10 ` [PATCH v5 18/18] fpga: dfl: destroy/recreate feature platform device on port release/assign Peter Colberg
2024-12-10 9:07 ` [PATCH v5 00/18] fpga: dfl: fix kernel warning on port release/assign for SRIOV Xu Yilun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241120011035.230574-17-peter.colberg@intel.com \
--to=peter.colberg@intel.com \
--cc=basheer.ahmed.muddebihal@linux.intel.com \
--cc=hao.wu@intel.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marpagan@redhat.com \
--cc=matthew.gerlach@linux.intel.com \
--cc=mdf@kernel.org \
--cc=russ.weight@linux.dev \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®