From: Peter Zijlstra <peterz@infradead.org>
To: Christian Brauner <brauner@kernel.org>
Cc: Mateusz Guzik <mjguzik@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] seqlock: annotate spinning as unlikely() in __read_seqcount_begin
Date: Wed, 20 Nov 2024 15:47:11 +0100 [thread overview]
Message-ID: <20241120144711.GH19989@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20241120-gastgewerbe-oblag-e8e208731117@brauner>
On Wed, Nov 20, 2024 at 12:11:45PM +0100, Christian Brauner wrote:
> On Thu, 27 Jul 2023 20:03:55 +0200, Mateusz Guzik wrote:
> > Annotation already used to be there, but got lost in 52ac39e5db5148f7
> > ("seqlock: seqcount_t: Implement all read APIs as statement expressions").
> > Does not look like it was intentional.
> >
> > Without it gcc 12 decides to compile the following in path_init:
> > nd->m_seq = __read_seqcount_begin(&mount_lock.seqcount);
> > nd->r_seq = __read_seqcount_begin(&rename_lock.seqcount);
> >
> > [...]
>
> Applied to the vfs-6.14.misc branch of the vfs/vfs.git tree.
> Patches in the vfs-6.14.misc branch should appear in linux-next soon.
>
> Please report any outstanding bugs that were missed during review in a
> new review to the original patch series allowing us to drop it.
>
> It's encouraged to provide Acked-bys and Reviewed-bys even though the
> patch has now been applied. If possible patch trailers will be updated.
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
prev parent reply other threads:[~2024-11-20 14:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 18:03 Mateusz Guzik
2024-11-20 11:11 ` Christian Brauner
2024-11-20 14:47 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241120144711.GH19989@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=brauner@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjguzik@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome