From: "Kryštof Černý via B4 Relay" <devnull+cleverline1mc.gmail.com@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Rob Herring <robh@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Stefan Wahren <stefan.wahren@chargebyte.com>
Cc: "Ben Gardner" <bgardner@wabtec.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
"Kryštof Černý" <cleverline1mc@gmail.com>
Subject: [PATCH v2 1/3] w1: ds2482: Add regulator support
Date: Fri, 22 Nov 2024 09:53:57 +0100 [thread overview]
Message-ID: <20241122-ds2482-add-reg-v2-1-a5a03ee74da7@gmail.com> (raw)
In-Reply-To: <20241122-ds2482-add-reg-v2-0-a5a03ee74da7@gmail.com>
From: Kryštof Černý <cleverline1mc@gmail.com>
Adds a support for attaching a supply regulator.
Signed-off-by: Kryštof Černý <cleverline1mc@gmail.com>
---
drivers/w1/masters/ds2482.c | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/drivers/w1/masters/ds2482.c b/drivers/w1/masters/ds2482.c
index a2ecbb863c57f38bffc8e3cd463db1940e603179..3fb35e92fc1587dc4e609c0061fa5057e0027a80 100644
--- a/drivers/w1/masters/ds2482.c
+++ b/drivers/w1/masters/ds2482.c
@@ -15,6 +15,7 @@
#include <linux/slab.h>
#include <linux/i2c.h>
#include <linux/delay.h>
+#include <linux/regulator/consumer.h>
#include <linux/w1.h>
@@ -117,6 +118,9 @@ struct ds2482_data {
u8 channel;
u8 read_prt; /* see DS2482_PTR_CODE_xxx */
u8 reg_config;
+
+ /* reference to the optional regulator */
+ struct regulator *vcc_reg;
};
@@ -445,6 +449,7 @@ static int ds2482_probe(struct i2c_client *client)
int err = -ENODEV;
int temp1;
int idx;
+ int ret;
if (!i2c_check_functionality(client->adapter,
I2C_FUNC_SMBUS_WRITE_BYTE_DATA |
@@ -457,6 +462,18 @@ static int ds2482_probe(struct i2c_client *client)
goto exit;
}
+ /* Get the vcc regulator */
+ data->vcc_reg = devm_regulator_get(&client->dev, "vcc");
+ if (IS_ERR(data->vcc_reg))
+ return PTR_ERR(data->vcc_reg);
+
+ /* Enable the vcc regulator */
+ ret = regulator_enable(data->vcc_reg);
+ if (ret) {
+ dev_err(&client->dev, "Fail to enable regulator\n");
+ return ret;
+ }
+
data->client = client;
i2c_set_clientdata(client, data);
@@ -517,6 +534,7 @@ static int ds2482_probe(struct i2c_client *client)
w1_remove_master_device(&data->w1_ch[idx].w1_bm);
}
exit_free:
+ regulator_disable(data->vcc_reg);
kfree(data);
exit:
return err;
@@ -533,6 +551,9 @@ static void ds2482_remove(struct i2c_client *client)
w1_remove_master_device(&data->w1_ch[idx].w1_bm);
}
+ /* Disable the vcc regulator */
+ regulator_disable(data->vcc_reg);
+
/* Free the memory */
kfree(data);
}
--
2.39.5
next prev parent reply other threads:[~2024-11-22 8:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-22 8:53 [PATCH v2 0/3] Add support for attaching a regulator to w1: ds2482 Kryštof Černý via B4 Relay
2024-11-22 8:53 ` Kryštof Černý via B4 Relay [this message]
2024-11-23 16:32 ` [PATCH v2 1/3] w1: ds2482: Add regulator support Krzysztof Kozlowski
2024-11-24 10:22 ` Kryštof Černý
2024-11-24 10:50 ` Krzysztof Kozlowski
2024-11-22 8:53 ` [PATCH v2 2/3] w1: ds2482: Fix datasheet URL Kryštof Černý via B4 Relay
2024-11-22 8:53 ` [PATCH v2 3/3] dt-bindings: w1: ds2482: Add vcc-supply property Kryštof Černý via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241122-ds2482-add-reg-v2-1-a5a03ee74da7@gmail.com \
--to=devnull+cleverline1mc.gmail.com@kernel.org \
--cc=bgardner@wabtec.com \
--cc=cleverline1mc@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=stefan.wahren@chargebyte.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®