mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Artem Panfilov <panfilov.artyom@gmail.com>
Cc: "Maxime Chevallier" <maxime.chevallier@bootlin.com>,
	linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Alexis Lothoré" <alexis.lothore@bootlin.com>,
	thomas.petazzoni@bootlin.com
Subject: [PATCH 1/2] rtc: ab-eoz9: check the lowest voltage threshold first
Date: Fri, 22 Nov 2024 11:10:29 +0100	[thread overview]
Message-ID: <20241122101031.68916-2-maxime.chevallier@bootlin.com> (raw)
In-Reply-To: <20241122101031.68916-1-maxime.chevallier@bootlin.com>

When checking the internal status flags for time validity, 2 different
voltage thresholds are verified :

VLOW1 is at 2.1V and indicates that temperature monitoring isn't
possible at that voltage. This stops any temperature compensation and
can cause time deviations

VLOW2 is at 1.3V, below that voltage no timekeeping is possible.

In both cases, we consider the reported time to be unreliable and print
a warning.

The current code checks for VLOW1 undervoltage first, but as it is higher
than VLOW2 it will always trigger before the VLOW2 threshold is hit.

Make sure we first check the VLOW2 condition when checking time
validity.

Fixes: 67075b63cce2 ("rtc: add AB-RTCMC-32.768kHz-EOZ9 RTC support")
Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
---
 drivers/rtc/rtc-ab-eoz9.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/rtc/rtc-ab-eoz9.c b/drivers/rtc/rtc-ab-eoz9.c
index 02f7d0711287..85853da258d2 100644
--- a/drivers/rtc/rtc-ab-eoz9.c
+++ b/drivers/rtc/rtc-ab-eoz9.c
@@ -116,15 +116,15 @@ static int abeoz9_check_validity(struct device *dev)
 		return -EINVAL;
 	}
 
-	if (val & ABEOZ9_REG_CTRL_STATUS_V1F) {
+	if (val & ABEOZ9_REG_CTRL_STATUS_V2F) {
 		dev_warn(dev,
-			 "voltage drops below VLOW1 threshold, date is invalid\n");
+			 "voltage drops below VLOW2 threshold, date is invalid\n");
 		return -EINVAL;
 	}
 
-	if ((val & ABEOZ9_REG_CTRL_STATUS_V2F)) {
+	if ((val & ABEOZ9_REG_CTRL_STATUS_V1F)) {
 		dev_warn(dev,
-			 "voltage drops below VLOW2 threshold, date is invalid\n");
+			 "voltage drops below VLOW1 threshold, date is invalid\n");
 		return -EINVAL;
 	}
 
-- 
2.47.0


  reply	other threads:[~2024-11-22 10:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-22 10:10 [PATCH 0/2] rtc: ab-eoz9: fix the undervoltage handling Maxime Chevallier
2024-11-22 10:10 ` Maxime Chevallier [this message]
2024-11-22 10:10 ` [PATCH 2/2] rtc: ab-eoz9: don't fail temperature reads on undervoltage notification Maxime Chevallier
2024-11-25 22:34   ` (subset) " Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241122101031.68916-2-maxime.chevallier@bootlin.com \
    --to=maxime.chevallier@bootlin.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=alexis.lothore@bootlin.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=panfilov.artyom@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®