From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9250818133F for ; Fri, 22 Nov 2024 10:40:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732272055; cv=none; b=LiWpn4ADZvHBnuEK+EUFfjwXyrn9Fh65qg+bvUW9BiYlYn5IOYMEx39IjGlQgz14KdOdqqXzFhMEBl4bEdwQ7VgNeLuvjO+oOYKJOVc26+ehekWDb6ARnZ6yvYDLha5B2YobBaUkj+fn7sP+gVFtRhnUperBfltw0TOw2kN2toY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732272055; c=relaxed/simple; bh=lIcErWtDG7meN2uYFd1HD/oKJHuNqmctc/9BNxKL5cQ=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=sUKagXGVY99wpEoX04fcOmP2z2JltNgwiEEYLny8KpNI+oYwGphwler8ro1srsPA+lo3PEPVRQQW39f2+xpRV2agly+A28FABpNksTScz4wPkjdE7UPxbRcqlb5uOXTR7vHR1qoDbvZFiUYLJwPQkG4BCze81lbjEeyY4vq/U9g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=j6ts14M+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="j6ts14M+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 61BD1C4CECE; Fri, 22 Nov 2024 10:40:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1732272055; bh=lIcErWtDG7meN2uYFd1HD/oKJHuNqmctc/9BNxKL5cQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=j6ts14M+QIv0FkNQUbj66UZvBHV29ph/wHAUtDaqkCVxYmMl5uOPScwOp43O4NXEP 9zTbsx9+rZQVS4oDHkNe50X3zpYP52eLun2b+1Rp/Uk0HqmHYKLcEdRPxEo7dQZeCq UcvOfrHRI4RsnAgANHTP2Xafr4J6TsaAGqRZvZ9J5P+P/UsUK2JXf/UuPhRqGq/GSB SmIBX3+YxCzLo9X93pr7LH/T/1W/SQjvW/+PlgWx9w0KqftT4N0EUVlcSwGdk6pQ25 QJop9WM221HzxLQQ6UcJWVnIFNMzrDRSbLOPiz7sDLx9FsIyGqHFKPt6ihkZ1iZEq4 MwsA0q3iX8bmw== Date: Fri, 22 Nov 2024 11:40:50 +0100 From: Mauro Carvalho Chehab To: Jonathan Cameron Cc: Igor Mammedov , Shiju Jose , "Michael S. Tsirkin" , Ani Sinha , , Subject: Re: [PATCH 5/6] acpi/generic_event_device: Update GHES migration to cover hest addr Message-ID: <20241122114050.51b60f1a@foz.lan> In-Reply-To: <20241120150119.00007d3d@huawei.com> References: <6391dfec0a26b83641c2b2062115b839490cc902.1731486604.git.mchehab+huawei@kernel.org> <20241120150119.00007d3d@huawei.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Em Wed, 20 Nov 2024 15:01:19 +0000 Jonathan Cameron escreveu: > On Wed, 13 Nov 2024 09:37:02 +0100 > Mauro Carvalho Chehab wrote: > > > The GHES migration logic at GED should now support HEST table > > location too. > > > > Increase migration version and change needed to check for both > > ghes_addr_le and hest_addr_le. > > Where is the migration version increased? Maybe I'm misunderstanding > the comment. Legacy comment. We dropped migration version increase, as this is not needed anymore. Comment dropped. > > > > > Signed-off-by: Mauro Carvalho Chehab > > --- > > hw/acpi/generic_event_device.c | 29 +++++++++++++++++++++++++++++ > > 1 file changed, 29 insertions(+) > > > > diff --git a/hw/acpi/generic_event_device.c b/hw/acpi/generic_event_device.c > > index 17baf36132a8..c1116dd8d7ae 100644 > > --- a/hw/acpi/generic_event_device.c > > +++ b/hw/acpi/generic_event_device.c > > @@ -387,6 +387,34 @@ static const VMStateDescription vmstate_ghes_state = { > > } > > }; > > > > +static const VMStateDescription vmstate_hest = { > > + .name = "acpi-hest", > > + .version_id = 1, > > + .minimum_version_id = 1, > > + .fields = (const VMStateField[]) { > > + VMSTATE_UINT64(hest_addr_le, AcpiGhesState), > > + VMSTATE_END_OF_LIST() > > + }, > > +}; > > + > > +static bool hest_needed(void *opaque) > > +{ > > + AcpiGedState *s = opaque; > > + return s->ghes_state.hest_addr_le; > > +} > > + > > +static const VMStateDescription vmstate_hest_state = { > > + .name = "acpi-ged/hest", > > + .version_id = 1, > > + .minimum_version_id = 1, > > + .needed = hest_needed, > > + .fields = (const VMStateField[]) { > > + VMSTATE_STRUCT(ghes_state, AcpiGedState, 1, > > + vmstate_hest, AcpiGhesState), > > + VMSTATE_END_OF_LIST() > > + } > > +}; > > + > > static const VMStateDescription vmstate_acpi_ged = { > > .name = "acpi-ged", > > .version_id = 1, > > @@ -399,6 +427,7 @@ static const VMStateDescription vmstate_acpi_ged = { > > &vmstate_memhp_state, > > &vmstate_cpuhp_state, > > &vmstate_ghes_state, > > + &vmstate_hest_state, > > NULL > > } > > }; > Thanks, Mauro