From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4805229C61; Sun, 24 Nov 2024 13:47:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732456072; cv=none; b=qHV7s4seGzFpDsQ0Rk2dJUJFO+2nnxWOzWO7oL8NK4Z/zBQI5YsZXuqxf/R+X0YAO5Ijrb7gaKHMJH+EOMYDif0+qyTeI5ZUdN7frPbrzpSARQHwNHFPjhQNp3XeGSJBf/x1hO21lAXA8fGWnVeHoLb5hh+O2915ezDQPScmO4g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732456072; c=relaxed/simple; bh=rJkcQimjp1uU4jhz0XfPNPy2BjS79UgvD7VZN3ivLsQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ZkqRtYrsQYEg2ySSvWNVQioZ3l7B7Xxf3ycq9bkflz0iyrPY4RM2M8qbNqOD+aHNLbuf80xCrZkTQi3KFa20BC6DJzVRB19EqecgAXdiDVPHfa43Pm1jsxUemItQGCx+bN5DaGgUn7yLbq1Di+H8vGWdC9TXA8oytbZ91nZu0r8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mVGf6u5h; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mVGf6u5h" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 440C0C4CED1; Sun, 24 Nov 2024 13:47:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1732456072; bh=rJkcQimjp1uU4jhz0XfPNPy2BjS79UgvD7VZN3ivLsQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mVGf6u5hf+ENdGh04KL32ennhTkXZQfwnUvTNaXuR01Ahe80q/uZyTBDLdzl48tBB HXOjwE1BnuNUpM8KF5m0UJC7k+Bb1Sw17VyBuxQn2dWrISqw2+TQITt0Sw+aUKyn82 oEX9xveDUXv9XBPD6hDsgHN4vulglemIZzDKxRXkXjcoDI1U8fIHdOKwD5T2XWCzeT /gfCb5rv0qS6fPM0t+vHE03WAvnLcoORaUzU1MiSHHpDjdA44kEm9SVSAhxk7cUHLe Tg0JE/PAf3Hv7WeF3OpP8vXImFi+/Pi+sO074cD8xsEu4t+FjqwacpMq0jHK3djVkR uts9kqnJZ1AGQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Philipp Stanner , =?UTF-8?q?Christian=20K=C3=B6nig?= , Sasha Levin , ltuikov89@gmail.com, matthew.brost@intel.com, dakr@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 6.6 32/61] drm/sched: memset() 'job' in drm_sched_job_init() Date: Sun, 24 Nov 2024 08:45:07 -0500 Message-ID: <20241124134637.3346391-32-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241124134637.3346391-1-sashal@kernel.org> References: <20241124134637.3346391-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.6.63 Content-Transfer-Encoding: 8bit From: Philipp Stanner [ Upstream commit 2320c9e6a768d135c7b0039995182bb1a4e4fd22 ] drm_sched_job_init() has no control over how users allocate struct drm_sched_job. Unfortunately, the function can also not set some struct members such as job->sched. This could theoretically lead to UB by users dereferencing the struct's pointer members too early. It is easier to debug such issues if these pointers are initialized to NULL, so dereferencing them causes a NULL pointer exception. Accordingly, drm_sched_entity_init() does precisely that and initializes its struct with memset(). Initialize parameter "job" to 0 in drm_sched_job_init(). Signed-off-by: Philipp Stanner Link: https://patchwork.freedesktop.org/patch/msgid/20241021105028.19794-2-pstanner@redhat.com Reviewed-by: Christian König Signed-off-by: Sasha Levin --- drivers/gpu/drm/scheduler/sched_main.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c index 5a3a622fc672f..fa4652f234718 100644 --- a/drivers/gpu/drm/scheduler/sched_main.c +++ b/drivers/gpu/drm/scheduler/sched_main.c @@ -635,6 +635,14 @@ int drm_sched_job_init(struct drm_sched_job *job, if (!entity->rq) return -ENOENT; + /* + * We don't know for sure how the user has allocated. Thus, zero the + * struct so that unallowed (i.e., too early) usage of pointers that + * this function does not set is guaranteed to lead to a NULL pointer + * exception instead of UB. + */ + memset(job, 0, sizeof(*job)); + job->entity = entity; job->s_fence = drm_sched_fence_alloc(entity, owner); if (!job->s_fence) -- 2.43.0