From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F8D21426C for ; Mon, 25 Nov 2024 07:21:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732519267; cv=none; b=LQ30THbqvYrjz52CE0TJO9NmP+K7APcJNGLi8hWPzLoONeZYeBSM7ScdxczwjsoP7yL6HuUvGoYDg6KX3XOS9BRZwgBEQHzKvDOEnx++g+Ms86M5/2gRAoVMQmbApWL0Zwcpme1DTaVznRrLi6T8u3I8zgLUE9aAKbr25KX5Mqw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732519267; c=relaxed/simple; bh=seZyflu5YWqQdBqtU0nZgLLeQ5E46QJFp+G2G/mZaqQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RkbNK5gG9yxwpBV3LfDCjmkpnYgnCu7XTmnHSdmM0q3unyrp2djua2+ew/oZPKcEdvVTm0tT0g+OoJFXndb+HA+68VRV8BF9WwEAORyhoO3rSgIyOSMryILl3PVWJAaKPvpEXWAjV1MqIB+F5RR7i+VKDMk4TMxTGih8IMllR+k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id A379D68D09; Mon, 25 Nov 2024 08:21:02 +0100 (CET) Date: Mon, 25 Nov 2024 08:21:02 +0100 From: Christoph Hellwig To: "brookxu.cn" Cc: kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] nvme-rdma: unquiesce admin_q before destroy it Message-ID: <20241125072102.GA15647@lst.de> References: <9379940137a8dfddb451917c1d069eebaf3c209e.1732368538.git.chunguang.xu@shopee.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9379940137a8dfddb451917c1d069eebaf3c209e.1732368538.git.chunguang.xu@shopee.com> User-Agent: Mutt/1.5.17 (2007-11-01) On Sat, Nov 23, 2024 at 09:37:37PM +0800, brookxu.cn wrote: > This due to we have quiesced admi_q before cancel requests, but forgot > to unquiesce before destroy it, as a result we fail to drain the > pending requests, and hang on blk_mq_freeze_queue_wait() forever. Here > try to reuse nvme_rdma_teardown_admin_queue() to fix this issue and > simplify the code. Looks good, and matches what the TCP driver is doing: Reviewed-by: Christoph Hellwig