From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C542143722 for ; Mon, 25 Nov 2024 07:24:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732519444; cv=none; b=XZgumQR19IeMwRz3rj0/fehYL04Ed1im0aLGBIWeLLFrKxoqUZxgSPdZ31mQZX0spU7npEGi+aPUuflGnw/VGDpOK64iyqu6QrIT1J5j12PDGGLIkNg19h6zJ1muvyDFmUi7qImq3diVTSh2sVrY8zfN3u7LP5eX56Axs7sMzJE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732519444; c=relaxed/simple; bh=SWwmgaez+aHwgSkIkthaMB8Bljq3RCA6VG+IJh9VT2A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GgG5fiKZcAYwL5+8p+5obXeY0iSGBP+ScQ8sN3zJjVJwbTLTX2AyUuO6rqm7z6zrqkE9WDXvhaAOFuFDIrOqtkEtK9LRaawcuPHQA27h4UcnkSSaFFLun8PH6UgcOYb97vf5zQFaB+DGRvVKRx+l/sB2DxX8ZOlpS8xrYo+x4lc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 54DF668D09; Mon, 25 Nov 2024 08:24:00 +0100 (CET) Date: Mon, 25 Nov 2024 08:24:00 +0100 From: Christoph Hellwig To: "brookxu.cn" Cc: kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/5] nvme-tcp: remove nvme_tcp_destroy_io_queues() Message-ID: <20241125072400.GD15647@lst.de> References: <5afd7d60a07afc6f299aba8c31fe87e00484da5b.1732368538.git.chunguang.xu@shopee.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5afd7d60a07afc6f299aba8c31fe87e00484da5b.1732368538.git.chunguang.xu@shopee.com> User-Agent: Mutt/1.5.17 (2007-11-01) On Sat, Nov 23, 2024 at 09:37:40PM +0800, brookxu.cn wrote: > From: "Chunguang.xu" > > Now maybe we can remove nvme_tcp_destroy_io_queues() to simplify > the code and avoid unnecessary call of nvme_tcp_stop_io_queues(). Please split the behavior change from the cleanup, and explain why the behavior change is fine and desirable.