From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDE5413CFA6 for ; Mon, 25 Nov 2024 07:25:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732519538; cv=none; b=G2zgIq2VWv6ilIJzlvnP/RTQvyLTadsAJiLnRw+ZcFiH7tewEEeJupm4w9g5ELqvHatAapMlZaIMtL/BRA0WS1Y4EKjYsOaYCgWPZI5noxjI+FmT1WO7rrNKTd5ckbEXKG9Tv/IuKVVtCpb3nuKMh/hh/dqSH+Y6GbiuF6ZFSxY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732519538; c=relaxed/simple; bh=Pd+fkVGZdQrBOzXnoN6rUMnnNDd4xDgZ4UKgI4hoKpU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZxbpTQgf7kWH0FO7Is5eS87C+hGU08+GTnSjZ273ffaz18OCzus3wNU2t1YfMfK34B+8vqtazYXN3fngQYdS33317C+MglCSCFZ0KVasbTveer6BtLLVdc9S/0fQ4c6VkES3QMJ08wxAU323gRNEDfMV1tIYGZCDRtuv7pPsyeo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id EB0B968D09; Mon, 25 Nov 2024 08:25:33 +0100 (CET) Date: Mon, 25 Nov 2024 08:25:33 +0100 From: Christoph Hellwig To: "brookxu.cn" Cc: kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/5] nvme-tcp: fix the memleak while create new ctrl failed Message-ID: <20241125072533.GE15647@lst.de> References: <55fc0f971eccc72b7ff2b2ce176a7faa8828e487.1732368538.git.chunguang.xu@shopee.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55fc0f971eccc72b7ff2b2ce176a7faa8828e487.1732368538.git.chunguang.xu@shopee.com> User-Agent: Mutt/1.5.17 (2007-11-01) On Sat, Nov 23, 2024 at 09:37:41PM +0800, brookxu.cn wrote: > From: "Chunguang.xu" > > Now while we create new ctrl failed, we have not free the > tagset occupied by admin_q, here try to fix it. Looks good: Reviewed-by: Christoph Hellwig but please add a Fixes tag and move it to the beginning of the series.