From: Christian Brauner <brauner@kernel.org>
To: shao.mingyin@zte.com.cn
Cc: Christian Brauner <brauner@kernel.org>,
yang.yang29@zte.com.cn, yang.tao172@zte.com.cn,
xu.xin16@zte.com.cn, lu.zhongjun@zte.com.cn,
chen.lin5@zte.com.cn, viro@zeniv.linux.org.uk, jack@suse.cz,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] boot: flush delayed work
Date: Wed, 27 Nov 2024 11:51:51 +0100 [thread overview]
Message-ID: <20241127-flohmarkt-beispiel-718586524de1@brauner> (raw)
In-Reply-To: <20241023135850067m3w2R0UXESiVCYz_wdAoT@zte.com.cn>
On Wed, 23 Oct 2024 13:58:50 +0800, shao.mingyin@zte.com.cn wrote:
> We find a bug that the rcS file may not be executed, resulting in module
> and business not being loaded. When trying to execute rcS, the fput()
> related to rcS has not done to complete, so deny_write_access() returns
> ETXTBSY.
>
> rcS is opened in do_populate_rootfs before executed.
> After flush_delayed_fput() has done to complete, do_populate_rootfs
> assumes that all fput() related to do_populate_rootfs has done to complete.
> However, flush_delayed_fput can only ensure that the fput() on current
> delayed_fput_list has done to complete, the fput() that has already been
> removed from delayed_fput_list in advance may not be completed. Attempting
> to execute the file associated with this fput() now will result in ETXTBSY.
> Most of the time, the fput() related to rcS has done to complete in
> do_populate_rootfs before executing rcS, but sometimes it's not.
>
> [...]
Commit message rewritten by me.
---
Applied to the vfs-6.14.misc branch of the vfs/vfs.git tree.
Patches in the vfs-6.14.misc branch should appear in linux-next soon.
Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.
It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.
Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs-6.14.misc
[1/1] fs: fix bug that fput() may not have done to complete in flush_delayed_fput
https://git.kernel.org/vfs/vfs/c/c0ef70cf7a91
prev parent reply other threads:[~2024-11-27 10:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-23 5:58 [PATCH] fs: fix bug that fput() may not have done to complete in flush_delayed_fput shao.mingyin
2024-11-27 10:51 ` Christian Brauner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241127-flohmarkt-beispiel-718586524de1@brauner \
--to=brauner@kernel.org \
--cc=chen.lin5@zte.com.cn \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lu.zhongjun@zte.com.cn \
--cc=shao.mingyin@zte.com.cn \
--cc=viro@zeniv.linux.org.uk \
--cc=xu.xin16@zte.com.cn \
--cc=yang.tao172@zte.com.cn \
--cc=yang.yang29@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®