From: Pin-yen Lin <treapking@chromium.org>
To: Francesco Dolcini <francesco@dolcini.it>, Kalle Valo <kvalo@kernel.org>
Cc: David Lin <yu-hao.lin@nxp.com>,
Pin-yen Lin <treapking@chromium.org>,
Doug Anderson <dianders@chromium.org>,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: [PATCH] wifi: mwifiex: decrease timeout waiting for host sleep from 10s to 5s
Date: Wed, 27 Nov 2024 18:55:43 +0800 [thread overview]
Message-ID: <20241127105709.4014302-1-treapking@chromium.org> (raw)
In commit 52250cbee7f6 ("mwifiex: use timeout variant for
wait_event_interruptible") it was noted that sometimes we seemed
to miss the signal that our host sleep settings took effect. A
10 second timeout was added to the code to make sure we didn't
hang forever waiting. It appears that this problem still exists
and we hit the timeout sometimes for Chromebooks in the field.
Recently on ChromeOS we've started setting the DPM watchdog
to trip if full system suspend takes over 10 seconds. Given
the timeout in the original patch, obviously we're hitting
the DPM watchdog before mwifiex gets a chance to timeout.
While we could increase the DPM watchdog in ChromeOS to avoid
this problem, it's probably better to simply decrease the
timeout. Any time we're waiting several seconds for the
firmware to respond it's likely that the firmware won't ever
respond. With that in mind, decrease the timeout in mwifiex
from 10 seconds to 5 seconds.
Suggested-by: Doug Anderson <dianders@chromium.org>
Signed-off-by: Pin-yen Lin <treapking@chromium.org>
---
drivers/net/wireless/marvell/mwifiex/sta_ioctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/marvell/mwifiex/sta_ioctl.c b/drivers/net/wireless/marvell/mwifiex/sta_ioctl.c
index e06a0622973e..f79589cafe57 100644
--- a/drivers/net/wireless/marvell/mwifiex/sta_ioctl.c
+++ b/drivers/net/wireless/marvell/mwifiex/sta_ioctl.c
@@ -545,7 +545,7 @@ int mwifiex_enable_hs(struct mwifiex_adapter *adapter)
if (wait_event_interruptible_timeout(adapter->hs_activate_wait_q,
adapter->hs_activate_wait_q_woken,
- (10 * HZ)) <= 0) {
+ (5 * HZ)) <= 0) {
mwifiex_dbg(adapter, ERROR,
"hs_activate_wait_q terminated\n");
return false;
--
2.47.0.338.g60cca15819-goog
next reply other threads:[~2024-11-27 10:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-27 10:55 Pin-yen Lin [this message]
2024-11-27 15:44 ` Doug Anderson
2024-12-03 23:04 ` Brian Norris
2024-12-04 1:38 ` Doug Anderson
2024-12-04 2:04 ` Brian Norris
2024-12-04 13:45 ` Pin-yen Lin
2024-12-04 18:11 ` Doug Anderson
2024-12-05 13:46 ` Pin-yen Lin
2024-12-05 17:13 ` Doug Anderson
2024-12-06 11:21 ` Pin-yen Lin
2024-12-06 16:09 ` Doug Anderson
2024-12-04 19:26 ` Brian Norris
2024-12-04 17:56 ` Doug Anderson
2024-12-09 15:59 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241127105709.4014302-1-treapking@chromium.org \
--to=treapking@chromium.org \
--cc=dianders@chromium.org \
--cc=francesco@dolcini.it \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=yu-hao.lin@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®