From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 101111C2DA1 for ; Thu, 28 Nov 2024 20:54:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732827262; cv=none; b=tcTBKYkRvsAsAYPGt6prm3yVtny/V71DF3ynP/Wrk3EpUU8K7bjAjFXMVgSjxUOdBiazrglq0NDVc3fA+s8HyBN57RIdLBC4G1DRVn1MKX6/HYYydkmzd2O2lbE2XhF/ImvrjduONsgdo2oJjPvwFATYSelBvq0cjW5cZ/EZGgg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732827262; c=relaxed/simple; bh=FHu7xsPNIFx5yEIyoPkkng/BvphDpd2Y2mvhSZv97MM=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=Mc4uIw1y7QFi7Ad3DaVkw3d4HF3C78m2IYvezpK1zCqHal/YdjvVUMQLS1PZufK6ZwYTPBPEuOcthAQJLIvVoB2m7jarXKQP9aRnNh0f9gO9pz1RxXFJnJZDE9ZG+LDy7cDmKhN7fxjott7MpzRb5gXVE9p6g9gigczujkxkCIU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=K3jI/5hp; arc=none smtp.client-ip=209.85.160.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="K3jI/5hp" Received: by mail-qt1-f172.google.com with SMTP id d75a77b69052e-4668f208f10so8186371cf.3 for ; Thu, 28 Nov 2024 12:54:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1732827257; x=1733432057; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=R1xCF7LNbFLYTpKldHQ+hspxekaIZZtHO9TlcY3bVcA=; b=K3jI/5hpU0eBHytKNPRLKOIQEYQDHAkJXq8JoWQrRuYhc0ou3265l50EveClD8Rkuu 9uQnvu8TY3qEArqzn/BzHOEa404vJQG0JpTGIY0byHghb+DfUqnqexydybySPls5MTpX eJP+bm6j5l7GRyiOt2wqzveArGeUvkPHaIExc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732827257; x=1733432057; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=R1xCF7LNbFLYTpKldHQ+hspxekaIZZtHO9TlcY3bVcA=; b=HcEuHWy++y5LLV3DfqQikhqwPRsV84mPpOIg5wRks5v/1+AJxzlTlUzfNeSPQqWjAT JraGfWraEZoBXzWAQTvelipC+oic0/vJu/FgdgIiAGf68vpd5l/MVWP6af7qJECXFxH0 qcexV2bQZV18rrFaIzXXreDXYfQ9LAVAnboN88utJ8AUrIyksyU6W8BrEt5PSUe7ooFc 6csYQMtuoVN1ikSl3rP2TdDc2lfiRAP3Oj4bLxjyR4SES7HZ0Wqjt9xzP+FR2OgRZvJ9 bn+Ehyl47pBOAGfxdjBufMAEfjnKJ6M632ctDgcNgsX6ju6WcxxSoTFjU0ZCTmrqgSjQ 9GCw== X-Forwarded-Encrypted: i=1; AJvYcCVHN/GeQNfqhj/EGdxl8x997bmEWxAjswrW8pEuDzmwQzIqNp8EfbOMT440PhnZAvTW4BEyz4vmi6j7gyo=@vger.kernel.org X-Gm-Message-State: AOJu0YyNfuC5RK6CWNCEHS6qaLY0HapSKF+wpq14Xf/W69mVY0Ctuz2k newcIjRl+JQ+w+v+0+f86eYFSmckk1f2oXNdA0D1tF2zhN1EOXJFPrP1ICiaCmxLTbzhaYm3jC0 = X-Gm-Gg: ASbGncsYiEpWswOtmNVDWk34aednf6ho7I6y1TrqNUoJxcCAjGOso+7k7K03xetVmWA hetvfa4m4I8ZTZqHthC5a0GIQaqAgok4gpRZjWAJ1tU+PpYuy1ruzYcY4rxj2KI2cQ8gw9E69RC 617DSuS12hkWkcgXssYHviFW5JkwSuyqWVjo2T7hqTT5ZkFL9+Q8IpEB2O28bnO2ba4Cmg33sox 2LXOpjcH5pBf8U6RXwYMRYPpwRNyKpxUHNvKgxZLlwIXMDkMxrXVk5iPr1wxfnoNeEIDVoh27BY +4DsbN95FRryAClNQTsXUep7 X-Google-Smtp-Source: AGHT+IHRpN6NATAmbciIyy05yWURRecQ9xopikH3OnMGV1553UEz0YTGxwbOrQhhCSSQmgCEPnswmQ== X-Received: by 2002:a05:622a:180e:b0:466:a308:292c with SMTP id d75a77b69052e-466b359e2cbmr127726571cf.32.1732827257019; Thu, 28 Nov 2024 12:54:17 -0800 (PST) Received: from denia.c.googlers.com (5.236.236.35.bc.googleusercontent.com. [35.236.236.5]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-466c407e6acsm9923421cf.52.2024.11.28.12.54.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Nov 2024 12:54:15 -0800 (PST) From: Ricardo Ribalda Subject: [PATCH v5 0/2] media: uvcvideo: Support partial control reads and minor changes Date: Thu, 28 Nov 2024 20:53:40 +0000 Message-Id: <20241128-uvc-readless-v5-0-cf16ed282af8@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAFTYSGcC/33NQQrCMBCF4atI1kYmyVRbV95DXKSZqQ2olUSDI r27aTdKqS7fwPfPS0QOnqPYLl4icPLRd5c8iuVCuNZejiw95S00aFQApbwnJwNbOnGMUpumqkt nCWojMrkGbvxjzO0Pebc+3rrwHOtJDdcfoaQkSEBtHRalahB3rg3d2d/Pqy4cxdBK+p/Xo6eKC mWZi/WMNx+v1NSb7KnaOGUNlEgw4/HLa5h4zB7XG001N4Zw+r/v+zfYVY0OawEAAA== To: Laurent Pinchart , Hans de Goede , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Ricardo Ribalda , Sakari Ailus , stable@vger.kernel.org X-Mailer: b4 0.13.0 Some cameras do not return all the bytes requested from a control if it can fit in less bytes. Eg: returning 0xab instead of 0x00ab. Support these devices. Also, now that we are at it, improve uvc_query_ctrl() logging. Signed-off-by: Ricardo Ribalda --- Changes in v5: - Improve comment. - Link to v4: https://lore.kernel.org/r/20241120-uvc-readless-v4-0-4672dbef3d46@chromium.org Changes in v4: - Improve comment. - Keep old likely(ret == size) - Link to v3: https://lore.kernel.org/r/20241118-uvc-readless-v3-0-d97c1a3084d0@chromium.org Changes in v3: - Improve documentation. - Do not change return sequence. - Use dev_ratelimit and dev_warn_once - Link to v2: https://lore.kernel.org/r/20241008-uvc-readless-v2-0-04d9d51aee56@chromium.org Changes in v2: - Rewrite error handling (Thanks Sakari) - Discard 2/3. It is not needed after rewriting the error handling. - Link to v1: https://lore.kernel.org/r/20241008-uvc-readless-v1-0-042ac4581f44@chromium.org --- Ricardo Ribalda (2): media: uvcvideo: Support partial control reads media: uvcvideo: Add more logging to uvc_query_ctrl() drivers/media/usb/uvc/uvc_video.c | 27 ++++++++++++++++++++++++++- 1 file changed, 26 insertions(+), 1 deletion(-) --- base-commit: 9852d85ec9d492ebef56dc5f229416c925758edc change-id: 20241008-uvc-readless-23f9b8cad0b3 Best regards, -- Ricardo Ribalda