From: Josh Poimboeuf <jpoimboe@kernel.org>
To: Tiezhu Yang <yangtiezhu@loongson.cn>
Cc: Huacai Chen <chenhuacai@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
loongarch@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 06/10] objtool: Handle unsorted table offset of rodata
Date: Wed, 27 Nov 2024 16:16:27 -0800 [thread overview]
Message-ID: <20241128001627.5czdlst5rd76qwsd@jpoimboe> (raw)
In-Reply-To: <20241128001011.sjedpn2zhrhy6y6i@jpoimboe>
On Wed, Nov 27, 2024 at 04:10:18PM -0800, Josh Poimboeuf wrote:
> On Wed, Nov 27, 2024 at 03:01:33PM +0800, Tiezhu Yang wrote:
> >
> >
> > On 11/27/2024 09:20 AM, Josh Poimboeuf wrote:
> > > On Tue, Nov 26, 2024 at 09:28:19PM +0800, Tiezhu Yang wrote:
> > > > > + /* Handle the special cases compiled with Clang on LoongArch */
> > > > > + if (file->elf->ehdr.e_machine == EM_LOONGARCH &&
> > > > > + reloc->sym->type == STT_SECTION && reloc != table &&
> > > > > + reloc_offset(reloc) == reloc_offset(table) + rodata_table_size)
> > > > > + break;
> > > >
> > > > I think it can be generic, like this:
> > > >
> > > > /* Check for the end of the table: */
> > > > if (reloc != table && reloc == next_table)
> > > > break;
> > > >
> > > > if (reloc != table &&
> > > > reloc_offset(reloc) == reloc_offset(table) +
> > > > rodata_table_size)
> > > > break;
> > > >
> > > > What do you think?
> > >
> > > I'm not sure, this patch is hard to review because it uses
> > > insn->table_size which doesn't get set until the next patch.
> > >
> > > Maybe this patch should come after patches 7 & 8, or maybe they should
> > > be squashed?
> >
> > OK, I will squash the changes into patch #7.
>
> I remembered Ard already solved a similar problem when he prototyped x86
> jump table annotation. Can you pull this patch into your series:
>
> https://lore.kernel.org/20241011170847.334429-12-ardb+git@google.com
Actually, I think I'm going to merge patches 2-5 from Ard's series as
they're a nice cleanup. Let me do that and then you can base your next
version off tip/objtool/core once it gets updated with Ard's and Peter's
patches.
--
Josh
next prev parent reply other threads:[~2024-11-28 0:16 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-22 4:49 [PATCH v4 00/10] Add jump table support for objtool on LoongArch Tiezhu Yang
2024-11-22 4:49 ` [PATCH v4 01/10] objtool: Handle various symbol types of rodata Tiezhu Yang
2024-11-26 6:44 ` Josh Poimboeuf
2024-11-26 10:41 ` Tiezhu Yang
2024-11-27 0:52 ` Josh Poimboeuf
2024-11-27 6:39 ` Tiezhu Yang
2024-11-27 18:53 ` Josh Poimboeuf
2024-11-28 2:26 ` Tiezhu Yang
2024-11-22 4:49 ` [PATCH v4 02/10] objtool: Handle special cases of dead end insn Tiezhu Yang
2024-11-26 6:45 ` Josh Poimboeuf
2024-11-26 10:42 ` Tiezhu Yang
2024-11-26 14:32 ` Peter Zijlstra
2024-11-26 15:22 ` Peter Zijlstra
2024-11-27 5:45 ` Tiezhu Yang
2024-11-22 4:49 ` [PATCH v4 03/10] objtool: Handle different entry size of rodata Tiezhu Yang
2024-11-26 7:02 ` Josh Poimboeuf
2024-11-26 10:59 ` Tiezhu Yang
2024-11-26 13:22 ` Tiezhu Yang
2024-11-27 0:57 ` Josh Poimboeuf
2024-11-27 6:59 ` Tiezhu Yang
2024-11-27 0:53 ` Josh Poimboeuf
2024-11-22 4:49 ` [PATCH v4 04/10] objtool: Handle PC relative relocation type Tiezhu Yang
2024-11-26 7:19 ` Josh Poimboeuf
2024-11-26 11:00 ` Tiezhu Yang
2024-11-26 13:24 ` Tiezhu Yang
2024-11-27 0:58 ` Josh Poimboeuf
2024-11-22 4:50 ` [PATCH v4 05/10] objtool: Handle unreachable entry of rodata Tiezhu Yang
2024-11-26 7:25 ` Josh Poimboeuf
2024-11-26 11:04 ` Tiezhu Yang
2024-11-27 0:55 ` Josh Poimboeuf
2024-11-22 4:50 ` [PATCH v4 06/10] objtool: Handle unsorted table offset " Tiezhu Yang
2024-11-26 13:28 ` Tiezhu Yang
2024-11-27 1:20 ` Josh Poimboeuf
2024-11-27 7:01 ` Tiezhu Yang
2024-11-28 0:10 ` Josh Poimboeuf
2024-11-28 0:16 ` Josh Poimboeuf [this message]
2024-11-28 1:00 ` Josh Poimboeuf
2024-11-28 2:28 ` Tiezhu Yang
2024-12-02 7:42 ` Tiezhu Yang
2024-12-03 15:58 ` Peter Zijlstra
2024-11-22 4:50 ` [PATCH v4 07/10] objtool/LoongArch: Get each table size " Tiezhu Yang
2024-11-22 4:50 ` [PATCH v4 08/10] objtool/LoongArch: Add support for switch table Tiezhu Yang
2024-11-22 4:50 ` [PATCH v4 09/10] objtool/LoongArch: Add support for goto table Tiezhu Yang
2024-11-22 4:50 ` [PATCH v4 10/10] LoongArch: Enable jump table for objtool Tiezhu Yang
2024-11-24 5:33 ` [PATCH v4 00/10] Add jump table support for objtool on LoongArch Huacai Chen
2024-11-26 7:29 ` Josh Poimboeuf
2024-11-26 9:18 ` Huacai Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241128001627.5czdlst5rd76qwsd@jpoimboe \
--to=jpoimboe@kernel.org \
--cc=chenhuacai@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=peterz@infradead.org \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®