From: Tao Chen <chen.dylane@gmail.com>
To: rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com
Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
chen.dylane@gmail.com
Subject: [PATCH] tracing: Add WARN_ON_ONCE for syscall_nr check
Date: Thu, 28 Nov 2024 19:53:19 +0800 [thread overview]
Message-ID: <20241128115319.305523-1-chen.dylane@gmail.com> (raw)
Now, x86_64 kernel not support to trace syscall for ia32 syscall.
As a result, there is no any trace output when tracing a ia32 task.
Like unreg_event_syscall_enter, add a WARN_ON_ONCE judgment for
syscall_nr in perf_syscall_enter and ftrace_syscall_enter to give
some message.
#include <sys/types.h>
#include <sys/stat.h>
#include <fcntl.h>
int main(void)
{
int ret = open("tmp.txt", 0);
return 0;
}
gcc -m32 open32 open.c
echo 1 > /sys/kernel/debug/tracing/events/syscalls/sys_enter_open/enable
./open32
[ 109.214595] ------------[ cut here ]------------
[ 109.215625] WARNING: CPU: 0 PID: 170 at
kernel/trace/trace_syscalls.c:304 ftrace_syscall_enter+0x55/0x1c0
[ 109.217111] Modules linked in:
[ 109.218190] CPU: 0 UID: 0 PID: 170 Comm: open32 Not tainted
6.12.0-rc4-virtme #10]
Signed-off-by: Tao Chen <chen.dylane@gmail.com>
---
kernel/trace/trace_syscalls.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/kernel/trace/trace_syscalls.c b/kernel/trace/trace_syscalls.c
index 785733245ead..19c3335e7d84 100644
--- a/kernel/trace/trace_syscalls.c
+++ b/kernel/trace/trace_syscalls.c
@@ -300,7 +300,7 @@ static void ftrace_syscall_enter(void *data, struct pt_regs *regs, long id)
int size;
syscall_nr = trace_get_syscall_nr(current, regs);
- if (syscall_nr < 0 || syscall_nr >= NR_syscalls)
+ if (WARN_ON_ONCE(syscall_nr < 0 || syscall_nr >= NR_syscalls))
return;
/* Here we're inside tp handler's rcu_read_lock_sched (__DO_TRACE) */
@@ -339,7 +339,7 @@ static void ftrace_syscall_exit(void *data, struct pt_regs *regs, long ret)
int syscall_nr;
syscall_nr = trace_get_syscall_nr(current, regs);
- if (syscall_nr < 0 || syscall_nr >= NR_syscalls)
+ if (WARN_ON_ONCE(syscall_nr < 0 || syscall_nr >= NR_syscalls))
return;
/* Here we're inside tp handler's rcu_read_lock_sched (__DO_TRACE()) */
@@ -585,7 +585,7 @@ static void perf_syscall_enter(void *ignore, struct pt_regs *regs, long id)
int size;
syscall_nr = trace_get_syscall_nr(current, regs);
- if (syscall_nr < 0 || syscall_nr >= NR_syscalls)
+ if (WARN_ON_ONCE(syscall_nr < 0 || syscall_nr >= NR_syscalls))
return;
if (!test_bit(syscall_nr, enabled_perf_enter_syscalls))
return;
@@ -687,7 +687,7 @@ static void perf_syscall_exit(void *ignore, struct pt_regs *regs, long ret)
int size;
syscall_nr = trace_get_syscall_nr(current, regs);
- if (syscall_nr < 0 || syscall_nr >= NR_syscalls)
+ if (WARN_ON_ONCE(syscall_nr < 0 || syscall_nr >= NR_syscalls))
return;
if (!test_bit(syscall_nr, enabled_perf_exit_syscalls))
return;
--
2.43.0
next reply other threads:[~2024-11-28 11:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-28 11:53 Tao Chen [this message]
2024-11-28 12:46 ` Steven Rostedt
2024-11-28 13:15 ` Tao Chen
2024-11-28 14:27 ` Mathieu Desnoyers
2024-11-29 2:48 ` Tao Chen
2024-11-28 15:03 ` Steven Rostedt
2024-11-28 16:02 ` Mathieu Desnoyers
2024-11-28 16:52 ` Steven Rostedt
2024-11-29 2:51 ` Tao Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241128115319.305523-1-chen.dylane@gmail.com \
--to=chen.dylane@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®