From: Hillf Danton <hdanton@sina.com>
To: syzbot <syzbot+fe139f9822abd9855970@syzkaller.appspotmail.com>
Cc: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [netfs?] WARNING in netfs_retry_reads
Date: Sat, 30 Nov 2024 07:23:25 +0800 [thread overview]
Message-ID: <20241129232325.2100-1-hdanton@sina.com> (raw)
In-Reply-To: <67496cdc.050a0220.253251.00a5.GAE@google.com>
On Thu, Nov 28, 2024 at 11:27:24PM -0800, syzbot wrote:
> syzbot found the following issue on:
>
> HEAD commit: 85a2dd7d7c81 Add linux-next specific files for 20241125
> git tree: linux-next
> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=14e3a5c0580000
#syz test
--- x/fs/netfs/read_collect.c
+++ y/fs/netfs/read_collect.c
@@ -619,8 +619,7 @@ ssize_t netfs_wait_for_read(struct netfs
for (;;) {
trace_netfs_rreq(rreq, netfs_rreq_trace_wait_queue);
- prepare_to_wait(&rreq->waitq, &myself, TASK_UNINTERRUPTIBLE);
-
+ smp_mb();
subreq = list_first_entry_or_null(&stream->subrequests,
struct netfs_io_subrequest, rreq_link);
if (subreq &&
@@ -628,6 +627,7 @@ ssize_t netfs_wait_for_read(struct netfs
test_bit(NETFS_SREQ_MADE_PROGRESS, &subreq->flags)))
netfs_read_collection(rreq);
+ prepare_to_wait(&rreq->waitq, &myself, TASK_UNINTERRUPTIBLE);
if (!test_bit(NETFS_RREQ_IN_PROGRESS, &rreq->flags))
break;
--
next prev parent reply other threads:[~2024-11-29 23:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-29 7:27 syzbot
2024-11-29 18:51 ` Bjorn Helgaas
2024-11-29 22:16 ` Aleksandr Nogikh
2024-11-29 22:51 ` Bjorn Helgaas
2024-11-29 23:23 ` Hillf Danton [this message]
2024-11-29 23:23 ` syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241129232325.2100-1-hdanton@sina.com \
--to=hdanton@sina.com \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+fe139f9822abd9855970@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®