From: Nihar Chaithanya <niharchaithanya@gmail.com>
To: miklos@szeredi.hu
Cc: joannelkoong@gmail.com, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, skhan@linuxfoundation.org,
Nihar Chaithanya <niharchaithanya@gmail.com>,
syzbot+87b8e6ed25dbc41759f7@syzkaller.appspotmail.com
Subject: [PATCH] fuse: add a null-ptr check
Date: Sat, 30 Nov 2024 12:21:22 +0530 [thread overview]
Message-ID: <20241130065118.539620-1-niharchaithanya@gmail.com> (raw)
The bug KASAN: null-ptr-deref is triggered due to *val being
dereferenced when it is null in fuse_copy_do() when performing
memcpy().
Add a check in fuse_copy_one() to prevent this.
Reported-by: syzbot+87b8e6ed25dbc41759f7@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=87b8e6ed25dbc41759f7
Fixes: 3b97c3652d91 ("fuse: convert direct io to use folios")
Tested-by: syzbot+87b8e6ed25dbc41759f7@syzkaller.appspotmail.com
Signed-off-by: Nihar Chaithanya <niharchaithanya@gmail.com>
---
fs/fuse/dev.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c
index 563a0bfa0e95..9c93759ac14b 100644
--- a/fs/fuse/dev.c
+++ b/fs/fuse/dev.c
@@ -1070,6 +1070,9 @@ static int fuse_copy_pages(struct fuse_copy_state *cs, unsigned nbytes,
/* Copy a single argument in the request to/from userspace buffer */
static int fuse_copy_one(struct fuse_copy_state *cs, void *val, unsigned size)
{
+ if (!val)
+ return -EINVAL;
+
while (size) {
if (!cs->len) {
int err = fuse_copy_fill(cs);
--
2.34.1
next reply other threads:[~2024-11-30 7:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-30 6:51 Nihar Chaithanya [this message]
2024-11-30 8:22 ` Bernd Schubert
2024-12-02 20:40 ` Joanne Koong
2024-12-02 20:53 ` Bernd Schubert
2024-12-02 21:17 ` Bernd Schubert
2024-12-02 21:50 ` Bernd Schubert
2024-12-02 22:26 ` Joanne Koong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241130065118.539620-1-niharchaithanya@gmail.com \
--to=niharchaithanya@gmail.com \
--cc=joannelkoong@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=skhan@linuxfoundation.org \
--cc=syzbot+87b8e6ed25dbc41759f7@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®