From: Andrew Morton <akpm@linux-foundation.org>
To: Miaohe Lin <linmiaohe@huawei.com>
Cc: David Hildenbrand <david@redhat.com>, <nao.horiguchi@gmail.com>,
<linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm/memory-failure: fix VM_BUG_ON_PAGE(PagePoisoned(page)) when unpoison memory
Date: Sat, 30 Nov 2024 22:59:53 -0800 [thread overview]
Message-ID: <20241130225953.dbb95dbf5f6c785e931f45f7@linux-foundation.org> (raw)
In-Reply-To: <0519bf4b-49aa-6b81-a041-362a171b2a5e@huawei.com>
On Mon, 5 Aug 2024 14:25:14 +0800 Miaohe Lin <linmiaohe@huawei.com> wrote:
> >>>> Yup, this will be a good alternative. But will it be better to simply check PagePoisoned() instead?
> >>>
> >>> The memmap of offline memory sections shall not be touched, so .... don't touch it ;)
> >>>
> >>> Especially because that PagePoisoned() check is non-sensical without poisoining-during-memmap-init. You would still work with memory in offline sections.
> >>>
> >>> I think the code is even wrong in that regard: we allow for memory offlining to work with HWPoisoned pages, see __offline_isolated_pages(). Staring at unpoison_memory(), we might be putting these pages back to the buddy? Which is completely wrong.
> >>
> >> I agree with you. Thanks for detailed explanation. :)
> >> Thanks David.
> >
> > So ... I assume there will be a new patch? :)
>
> I was just back from my two-weeks holidays. ;) I will try to send a new version when possible.
Maybe I missed the v2. I'll drop this v1 patch.
next prev parent reply other threads:[~2024-12-01 6:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-12 6:42 Miaohe Lin
2024-07-12 21:09 ` Andrew Morton
2024-07-15 6:23 ` Miaohe Lin
2024-07-15 16:16 ` David Hildenbrand
2024-07-16 2:34 ` Miaohe Lin
2024-07-17 9:01 ` David Hildenbrand
2024-07-18 3:04 ` Miaohe Lin
2024-07-18 5:15 ` David Hildenbrand
2024-07-19 3:55 ` Miaohe Lin
2024-08-01 20:24 ` David Hildenbrand
2024-08-05 6:25 ` Miaohe Lin
2024-12-01 6:59 ` Andrew Morton [this message]
2024-12-02 3:32 ` Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241130225953.dbb95dbf5f6c785e931f45f7@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nao.horiguchi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®