mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mario Limonciello <mario.limonciello@amd.com>
To: "Hans de Goede" <hdegoede@redhat.com>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
	"Len Brown" <lenb@kernel.org>,
	"Maximilian Luz" <luzmaximilian@gmail.com>,
	"Lee Chun-Yi" <jlee@suse.com>,
	"Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>,
	"Corentin Chary" <corentin.chary@gmail.com>,
	"Luke D . Jones" <luke@ljones.dev>,
	"Ike Panhc" <ike.pan@canonical.com>,
	"Henrique de Moraes Holschuh" <hmh@hmh.eng.br>,
	"Alexis Belmonte" <alexbelm48@gmail.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Ai Chao" <aichao@kylinos.cn>, "Gergo Koteles" <soyer@irl.hu>,
	"open list" <linux-kernel@vger.kernel.org>,
	"open list:ACPI" <linux-acpi@vger.kernel.org>,
	"open list:MICROSOFT SURFACE PLATFORM PROFILE DRIVER"
	<platform-driver-x86@vger.kernel.org>,
	"open list:THINKPAD ACPI EXTRAS DRIVER"
	<ibm-acpi-devel@lists.sourceforge.net>,
	"Mark Pearson" <mpearson-lenovo@squebb.ca>,
	"Matthew Schwartz" <matthew.schwartz@linux.dev>,
	"Mario Limonciello" <mario.limonciello@amd.com>,
	"Armin Wolf" <W_Armin@gmx.de>
Subject: [PATCH v9 15/22] ACPI: platform_profile: Only show profiles common for all handlers
Date: Sun, 1 Dec 2024 23:50:24 -0600	[thread overview]
Message-ID: <20241202055031.8038-16-mario.limonciello@amd.com> (raw)
In-Reply-To: <20241202055031.8038-1-mario.limonciello@amd.com>

If multiple platform profile handlers have been registered, don't allow
switching to profiles unique to only one handler.

Reviewed-by: Armin Wolf <W_Armin@gmx.de>
Tested-by: Mark Pearson <mpearson-lenovo@squebb.ca>
Tested-by: Matthew Schwartz <matthew.schwartz@linux.dev>
Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
 drivers/acpi/platform_profile.c | 52 ++++++++++++++++++++++++++-------
 1 file changed, 42 insertions(+), 10 deletions(-)

diff --git a/drivers/acpi/platform_profile.c b/drivers/acpi/platform_profile.c
index bb0178e52ff6b..40826876006b5 100644
--- a/drivers/acpi/platform_profile.c
+++ b/drivers/acpi/platform_profile.c
@@ -195,22 +195,54 @@ static const struct class platform_profile_class = {
 	.dev_groups = profile_groups,
 };
 
+/**
+ * _aggregate_choices - Aggregate the available profile choices
+ * @dev: The device
+ * @data: The available profile choices
+ * Return: 0 on success, -errno on failure
+ */
+static int _aggregate_choices(struct device *dev, void *data)
+{
+	struct platform_profile_handler *handler;
+	unsigned long *aggregate = data;
+
+	lockdep_assert_held(&profile_lock);
+	handler = dev_get_drvdata(dev);
+	if (test_bit(PLATFORM_PROFILE_LAST, aggregate))
+		bitmap_copy(aggregate, handler->choices, PLATFORM_PROFILE_LAST);
+	else
+		bitmap_and(aggregate, handler->choices, aggregate, PLATFORM_PROFILE_LAST);
+
+	return 0;
+}
+
+/**
+ * platform_profile_choices_show - Show the available profile choices for legacy sysfs interface
+ * @dev: The device
+ * @attr: The attribute
+ * @buf: The buffer to write to
+ * Return: The number of bytes written
+ */
 static ssize_t platform_profile_choices_show(struct device *dev,
-					struct device_attribute *attr,
-					char *buf)
+					     struct device_attribute *attr,
+					     char *buf)
 {
-	int len = 0;
-	int i;
+	unsigned long aggregate[BITS_TO_LONGS(PLATFORM_PROFILE_LAST)];
+	int err;
 
+	set_bit(PLATFORM_PROFILE_LAST, aggregate);
 	scoped_cond_guard(mutex_intr, return -ERESTARTSYS, &profile_lock) {
-		if (!cur_profile)
-			return -ENODEV;
-		for_each_set_bit(i, cur_profile->choices, PLATFORM_PROFILE_LAST)
-			len += sysfs_emit_at(buf, len, len ? " %s": "%s", profile_names[i]);
+		err = class_for_each_device(&platform_profile_class, NULL,
+					    aggregate, _aggregate_choices);
+		if (err)
+			return err;
 	}
-	len += sysfs_emit_at(buf, len, "\n");
 
-	return len;
+	/* no profile handler registered any more */
+	if (bitmap_empty(aggregate, PLATFORM_PROFILE_LAST))
+		return -EINVAL;
+
+	return _commmon_choices_show(aggregate, buf);
 }
 
 static ssize_t platform_profile_show(struct device *dev,
-- 
2.43.0


  parent reply	other threads:[~2024-12-02  5:51 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-02  5:50 [PATCH v9 00/22] Add support for binding ACPI platform profile to multiple drivers Mario Limonciello
2024-12-02  5:50 ` [PATCH v9 01/22] ACPI: platform-profile: Add a name member to handlers Mario Limonciello
2024-12-02  5:50 ` [PATCH v9 02/22] platform/x86/dell: dell-pc: Create platform device Mario Limonciello
2024-12-02  5:50 ` [PATCH v9 03/22] ACPI: platform_profile: Add device pointer into platform profile handler Mario Limonciello
2024-12-02  5:50 ` [PATCH v9 04/22] ACPI: platform_profile: Add platform handler argument to platform_profile_remove() Mario Limonciello
2024-12-02  5:50 ` [PATCH v9 05/22] ACPI: platform_profile: Pass the profile handler into platform_profile_notify() Mario Limonciello
2024-12-02  5:50 ` [PATCH v9 06/22] ACPI: platform_profile: Move sanity check out of the mutex Mario Limonciello
2024-12-02  5:50 ` [PATCH v9 07/22] ACPI: platform_profile: Move matching string for new profile out of mutex Mario Limonciello
2024-12-02  5:50 ` [PATCH v9 08/22] ACPI: platform_profile: Use guard(mutex) for register/unregister Mario Limonciello
2024-12-02  5:50 ` [PATCH v9 09/22] ACPI: platform_profile: Use `scoped_cond_guard` Mario Limonciello
2024-12-02  5:50 ` [PATCH v9 10/22] ACPI: platform_profile: Create class for ACPI platform profile Mario Limonciello
2024-12-04 13:41   ` Ilpo Järvinen
2024-12-02  5:50 ` [PATCH v9 11/22] ACPI: platform_profile: Add name attribute to class interface Mario Limonciello
2024-12-02  5:50 ` [PATCH v9 12/22] ACPI: platform_profile: Add choices attribute for " Mario Limonciello
2024-12-02  5:50 ` [PATCH v9 13/22] ACPI: platform_profile: Add profile " Mario Limonciello
2024-12-05 11:40   ` Ilpo Järvinen
2024-12-02  5:50 ` [PATCH v9 14/22] ACPI: platform_profile: Notify change events on register and unregister Mario Limonciello
2024-12-02  5:50 ` Mario Limonciello [this message]
2024-12-05 11:47   ` [PATCH v9 15/22] ACPI: platform_profile: Only show profiles common for all handlers Ilpo Järvinen
2024-12-02  5:50 ` [PATCH v9 16/22] ACPI: platform_profile: Add concept of a "custom" profile Mario Limonciello
2024-12-05 11:50   ` Ilpo Järvinen
2024-12-02  5:50 ` [PATCH v9 17/22] ACPI: platform_profile: Make sure all profile handlers agree on profile Mario Limonciello
2024-12-05 12:07   ` Ilpo Järvinen
2024-12-02  5:50 ` [PATCH v9 18/22] ACPI: platform_profile: Check all profile handler to calculate next Mario Limonciello
2024-12-05 14:22   ` Ilpo Järvinen
2024-12-05 14:46     ` Mario Limonciello
2024-12-05 15:22       ` Ilpo Järvinen
2024-12-05 15:35         ` Mario Limonciello
2024-12-02  5:50 ` [PATCH v9 19/22] ACPI: platform_profile: Notify class device from platform_profile_notify() Mario Limonciello
2024-12-05 14:24   ` Ilpo Järvinen
2024-12-02  5:50 ` [PATCH v9 20/22] ACPI: platform_profile: Allow multiple handlers Mario Limonciello
2024-12-05 14:27   ` Ilpo Järvinen
2024-12-02  5:50 ` [PATCH v9 21/22] platform/x86/amd: pmf: Drop all quirks Mario Limonciello
2024-12-05 14:30   ` Ilpo Järvinen
2024-12-02  5:50 ` [PATCH v9 22/22] Documentation: Add documentation about class interface for platform profiles Mario Limonciello
2024-12-05 14:33   ` Ilpo Järvinen
2024-12-02 14:31 ` [PATCH v9 00/22] Add support for binding ACPI platform profile to multiple drivers Armin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241202055031.8038-16-mario.limonciello@amd.com \
    --to=mario.limonciello@amd.com \
    --cc=Shyam-sundar.S-k@amd.com \
    --cc=W_Armin@gmx.de \
    --cc=aichao@kylinos.cn \
    --cc=alexbelm48@gmail.com \
    --cc=corentin.chary@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=hmh@hmh.eng.br \
    --cc=ibm-acpi-devel@lists.sourceforge.net \
    --cc=ike.pan@canonical.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jlee@suse.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luke@ljones.dev \
    --cc=luzmaximilian@gmail.com \
    --cc=matthew.schwartz@linux.dev \
    --cc=mpearson-lenovo@squebb.ca \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=soyer@irl.hu \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®