mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Zhang Rui <rui.zhang@intel.com>
To: rafael.j.wysocki@intel.com, lenb@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: [PATCH 0/4] tools/power turbostat: Improve handling for unsupported platforms
Date: Tue,  3 Dec 2024 15:51:15 +0800	[thread overview]
Message-ID: <20241203075119.584419-1-rui.zhang@intel.com> (raw)

Hi, all,

Turbostat requires per-platform enabling for different platforms due to
platform-specific features. When running on unsupported platforms,
turbostat currently operates with limited default features, which can
lead to users unknowingly using an outdated version of the tool.

Enhance turbostat to
1. exit by default when run on unsupported X86 Vendors/Intel models.
2. give a clear message to users, informing them that their CPU model is
   not supported and advising them to update to the latest version of
   turbostat for full functionality.
3. allow force loading with minimum support on unsupported platforms by
   introducing a new '--force' parameter.

With above patches, when turbostat runs
1. on supported platforms, no functional change.
2. on unsupported X86 Vendors or unsupported Intel Models without
   '--force' parameter, turbostat exits with below message:

"Unsupported platform detected.
	Use "--force" parameter to launch turbostat with minimum default support.
	To get latest turbostat support, please contact
	   lenb@kernel.org
	or pull from
	   https://git.kernel.org/pub/scm/linux/kernel/git/lenb/linux.git turbostat"
	   
3. on unsupported X86 Vendors or unsupported Intel Models with '--force'
   parameter, turbostat continues but with below message
   
"Unsupported platform detected. Force running with minimum default support."

Any comments are welcome.

thanks,
rui

Zhang Rui (4):
  tools/power turbostat: Exit on unsupported Intel models
  tools/power turbostat: Exit on unsupported Vendors
  tools/power turbostat: Improve --help output
  tools/power turbostat: Introduce --force parameter

 tools/power/x86/turbostat/turbostat.c | 72 ++++++++++++++++++++-------
 1 file changed, 54 insertions(+), 18 deletions(-)

-- 
2.43.0


             reply	other threads:[~2024-12-03  7:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-03  7:51 Zhang Rui [this message]
2024-12-03  7:51 ` [PATCH 1/4] tools/power turbostat: Exit on unsupported Intel models Zhang Rui
2024-12-03 16:43   ` Len Brown
2024-12-03  7:51 ` [PATCH 2/4] tools/power turbostat: Exit on unsupported Vendors Zhang Rui
2024-12-03  7:51 ` [PATCH 3/4] tools/power turbostat: Improve --help output Zhang Rui
2024-12-03  7:51 ` [PATCH 4/4] tools/power turbostat: Introduce --force parameter Zhang Rui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241203075119.584419-1-rui.zhang@intel.com \
    --to=rui.zhang@intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael.j.wysocki@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®