From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43A1B1DD0FF for ; Tue, 3 Dec 2024 11:56:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733226990; cv=none; b=HNcjRZj+uNXmtR/QT8LRj66c/46OYJY7YFTbTvwumWHagwzR/Ejz3vH0tKog4vxZAJwPWwsuRcLtqRBjDIDC4Ivitamrs1wGqTXLK5V2rIaagBzaRALsNPDrDuvLdHoNnznmJ5LzxgQ/WIpFQaWXbfopdFS30KL3mmJqHSiK4+g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733226990; c=relaxed/simple; bh=z18ZVQThjRUp4dbViIda6zsLr4dfzoahaVIxd3AwPPY=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ZX6g3IOgZp2romxwDj5JR2KRN/HbfSg4ZcwOWhOrCQ71n2H8/N8PU7Ixx82A2QYiPR8T//s/qp33g7v5gM1fh3MZGd/jTm4WwqJ1AxyUHVRvMnr3gelwlfMPDuhxtEPm3Y3Jk+bLMrn+du37goYpGsWbpMRydfcjnzUDO/i6/HU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=OTlO9k+e; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="OTlO9k+e" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733226987; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+O57SI+41dnb6fLcPWqR/WRjF0vrSeymdRk0UogJ2tY=; b=OTlO9k+eUW2HipfJ+Xkr0UaygxebxfsllW8nm0W1iW0PZ8B0obdmyTSZ6HTHgigiAKo04L zB5FidkJkeT9BPod7jWhbS2tC3is2t17qQQqhAeuvbc1vJASOBrxvj24ZO2KBgfxbPw5/6 +DVPxL2nKrFeBr6SlWl+4NbDIK716sM= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-60-CPe9vROBNoOARtMyM8YzCw-1; Tue, 03 Dec 2024 06:56:26 -0500 X-MC-Unique: CPe9vROBNoOARtMyM8YzCw-1 X-Mimecast-MFC-AGG-ID: CPe9vROBNoOARtMyM8YzCw Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-434ad71268dso30090085e9.1 for ; Tue, 03 Dec 2024 03:56:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733226985; x=1733831785; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+O57SI+41dnb6fLcPWqR/WRjF0vrSeymdRk0UogJ2tY=; b=P1IpH/EbFwZ20xr/gBz2znD/wVWKml/3C9W/s4d5YUY/R77hwRn8NbtNt6E5nNbsi0 8u8FuQwTDPuHpgI2Ze04iZ0u8OLA1rVqP7dcPESbntWe+0ZHWdtM+UvF+Ay6QP9Knu2V HuB2Pfb9ZT+5rS1fEAzX7Uhli17P624+bCixjQIx0uEbkJ40z9qDG2lBOcZC7gxXGnEv 9bJxZHY7jbfFQx6JhkXLoKLC8NXQf/fqYYig6uiH16rINVfafSzc6iCARxfhg0s2R9CT 94/6k9bGTi2DjJuQ+aLNq53oeUwm7pVgLLl1flntth++cKXoCp13lzkeDNYzZjZjv6LQ 7yfw== X-Forwarded-Encrypted: i=1; AJvYcCVU0aY7SgbBjKF8A9+9kIsQmU7FBuXTJ24scSjsVN9euGYktV1IBAOpiKa0vlXnLIntNZAgnPXHZiEeZnQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzJZN6cetYOW0cPG/XyQIs2g7fq4zmAqMX6CCFH7PZ+UxCUAB7I p+/bDOLDd8YyJ7uZK7Q2yjDCumWIOslArK14k9HBQjLqLyr+Lm1pYkXP+PBoThr01K2V4HXGoEL Gs8bYA6lfUgqoGyQ01I3t0mYbJNxFXzioVYEo7iZVBZMxkJPHThe6DuCC9E/Dvg== X-Gm-Gg: ASbGncurRWtowRFHuFry5FDN6tMNcYflUqKAxP/sr9ypYIBUpJayoFF+U4+ucR6UAAQ dW0jKdkoVsAHj0mIji6Zkb/triYYlOzJ+6yWn0AvcOh4MvAU7RRv2AvQahvnjJNoFvF5jfGu/M5 xpOkBvlz/qJCLr/UGSB9jh68l/5hYR8rIYQ9n+yPLpPNSPXmhRIUaHpaBIil0m2S5eYwYkX9sox ZADPLiEqVU9ZCh/9ZPya3lrGYOgS48DiZQiOtRWn887NJbhiGsNYHdkNC9m3KXHaEaqAIygYXbr Is5CsPyoaINHl5mmvooEvA== X-Received: by 2002:a05:600c:5593:b0:434:a33d:ba44 with SMTP id 5b1f17b1804b1-434afc44167mr193433615e9.15.1733226984777; Tue, 03 Dec 2024 03:56:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IEgDggl5MAwTUpW3kCdC3q1u7zjc9Y2cOyItvruE8+s588/kDJ2UNEYXraijxQzZaWdRgVSsA== X-Received: by 2002:a05:600c:5593:b0:434:a33d:ba44 with SMTP id 5b1f17b1804b1-434afc44167mr193433395e9.15.1733226984491; Tue, 03 Dec 2024 03:56:24 -0800 (PST) Received: from imammedo.users.ipa.redhat.com (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-434b0dc6352sm186849345e9.21.2024.12.03.03.56.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Dec 2024 03:56:24 -0800 (PST) Date: Tue, 3 Dec 2024 12:56:23 +0100 From: Igor Mammedov To: Mauro Carvalho Chehab Cc: Jonathan Cameron , Shiju Jose , Dongjiu Geng , linux-kernel@vger.kernel.org, qemu-arm@nongnu.org, qemu-devel@nongnu.org Subject: Re: [PATCH v4 15/15] docs: acpi_hest_ghes: fix documentation for CPER size Message-ID: <20241203125623.3b47103e@imammedo.users.ipa.redhat.com> In-Reply-To: <3bfe6c991d187f48b9c34500be106296b9480059.1732266152.git.mchehab+huawei@kernel.org> References: <3bfe6c991d187f48b9c34500be106296b9480059.1732266152.git.mchehab+huawei@kernel.org> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 22 Nov 2024 10:11:32 +0100 Mauro Carvalho Chehab wrote: > While the spec defines a CPER size of 4KiB for each record, > currently it is set to 1KiB. Fix the documentation and add > a pointer to the macro name there, as this may help to keep > it updated. > > Signed-off-by: Mauro Carvalho Chehab > Acked-by: Igor Mammedov > Reviewed-by: Jonathan Cameron Reviewed-by: Igor Mammedov > --- > docs/specs/acpi_hest_ghes.rst | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/docs/specs/acpi_hest_ghes.rst b/docs/specs/acpi_hest_ghes.rst > index 68f1fbe0a4af..c3e9f8d9a702 100644 > --- a/docs/specs/acpi_hest_ghes.rst > +++ b/docs/specs/acpi_hest_ghes.rst > @@ -67,8 +67,10 @@ Design Details > (3) The address registers table contains N Error Block Address entries > and N Read Ack Register entries. The size for each entry is 8-byte. > The Error Status Data Block table contains N Error Status Data Block > - entries. The size for each entry is 4096(0x1000) bytes. The total size > - for the "etc/hardware_errors" fw_cfg blob is (N * 8 * 2 + N * 4096) bytes. > + entries. The size for each entry is defined at the source code as > + ACPI_GHES_MAX_RAW_DATA_LENGTH (currently 1024 bytes). The total size > + for the "etc/hardware_errors" fw_cfg blob is > + (N * 8 * 2 + N * ACPI_GHES_MAX_RAW_DATA_LENGTH) bytes. > N is the number of the kinds of hardware error sources. > > (4) QEMU generates the ACPI linker/loader script for the firmware. The