mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alexander Lobakin <aleksander.lobakin@intel.com>
To: Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	John Fastabend <john.fastabend@gmail.com>,
	Andrii Nakryiko <andrii@kernel.org>
Cc: "Alexander Lobakin" <aleksander.lobakin@intel.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Toke Høiland-Jørgensen" <toke@redhat.com>,
	"Maciej Fijalkowski" <maciej.fijalkowski@intel.com>,
	"Stanislav Fomichev" <sdf@fomichev.me>,
	"Magnus Karlsson" <magnus.karlsson@intel.com>,
	nex.sw.ncis.osdt.itp.upstreaming@intel.com, bpf@vger.kernel.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH net-next v6 05/10] xsk: allow attaching XSk pool via xdp_rxq_info_reg_mem_model()
Date: Tue,  3 Dec 2024 18:37:28 +0100	[thread overview]
Message-ID: <20241203173733.3181246-6-aleksander.lobakin@intel.com> (raw)
In-Reply-To: <20241203173733.3181246-1-aleksander.lobakin@intel.com>

When you register an XSk pool as XDP Rxq info memory model, you then
need to manually attach it after the registration.
Let the user combine both actions into one by just passing a pointer
to the pool directly to xdp_rxq_info_reg_mem_model(), which will take
care of calling xsk_pool_set_rxq_info(). This looks similar to how a
&page_pool gets registered and reduce repeating driver code.

Acked-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Reviewed-by: Toke Høiland-Jørgensen <toke@redhat.com>
Signed-off-by: Alexander Lobakin <aleksander.lobakin@intel.com>
---
 net/core/xdp.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/net/core/xdp.c b/net/core/xdp.c
index 885a2a664bce..de1e9cb78718 100644
--- a/net/core/xdp.c
+++ b/net/core/xdp.c
@@ -358,6 +358,9 @@ int xdp_rxq_info_reg_mem_model(struct xdp_rxq_info *xdp_rxq,
 	if (IS_ERR(xdp_alloc))
 		return PTR_ERR(xdp_alloc);
 
+	if (type == MEM_TYPE_XSK_BUFF_POOL && allocator)
+		xsk_pool_set_rxq_info(allocator, xdp_rxq);
+
 	if (trace_mem_connect_enabled() && xdp_alloc)
 		trace_mem_connect(xdp_alloc, xdp_rxq);
 	return 0;
-- 
2.47.0


  parent reply	other threads:[~2024-12-03 17:41 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-03 17:37 [PATCH net-next v6 00/10] xdp: a fistful of generic changes pt. I Alexander Lobakin
2024-12-03 17:37 ` [PATCH net-next v6 01/10] xsk: align &xdp_buff_xsk harder Alexander Lobakin
2024-12-04 10:27   ` Toke Høiland-Jørgensen
2024-12-03 17:37 ` [PATCH net-next v6 02/10] bpf, xdp: constify some bpf_prog * function arguments Alexander Lobakin
2024-12-03 17:37 ` [PATCH net-next v6 03/10] xdp, xsk: constify read-only arguments of some static inline helpers Alexander Lobakin
2024-12-03 17:37 ` [PATCH net-next v6 04/10] xdp: allow attaching already registered memory model to xdp_rxq_info Alexander Lobakin
2024-12-03 17:37 ` Alexander Lobakin [this message]
2024-12-03 17:37 ` [PATCH net-next v6 06/10] xdp: register system page pool as an XDP memory model Alexander Lobakin
2024-12-03 17:37 ` [PATCH net-next v6 07/10] netmem: add a couple of page helper wrappers Alexander Lobakin
2024-12-04 10:49   ` Toke Høiland-Jørgensen
2024-12-06  4:03   ` Mina Almasry
2024-12-03 17:37 ` [PATCH net-next v6 08/10] page_pool: make page_pool_put_page_bulk() handle array of netmems Alexander Lobakin
2024-12-04 10:50   ` Toke Høiland-Jørgensen
2024-12-06  4:07   ` Mina Almasry
2024-12-03 17:37 ` [PATCH net-next v6 09/10] page_pool: allow mixing PPs within one bulk Alexander Lobakin
2024-12-06  2:40   ` Jakub Kicinski
2024-12-06 13:49     ` Alexander Lobakin
2024-12-06 16:20       ` Jakub Kicinski
2024-12-03 17:37 ` [PATCH net-next v6 10/10] xdp: get rid of xdp_frame::mem.id Alexander Lobakin
2024-12-06  7:10 ` [PATCH net-next v6 00/10] xdp: a fistful of generic changes pt. I patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241203173733.3181246-6-aleksander.lobakin@intel.com \
    --to=aleksander.lobakin@intel.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=john.fastabend@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maciej.fijalkowski@intel.com \
    --cc=magnus.karlsson@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=nex.sw.ncis.osdt.itp.upstreaming@intel.com \
    --cc=pabeni@redhat.com \
    --cc=sdf@fomichev.me \
    --cc=toke@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®