From: John Garry <john.g.garry@oracle.com>
To: brauner@kernel.org, djwong@kernel.org, cem@kernel.org,
dchinner@redhat.com, hch@lst.de, ritesh.list@gmail.com
Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, martin.petersen@oracle.com,
John Garry <john.g.garry@oracle.com>
Subject: [PATCH 1/4] iomap: Lift blocksize restriction on atomic writes
Date: Wed, 4 Dec 2024 15:43:41 +0000 [thread overview]
Message-ID: <20241204154344.3034362-2-john.g.garry@oracle.com> (raw)
In-Reply-To: <20241204154344.3034362-1-john.g.garry@oracle.com>
From: "Ritesh Harjani (IBM)" <ritesh.list@gmail.com>
Filesystems like ext4 can submit writes in multiples of blocksizes.
But we still can't allow the writes to be split into multiple BIOs. Hence
let's check if the iomap_length() is same as iter->len or not.
It is the responsibility of userspace to ensure that a write does not span
mixed unwritten and mapped extents (which would lead to multiple BIOs).
Signed-off-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
jpg: tweak commit message
Signed-off-by: John Garry <john.g.garry@oracle.com>
---
fs/iomap/direct-io.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c
index b521eb15759e..3dd883dd77d2 100644
--- a/fs/iomap/direct-io.c
+++ b/fs/iomap/direct-io.c
@@ -306,7 +306,7 @@ static loff_t iomap_dio_bio_iter(const struct iomap_iter *iter,
size_t copied = 0;
size_t orig_count;
- if (atomic && length != fs_block_size)
+ if (atomic && length != iter->len)
return -EINVAL;
if ((pos | length) & (bdev_logical_block_size(iomap->bdev) - 1) ||
--
2.31.1
next prev parent reply other threads:[~2024-12-04 15:44 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 15:43 [PATCH 0/4] large atomic writes for xfs John Garry
2024-12-04 15:43 ` John Garry [this message]
2024-12-04 20:35 ` [PATCH 1/4] iomap: Lift blocksize restriction on atomic writes Dave Chinner
2024-12-05 6:30 ` Darrick J. Wong
2024-12-05 11:51 ` John Garry
2024-12-05 10:52 ` John Garry
2024-12-05 21:15 ` Dave Chinner
2024-12-06 9:43 ` John Garry
2024-12-12 1:34 ` Darrick J. Wong
2025-01-14 4:41 ` Dave Chinner
2025-01-14 23:57 ` Darrick J. Wong
2025-01-15 9:30 ` John Garry
2025-01-16 6:52 ` Christoph Hellwig
2025-01-17 18:49 ` Darrick J. Wong
2025-01-22 6:42 ` Christoph Hellwig
2025-01-22 10:45 ` John Garry
2025-01-22 23:51 ` Dave Chinner
2025-01-23 9:28 ` John Garry
2025-01-17 10:26 ` John Garry
2025-01-17 18:29 ` Darrick J. Wong
2025-01-20 8:29 ` John Garry
2025-01-22 21:05 ` Dave Chinner
2025-01-13 21:35 ` John Garry
2025-01-14 4:43 ` Dave Chinner
2024-12-04 15:43 ` [PATCH 2/4] xfs: Switch atomic write size check in xfs_file_write_iter() John Garry
2024-12-04 15:43 ` [PATCH 3/4] xfs: Add RT atomic write unit max to xfs_mount John Garry
2024-12-04 15:43 ` [PATCH 4/4] xfs: Update xfs_get_atomic_write_attr() for large atomic writes John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241204154344.3034362-2-john.g.garry@oracle.com \
--to=john.g.garry@oracle.com \
--cc=brauner@kernel.org \
--cc=cem@kernel.org \
--cc=dchinner@redhat.com \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ritesh.list@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®