mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Gabriele Monaco <gmonaco@redhat.com>,
	John Kacur <jkacur@redhat.com>,
	Luis Goncalves <lgoncalv@redhat.com>,
	Tomas Glozar <tglozar@redhat.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Sasha Levin <sashal@kernel.org>,
	bristot@kernel.org, linux-trace-kernel@vger.kernel.org
Subject: [PATCH AUTOSEL 6.11 02/33] rtla: Fix consistency in getopt_long for timerlat_hist
Date: Wed,  4 Dec 2024 10:47:15 -0500	[thread overview]
Message-ID: <20241204154817.2212455-2-sashal@kernel.org> (raw)
In-Reply-To: <20241204154817.2212455-1-sashal@kernel.org>

From: Gabriele Monaco <gmonaco@redhat.com>

[ Upstream commit cfb1ea216c1656a4112becbc4bf757891933b902 ]

Commit e9a4062e1527 ("rtla: Add --trace-buffer-size option") adds a new
long option to rtla utilities, but among all affected files,
timerlat_hist misses a trailing `:` in the corresponding short option
inside the getopt string (e.g. `\3:`). This patch propagates the `:`.

Although this change is not functionally required, it improves
consistency and slightly reduces the likelihood a future change would
introduce a problem.

Cc: John Kacur <jkacur@redhat.com>
Cc: Luis Goncalves <lgoncalv@redhat.com>
Cc: Tomas Glozar <tglozar@redhat.com>
Link: https://lore.kernel.org/20240926143417.54039-1-gmonaco@redhat.com
Signed-off-by: Gabriele Monaco <gmonaco@redhat.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 tools/tracing/rtla/src/timerlat_hist.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/tracing/rtla/src/timerlat_hist.c b/tools/tracing/rtla/src/timerlat_hist.c
index a3907c390d67a..1f9137c592f45 100644
--- a/tools/tracing/rtla/src/timerlat_hist.c
+++ b/tools/tracing/rtla/src/timerlat_hist.c
@@ -778,7 +778,7 @@ static struct timerlat_hist_params
 		/* getopt_long stores the option index here. */
 		int option_index = 0;
 
-		c = getopt_long(argc, argv, "a:c:C::b:d:e:E:DhH:i:knp:P:s:t::T:uU0123456:7:8:9\1\2:\3",
+		c = getopt_long(argc, argv, "a:c:C::b:d:e:E:DhH:i:knp:P:s:t::T:uU0123456:7:8:9\1\2:\3:",
 				 long_options, &option_index);
 
 		/* detect the end of the options. */
-- 
2.43.0


  reply	other threads:[~2024-12-04 16:59 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-04 15:47 [PATCH AUTOSEL 6.11 01/33] pinctrl: freescale: fix COMPILE_TEST error with PINCTRL_IMX_SCU Sasha Levin
2024-12-04 15:47 ` Sasha Levin [this message]
2024-12-04 15:47 ` [PATCH AUTOSEL 6.11 03/33] tracing/ftrace: disable preemption in syscall probe Sasha Levin
2024-12-04 15:47 ` [PATCH AUTOSEL 6.11 04/33] tracing: Use atomic64_inc_return() in trace_clock_counter() Sasha Levin
2024-12-04 15:47 ` [PATCH AUTOSEL 6.11 05/33] tools/rtla: fix collision with glibc sched_attr/sched_set_attr Sasha Levin
2024-12-04 15:47 ` [PATCH AUTOSEL 6.11 06/33] rtla/timerlat: Make timerlat_top_cpu->*_count unsigned long long Sasha Levin
2024-12-04 15:47 ` [PATCH AUTOSEL 6.11 07/33] rtla/timerlat: Make timerlat_hist_cpu->*_count " Sasha Levin
2024-12-04 15:47 ` [PATCH AUTOSEL 6.11 08/33] scsi: hisi_sas: Add cond_resched() for no forced preemption model Sasha Levin
2024-12-04 15:47 ` [PATCH AUTOSEL 6.11 09/33] scsi: hisi_sas: Create all dump files during debugfs initialization Sasha Levin
2024-12-04 15:47 ` [PATCH AUTOSEL 6.11 10/33] rtla/utils: Add idle state disabling via libcpupower Sasha Levin
2024-12-04 15:47 ` [PATCH AUTOSEL 6.11 11/33] ring-buffer: Limit time with disabled interrupts in rb_check_pages() Sasha Levin
2024-12-04 15:47 ` [PATCH AUTOSEL 6.11 12/33] pinmux: Use sequential access to access desc->pinmux data Sasha Levin
2024-12-04 15:47 ` [PATCH AUTOSEL 6.11 13/33] scsi: ufs: core: Make DMA mask configuration more flexible Sasha Levin
2024-12-04 15:47 ` [PATCH AUTOSEL 6.11 14/33] mfd: axp20x: Allow multiple regulators Sasha Levin
2024-12-04 15:47 ` [PATCH AUTOSEL 6.11 15/33] bpf: put bpf_link's program when link is safe to be deallocated Sasha Levin
2024-12-04 15:47 ` [PATCH AUTOSEL 6.11 16/33] scsi: lpfc: Call lpfc_sli4_queue_unset() in restart and rmmod paths Sasha Levin
2024-12-04 15:47 ` [PATCH AUTOSEL 6.11 17/33] scsi: lpfc: Check SLI_ACTIVE flag in FDMI cmpl before submitting follow up FDMI Sasha Levin
2024-12-04 15:47 ` [PATCH AUTOSEL 6.11 18/33] scsi: lpfc: Prevent NDLP reference count underflow in dev_loss_tmo callback Sasha Levin
2024-12-04 15:47 ` [PATCH AUTOSEL 6.11 19/33] clk: qcom: rcg2: add clk_rcg2_shared_floor_ops Sasha Levin
2024-12-04 15:47 ` [PATCH AUTOSEL 6.11 20/33] clk: qcom: rpmh: add support for SAR2130P Sasha Levin
2024-12-04 15:47 ` [PATCH AUTOSEL 6.11 21/33] clk: qcom: tcsrcc-sm8550: add SAR2130P support Sasha Levin
2024-12-04 15:47 ` [PATCH AUTOSEL 6.11 22/33] clk: qcom: clk-alpha-pll: Add NSS HUAYRA ALPHA PLL support for ipq9574 Sasha Levin
2024-12-04 15:47 ` [PATCH AUTOSEL 6.11 23/33] leds: class: Protect brightness_show() with led_cdev->led_access mutex Sasha Levin
2024-12-04 15:47 ` [PATCH AUTOSEL 6.11 24/33] scsi: st: Don't modify unknown block number in MTIOCGET Sasha Levin
2024-12-04 15:47 ` [PATCH AUTOSEL 6.11 25/33] scsi: st: Add MTIOCGET and MTLOAD to ioctls allowed after device reset Sasha Levin
2024-12-04 15:47 ` [PATCH AUTOSEL 6.11 26/33] pinctrl: qcom-pmic-gpio: add support for PM8937 Sasha Levin
2024-12-04 15:47 ` [PATCH AUTOSEL 6.11 27/33] pinctrl: qcom: spmi-mpp: Add PM8937 compatible Sasha Levin
2024-12-04 15:47 ` [PATCH AUTOSEL 6.11 28/33] thermal/drivers/qcom/tsens-v1: Add support for MSM8937 tsens Sasha Levin
2024-12-04 15:47 ` [PATCH AUTOSEL 6.11 29/33] nvdimm: rectify the illogical code within nd_dax_probe() Sasha Levin
2024-12-04 15:47 ` [PATCH AUTOSEL 6.11 30/33] smb: client: memcpy() with surrounding object base address Sasha Levin
2024-12-04 15:47 ` [PATCH AUTOSEL 6.11 31/33] tools/rtla: Enhance argument parsing in timerlat_load.py Sasha Levin
2024-12-04 15:47 ` [PATCH AUTOSEL 6.11 32/33] verification/dot2: Improve dot parser robustness Sasha Levin
2024-12-04 15:47 ` [PATCH AUTOSEL 6.11 33/33] mailbox: pcc: Check before sending MCTP PCC response ACK Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241204154817.2212455-2-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=bristot@kernel.org \
    --cc=gmonaco@redhat.com \
    --cc=jkacur@redhat.com \
    --cc=lgoncalv@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=stable@vger.kernel.org \
    --cc=tglozar@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®