mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Rodrigo Gobbi <rodrigo.gobbi.7@gmail.com>
Cc: philipp.g.hortmann@gmail.com, ~lkcamp/patches@lists.sr.ht,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: rtl8723bs: fix broken code when cflag is used
Date: Wed, 4 Dec 2024 16:52:55 +0100	[thread overview]
Message-ID: <2024120426-shininess-scorpion-cc26@gregkh> (raw)
In-Reply-To: <20241125225308.8702-1-rodrigo.gobbi.7@gmail.com>

On Mon, Nov 25, 2024 at 07:45:04PM -0300, Rodrigo Gobbi wrote:
> When using an extra cflag, DBG_RX_SIGNAL_DISPLAY_RAW_DATA,
> hal_com.c file doesn't compile.
> 
> Fixes: ec57f8641fbc ("staging: rtl8723bs: Rework 'struct _ODM_Phy_Status_Info_' coding style.")
> Signed-off-by: Rodrigo Gobbi <rodrigo.gobbi.7@gmail.com>
> ---
> As noticed at [1], hal_com.c is not compiling with -DDBG_RX_SIGNAL_DISPLAY_RAW_DATA due
> the changes at [2] (a few statements were not replaced with the new struct).
> A little discussion was made at [1] too about how useful this cflag was or if
> the code under the cflag should be deleted. I think there is no harm to keep those things 
> as is since we can easily fix the error and someone might be interested in using that
> to further debug the driver.

Let's just delete that flag entirely, no one builds in-kernel modules
with different cflags.  Please just remove the code completly.

thanks,

greg k-h

      reply	other threads:[~2024-12-04 15:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-25 22:45 Rodrigo Gobbi
2024-12-04 15:52 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024120426-shininess-scorpion-cc26@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=philipp.g.hortmann@gmail.com \
    --cc=rodrigo.gobbi.7@gmail.com \
    --cc=~lkcamp/patches@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®