From: Conor Dooley <conor@kernel.org>
To: daire.mcnamara@microchip.com,
Valentina Fernandez <valentina.fernandezalanis@microchip.com>
Cc: conor@kernel.org, Conor Dooley <conor.dooley@microchip.com>,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] firmware: microchip: fix UL_IAP lock check in mpfs_auto_update_state()
Date: Thu, 5 Dec 2024 15:14:45 +0000 [thread overview]
Message-ID: <20241205-rumble-engulf-7e51eeab2668@spud> (raw)
In-Reply-To: <20241118155354.697411-1-valentina.fernandezalanis@microchip.com>
From: Conor Dooley <conor.dooley@microchip.com>
On Mon, 18 Nov 2024 15:53:54 +0000, Valentina Fernandez wrote:
> To verify that Auto Update is possible, the mpfs_auto_update_state()
> function performs a "Query Security Service Request" to the system
> controller.
>
> Previously, the check was performed on the first element of the
> response message, which was accessed using a 32-bit pointer. This
> caused the bitwise operation to reference incorrect data, as the
> response should be inspected at the byte level. Fixed this by casting
> the response to a u8 * pointer, ensuring the check correctly inspects
> the appropriate byte of the response message.
>
> [...]
Applied to riscv-soc-fixes, thanks!
[1/1] firmware: microchip: fix UL_IAP lock check in mpfs_auto_update_state()
https://git.kernel.org/conor/c/48808b55b07c
Thanks,
Conor.
next prev parent reply other threads:[~2024-12-05 15:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-18 15:53 Valentina Fernandez
2024-12-05 15:14 ` Conor Dooley [this message]
2024-12-31 10:38 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241205-rumble-engulf-7e51eeab2668@spud \
--to=conor@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=daire.mcnamara@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=valentina.fernandezalanis@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®