From: Andrew Morton <akpm@linux-foundation.org>
To: Zhenhua Huang <quic_zhenhuah@quicinc.com>
Cc: <catalin.marinas@arm.com>, <will@kernel.org>, <ardb@kernel.org>,
<ryan.roberts@arm.com>, <mark.rutland@arm.com>,
<joey.gouly@arm.com>, <dave.hansen@linux.intel.com>,
<chenfeiyang@loongson.cn>, <chenhuacai@kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/2] Fix subsection vmemmap_populate logic
Date: Fri, 6 Dec 2024 22:14:46 -0800 [thread overview]
Message-ID: <20241206221446.e5e8ea4ed85d0f2884216b82@linux-foundation.org> (raw)
In-Reply-To: <b2681eed-d4d5-43c9-90e0-3e706db3e201@quicinc.com>
On Fri, 6 Dec 2024 17:13:39 +0800 Zhenhua Huang <quic_zhenhuah@quicinc.com> wrote:
>
>
> On 2024/11/28 15:26, Zhenhua Huang wrote:
> >
> >
> > On 2024/11/21 15:12, Zhenhua Huang wrote:
> >> To perform memory hotplug operations, the memmap (aka struct page)
> >> will be
> >> updated. For arm64 with 4K page size, the typical granularity is 128M,
> >> which corresponds to a 2M memmap buffer.
> >> Commit 2045a3b8911b ("mm/sparse-vmemmap: generalise
> >> vmemmap_populate_hugepages()")
> >> optimizes this 2M buffer to be mapped with PMD huge pages. However,
> >> commit ba72b4c8cf60 ("mm/sparsemem: support sub-section hotplug")
> >> which supports 2M subsection hotplug granularity, causes other issues
> >> (refer to the change log of patch #1). The logic is adjusted to populate
> >> with huge pages only if the hotplug address/size is section-aligned.
> >
> > Could any expert please help review ?
>
> Gentle reminder for review..
>
MM developers work on the linux-mm mailing list, which was not cc'ed.
Please address Catalin's review comment
(https://lkml.kernel.org/r/Z1Mwo5OajFZQYlOg@arm.com) then resend a v2
series with the appropriate cc's.
next prev parent reply other threads:[~2024-12-07 6:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-21 7:12 Zhenhua Huang
2024-11-21 7:12 ` [PATCH 1/2] arm64: mm: vmemmap populate to page level if not section aligned Zhenhua Huang
2024-12-06 17:13 ` Catalin Marinas
2024-12-09 6:04 ` Zhenhua Huang
2024-11-21 7:12 ` [PATCH 2/2] arm64: mm: implement vmemmap_check_pmd for arm64 Zhenhua Huang
2024-11-28 7:26 ` [PATCH 0/2] Fix subsection vmemmap_populate logic Zhenhua Huang
2024-12-06 9:13 ` Zhenhua Huang
2024-12-07 6:14 ` Andrew Morton [this message]
2024-12-09 6:04 ` Zhenhua Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241206221446.e5e8ea4ed85d0f2884216b82@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=chenfeiyang@loongson.cn \
--cc=chenhuacai@kernel.org \
--cc=dave.hansen@linux.intel.com \
--cc=joey.gouly@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=quic_zhenhuah@quicinc.com \
--cc=ryan.roberts@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®