Re: [PATCH v1] firewire: ohci: use generic power management

[Takashi Sakamoto <o-takashi@sakamocchi.jp>]

Hi,

On Mon, Jul 20, 2020 at 08:37:16PM +0530, Vaibhav Gupta wrote:
> Drivers using legacy PM have to manage PCI states and device's PM states
> themselves. They also need to take care of configuration registers.
> 
> With improved and powerful support of generic PM, PCI Core takes care of
> above mentioned, device-independent, jobs.
> 
> This driver makes use of PCI helper functions like
> pci_save/restore_state(), pci_disable_device() and pci_set_power_state() to
> do required operations. In generic mode, they are no longer needed.
> 
> Change function parameter in both .suspend() and .resume() to
> "struct device*" type. Use to_pci_dev() to get "struct pci_dev*" variable.
> 
> Compile-tested only.
> 
> Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com>
> ---
>  drivers/firewire/ohci.c | 43 ++++++++++++-----------------------------
>  1 file changed, 12 insertions(+), 31 deletions(-)

Although it takes a long time since the patch was posted, I applied it
now to for-next branch with my handy changes to optimize to v6.13-rc1. 

I still have a slight concern about the operation specific to powermac
platforms, however let us fix when receiving any reports from the users.


Regards

Takashi Sakamoto