From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBD3BEAD5 for ; Sat, 7 Dec 2024 03:54:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733543649; cv=none; b=cqHgQ/REczrhcGkE5nVeM6/UUG3DWa+PhAJTs0uG5iOWuhxP2P6r1z4McsKkbpHRl8fRCyJZDbDZ3+M3AiiFTM50PtN1zVk6KQ+tFa9pILzYg+Btx1rVHafQqf8sSqeholV3ZH6+O5LbhEYk6NI2uMY4VwLhfWaX3bqPc0I+Cyw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733543649; c=relaxed/simple; bh=zt/AY19a9rS+2Zt5kBZWJReZRHJqEV/1KPhanIcRYcE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DtxJCG99EyisVdEgr8DdrRIQZrAps1q4nBEDIrRPlsNbw9t+SeKxb3V0nSDHY+HpQ4D9eAoJKmmUlEugfDrEz1wPd1e7yZ1w/xEpToZbxLzgPXTBfAf0+Nc/QbhQyQyX+/yPgBaBzGVUHkpnLigOZHcVNi0Jbsc1eiuI05ibvs8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Zo388GuF; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Zo388GuF" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-21561af95c3so22948635ad.3 for ; Fri, 06 Dec 2024 19:54:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1733543647; x=1734148447; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=EnChk1JFxJG4/Y3+Tk/5Aeyux9ylHOYyGJ6VC7beF4Q=; b=Zo388GuFGBXuHQglkifGi0VAgd+pHm++3QLX4fCh8O2p9/0qp7LSVEEFNUL3cM4B0m d4ptAKc1xvzRJ3dEljLwz+xXNJnFXYpGnViyZvIe9SANFWthW+vepTRY/0NfmcolumXR D7+VYmpPSgc3r27Dq8w0xflqvv+X2bF7qYuU0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733543647; x=1734148447; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EnChk1JFxJG4/Y3+Tk/5Aeyux9ylHOYyGJ6VC7beF4Q=; b=lHOYDUgLV8N8GQUx0FuyytiLUvhIaxE7HQixeV4qyM1jvIBMb3tRdrft0+xoP2QlpU TYcNfldogCjLMDUEOABAMT2tBWxcaEBPlVc3MjoUuwCsbs9RE8EDqt5PLWYWE0y1uXgV 2GzImRfKDTGKRgUouUp2CwFkEjcBDd3Q301z1atPoWY0TAhpOp1WaKFLbbcgdqFIwBON vwTI71QJIbcoYE5yzEq3oOF1rYYMOB8HJsyAY+CCOZ1eUPRGJXwZnUqGIuomziV2xSEL Loyeb7zYvepmKMvIyYcmaFRc5iY3Ga0Jo2jIAzB7FzFa62ZdNhQR+MDYSfcpI41i8yRl +A6g== X-Forwarded-Encrypted: i=1; AJvYcCWHjpe5O4nvPTe/eEUj1TbV9ARn42RZ1bT4kaUAutN7e0Fa58f9cVZWYNc58mL6121vlETyMTQhf+14yDc=@vger.kernel.org X-Gm-Message-State: AOJu0YxbJZwXuK9/TfMtm2UEYcE9+9AluSy1eiS0VvLxaftwZKoHtyGt s4pQcv59+vNLIvPviXKltbW60TBEXcy/ID0VaDzUPd1zC1+Tiwo25tD4BkTzTg== X-Gm-Gg: ASbGncvESXMDi7ewTfWiuCiinP3Wv8ysy7YysWgm3dlUdByt6NZQrTtjpVl5y/reEzu zwGkgFAx8/Ax8e5LBH98gO8LNe88mFdcV5fTjLxYL8ZYBtSASp3If5hh5Ry+lc87pdgG08U71iT P9f6fF8Le8vXrfCq9ojr4/Po88pLzp4dyxjG1DQaofmjgVY6xC0w5HevmgLclbawUapBep10zoj 2oZJGsmOHaZdreCTK615gyXbYxjMn1298IpQrg5MESxX8s6s6/hlA== X-Google-Smtp-Source: AGHT+IFvc2c4aVvUcqQGdjyvZcOJtfWvmVZSN/6sZMOxUHRpCVuiv5PO6AkRFXuq6PIE1zg6wjh73g== X-Received: by 2002:a17:903:240a:b0:212:fa3:f627 with SMTP id d9443c01a7336-21614d457ebmr96715935ad.16.1733543647100; Fri, 06 Dec 2024 19:54:07 -0800 (PST) Received: from google.com ([2401:fa00:8f:203:1ca0:173b:2684:b413]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2162bd6a645sm3173085ad.119.2024.12.06.19.54.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Dec 2024 19:54:06 -0800 (PST) Date: Sat, 7 Dec 2024 12:54:02 +0900 From: Sergey Senozhatsky To: LiviaMedeiros <9@cirno.name> Cc: Sergey Senozhatsky , Minchan Kim , Jens Axboe , Nick Terrell , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org Subject: Re: [PATCH] zram: make default ZSTD compression level configurable Message-ID: <20241207035402.GI16709@google.com> References: <7d73e19b-f264-4c31-8f5a-fb17b6bc0600@cirno.name> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7d73e19b-f264-4c31-8f5a-fb17b6bc0600@cirno.name> On (24/12/07 04:16), LiviaMedeiros wrote: > From: LiviaMedeiros > > Add support for configuring the default ZSTD compression level for zram > devices via the CONFIG_ZRAM_DEFAULT_ZSTD_LEVEL configuration option. > If this option is not set, fallback to zstd_default_clevel() is used. Please let's not. Then somebody will need options to .config c/d dicts for zstd/lz4/lz4hc, acceleration levels for lz4, compression level for deflate and so on and on and on. [..] > I also failed to make something like `echo "algo=zstd level=9" > > /sys/block/zram3/algorithm_params` work in runtime, but I assume I'm just > dumb and/or it requires extra steps. This should work, but you need to configure algo params before you init zram device (that is _before_ write to disksize device attr). E.g. % modprobe zram % echo zstd > /sys/block/zram0/comp_algorithm % echo "algo=zstd level=9 dict=/etc/zstd-dict-amd64" > /sys/block/zram0/algorithm_params % echo 1G > /sys/block/zram0/disksize