From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E95E91474B8 for ; Sun, 8 Dec 2024 12:44:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733661884; cv=none; b=jDFTSfGj/0NBhbqxvX2IQ9yyAzd2Vkwrqw590TbSwUfWiXVokkFJIdEv4png6ZI4pHt5Xx/viuYAW+nWSyZBDEl3nqVbALHUmV+PQJCAsLGp4N9BNrBNHgU3PRgR2s1J3KH3v/0a6i15ht14yQ6rtrPAbEsVQ6NR3j+uOzlOp9E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733661884; c=relaxed/simple; bh=pFIGxvFPsv5hV0g3ScDxxRxCjlmfbMjHw/GW2NH5Nbg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=W6wkoiStUe1SY3Rywr+hRlUB5PQuSufzaoPg9BCsN5Nxyi/wziu+ziH+PFiSja3fOYd9SQ849Xwc653WEv5bq7hE1FDxHq+Ok9FHjlxtposk7GsXB5/GAzihLWnsmUe1yw+GEnN10bg4mHZsgFNExauRSgIcCcs7a0scsyInS40= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Ij84obFk; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Ij84obFk" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-215b9a754fbso32510135ad.1 for ; Sun, 08 Dec 2024 04:44:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1733661882; x=1734266682; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=ObzuBtRvdTYYc5ZI72EO8xxEXcCsf9XtGeinrNeixuA=; b=Ij84obFk02xlqNvUtEpru4/h3dwDOu4zP1LWgByzo0GR3/YmHY5qwBTHzNfbV9Y6gk 9PJPzHFNunXpmqJ4rxKtxhpMcN7UJkDD2dOoDJuw4Xg6SlIWDJ6auWpN3DXIqVJQ1ZeN Dt3o7azh/lq5rFijtE4n0hI/wbzwC7bBOqlgzRVGidGAZXakKtQxtO4xK2pkFR/5jtgM +jO2RAL1i+emM8zT/rszl+w/YL18lJyv7akJju3pp7Y2BIbKe52gzdYgQUMQ/9isdLU2 VAHRNVfwexmqFYbYAkB6xiQxCm8spJcr71DrlIk3Z6IYCfocmBDxrGRG40q/2KzvHKo2 7H/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733661882; x=1734266682; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ObzuBtRvdTYYc5ZI72EO8xxEXcCsf9XtGeinrNeixuA=; b=sDSZcocXAP8sGyLkqSjKzmLCtWcuSZ1340Mwh8zOJRirck7jBwX8qmivwIgvA1QU7d NdPE6hI1t6t7Br17KrzRdB8+qmpPPnGlZH/SSWGmyVLB7rZkZ620ZDf9He3sCd2+kRxk VDst2JKvmao0fReJPPiZ53tr7ePtVZX9sT4HSVFh24noYGtD1TZjABwnGCSb5nL5EDo4 fAppv8TWW/XKPSudR2suE9IdnegJWuFEb9C1ga7afScb07XTmek6qUsBLvbxS7rbaiQl LvFAZhFxNSHThKKg3Ct+Z8VFXuyVB3zfpaQJQskIMFG9JQsETDrgQzQ9DV1LYdzxkyAH 5hRw== X-Forwarded-Encrypted: i=1; AJvYcCW7fSSDOY9WSwULkjINl/K5amxjsW0eavRVuLuiKNOEyVYitSXSacHqBuUWPJl2qzRYwqGob6Z+QgPSDYE=@vger.kernel.org X-Gm-Message-State: AOJu0Yz6ntdVTZ8QDy9AScx1U0wX0ZxZ7pPJcsRxnQJhSNyVFJXgeAu0 p0mo5TJnYwnwfYmuO9/DpKbeBfevhxtAxhrCe5V8twHoXPk/pN0g4EIm/OM2fHEuxodWd5wHl4P nMw== X-Gm-Gg: ASbGncuk7wu61GicxQgMSNzyvtsCHPq9OpOrg8n+UvQUYDoX1/WmIai0+wJP5s2wgSA yj+3Q/hc0TZ7Hzul/tXDsmFUNKPFlGCA3BZD9HZIExIAtY4gQ6CixSIsNviUiR2jJnga4P+KmHc A5n876yIpFHxUiSmkXqThWbmKiTkFnd9rFrQtm+U95oQFlJ5O8leNx1T4qTDfbEE467/gDBnQ+u GsKgnK4n4OYca15IKQWGQj70ERZq/reM4ankk8O8XoRvo+TLKUHEe/Xb/A= X-Google-Smtp-Source: AGHT+IFWStgtABEgXeuwa+0us5wTIZE6ArS1wlJLYxBQNATuRowJR77uhfkJK4Vk9aSU1pZvjciMaw== X-Received: by 2002:a17:902:e5cd:b0:215:9a73:6c45 with SMTP id d9443c01a7336-21614d45334mr158926955ad.22.1733661882268; Sun, 08 Dec 2024 04:44:42 -0800 (PST) Received: from thinkpad ([36.255.19.23]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21617531ba7sm39465845ad.106.2024.12.08.04.44.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Dec 2024 04:44:41 -0800 (PST) Date: Sun, 8 Dec 2024 18:14:36 +0530 From: Manivannan Sadhasivam To: Dan Carpenter Cc: Damien Le Moal , Shawn Lin , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Heiko Stuebner , linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH v2] PCI: rockchip-ep: Fix error code in rockchip_pcie_ep_init_ob_mem() Message-ID: <20241208124436.vicbi72xyomahp3s@thinkpad> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Dec 02, 2024 at 12:07:22PM +0300, Dan Carpenter wrote: > Return -ENOMEM if pci_epc_mem_alloc_addr() fails. Don't return success. > > Fixes: 945648019466 ("PCI: rockchip-ep: Refactor rockchip_pcie_ep_probe() memory allocations") > Signed-off-by: Dan Carpenter Reviewed-by: Manivannan Sadhasivam - Mani > Reviewed-by: Damien Le Moal > --- > v2: Update the git hash for the Fixes tag because the tree was rebased I guess. > > drivers/pci/controller/pcie-rockchip-ep.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/controller/pcie-rockchip-ep.c b/drivers/pci/controller/pcie-rockchip-ep.c > index 1064b7b06cef..34162ca14093 100644 > --- a/drivers/pci/controller/pcie-rockchip-ep.c > +++ b/drivers/pci/controller/pcie-rockchip-ep.c > @@ -784,6 +784,7 @@ static int rockchip_pcie_ep_init_ob_mem(struct rockchip_pcie_ep *ep) > SZ_1M); > if (!ep->irq_cpu_addr) { > dev_err(dev, "failed to reserve memory space for MSI\n"); > + err = -ENOMEM; > goto err_epc_mem_exit; > } > > -- > 2.45.2 > -- மணிவண்ணன் சதாசிவம்