From: Jonathan Cameron <jic23@kernel.org>
To: Sean Nyekjaer <sean@geanix.com>
Cc: Lorenzo Bianconi <lorenzo@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: imu: st_lsm6dsx: don't always auto-enable I2C, I3C and SPI interface drivers
Date: Sun, 8 Dec 2024 17:27:26 +0000 [thread overview]
Message-ID: <20241208172726.7ed07735@jic23-huawei> (raw)
In-Reply-To: <20241203-lsm6dsx-v1-1-6d7893443bc8@geanix.com>
On Tue, 03 Dec 2024 08:20:17 +0100
Sean Nyekjaer <sean@geanix.com> wrote:
> This patch makes I2C, I3C and SPI interface drivers for ST lsm6dsx
> individually selectable via Kconfig.
>
> The default is kept unchanged - I2C, I3C and SPI interface drivers are
> still selected by default if the corresponding bus support is available.
>
> However, the patch makes it possible to explicitly disable drivers
> that are not needed for a particular target.
>
> Signed-off-by: Sean Nyekjaer <sean@geanix.com>
Fair enough. Well explained and I guess you have a config which restricted enough
that this makes sense.
Applied to the togreg branch of iio.git and pushed out as testing for 0-day to
see what we missed this time
Jonathan
> ---
> drivers/iio/imu/st_lsm6dsx/Kconfig | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/iio/imu/st_lsm6dsx/Kconfig b/drivers/iio/imu/st_lsm6dsx/Kconfig
> index 89d687ec3099cc3ecb848e44f610c5cd64c80ad1..3cabec3b152d21403b40668a20ca7d175109a79e 100644
> --- a/drivers/iio/imu/st_lsm6dsx/Kconfig
> +++ b/drivers/iio/imu/st_lsm6dsx/Kconfig
> @@ -6,9 +6,6 @@ config IIO_ST_LSM6DSX
> select IIO_BUFFER
> select IIO_TRIGGERED_BUFFER
> select IIO_KFIFO_BUF
> - select IIO_ST_LSM6DSX_I2C if (I2C)
> - select IIO_ST_LSM6DSX_SPI if (SPI_MASTER)
> - select IIO_ST_LSM6DSX_I3C if (I3C)
> help
> Say yes here to build support for STMicroelectronics LSM6DSx imu
> sensor.
> @@ -42,16 +39,19 @@ config IIO_ST_LSM6DSX
> will be called st_lsm6dsx.
>
> config IIO_ST_LSM6DSX_I2C
> - tristate
> - depends on IIO_ST_LSM6DSX
> + tristate "ST_LSM6DSx driver for STM 6-axis IMU MEMS sensors I2C Interface"
> + depends on I2C && IIO_ST_LSM6DSX
> + default I2C && IIO_ST_LSM6DSX
> select REGMAP_I2C
>
> config IIO_ST_LSM6DSX_SPI
> - tristate
> - depends on IIO_ST_LSM6DSX
> + tristate "ST_LSM6DSx driver for STM 6-axis IMU MEMS sensors SPI Interface"
> + depends on SPI_MASTER && IIO_ST_LSM6DSX
> + default SPI_MASTER && IIO_ST_LSM6DSX
> select REGMAP_SPI
>
> config IIO_ST_LSM6DSX_I3C
> - tristate
> - depends on IIO_ST_LSM6DSX
> + tristate "ST_LSM6DSx driver for STM 6-axis IMU MEMS sensors I3C Interface"
> + depends on I3C && IIO_ST_LSM6DSX
> + default I3C && IIO_ST_LSM6DSX
> select REGMAP_I3C
>
> ---
> base-commit: 4ecd1edf4994bc5385609c6ea9e599b4ee958706
> change-id: 20241202-lsm6dsx-585182084202
>
> Best regards,
prev parent reply other threads:[~2024-12-08 17:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-03 7:20 Sean Nyekjaer
2024-12-08 17:27 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241208172726.7ed07735@jic23-huawei \
--to=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=sean@geanix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®