From: Peter Zijlstra <peterz@infradead.org>
To: Vineeth Remanan Pillai <vineeth@bitbyteword.org>
Cc: Joel Fernandes <joel@joelfernandes.org>,
Ilya Maximets <i.maximets@ovn.org>,
LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
vineethrp@google.com, shraash@google.com
Subject: Re: [v6.12] WARNING: at kernel/sched/deadline.c:1995 enqueue_dl_entity (task blocked for more than 28262 seconds)
Date: Mon, 9 Dec 2024 11:55:14 +0100 [thread overview]
Message-ID: <20241209105514.GK21636@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <CAO7JXPhdv+Jx_UpAq=-aG-BKwiyjZ2kvuZDM4+GLjbya_=ZJsw@mail.gmail.com>
On Fri, Dec 06, 2024 at 11:57:30AM -0500, Vineeth Remanan Pillai wrote:
> I was able to reproduce this WARN_ON couple of days back with
> syzkaller. dlserver's dl_se gets enqueued during a update_curr while
> the dlserver is stopped. And subsequent dlserver start will cause a
> double enqueue.
Right, I spotted that hole late last week. There is this thread:
https://lore.kernel.org/all/20241209094941.GF21636@noisy.programming.kicks-ass.net/T/#u
Where I just added this thunk:
@@ -1674,6 +1679,12 @@ void dl_server_start(struct sched_dl_entity *dl_se)
void dl_server_stop(struct sched_dl_entity *dl_se)
{
+ if (current->dl_server == dl_se) {
+ struct rq *rq = rq_of_dl_se(dl_se);
+ trace_printk("stop fair server %d\n", cpu_of(rq));
+ current->dl_server = NULL;
+ }
+
if (!dl_se->dl_runtime)
return;
Which was my attempt at plugging said hole. But since I do not have
means of reproduction, I'm not at all sure it is sufficient :/
next prev parent reply other threads:[~2024-12-09 10:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 12:47 Ilya Maximets
2024-12-06 15:18 ` Joel Fernandes
2024-12-06 16:57 ` Vineeth Remanan Pillai
2024-12-06 17:24 ` Joel Fernandes
2024-12-09 10:48 ` Juri Lelli
2024-12-09 10:55 ` Peter Zijlstra [this message]
2024-12-09 12:29 ` Vineeth Remanan Pillai
2024-12-09 12:34 ` Ilya Maximets
2024-12-10 0:31 ` Ilya Maximets
2024-12-09 12:56 ` Peter Zijlstra
2024-12-09 13:56 ` Vineeth Remanan Pillai
2024-12-09 14:01 ` Peter Zijlstra
2024-12-09 14:12 ` Vineeth Remanan Pillai
2024-12-10 0:34 ` Ilya Maximets
2024-12-10 2:52 ` Vineeth Remanan Pillai
2024-12-10 2:58 ` Vineeth Remanan Pillai
2024-12-10 9:28 ` Ilya Maximets
2024-12-10 23:16 ` Ilya Maximets
2024-12-11 2:30 ` Vineeth Remanan Pillai
2024-12-11 9:48 ` Ilya Maximets
2024-12-10 16:11 ` Marcel Ziswiler
2024-12-10 16:08 ` Marcel Ziswiler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241209105514.GK21636@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=i.maximets@ovn.org \
--cc=joel@joelfernandes.org \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=shraash@google.com \
--cc=vincent.guittot@linaro.org \
--cc=vineeth@bitbyteword.org \
--cc=vineethrp@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®