From: Rodrigo Gobbi <rodrigo.gobbi.7@gmail.com>
To: dan.carpenter@linaro.org
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev, philipp.g.hortmann@gmail.com,
rodrigo.gobbi.7@gmail.com, ~lkcamp/patches@lists.sr.ht
Subject: Re: [PATCH v3] staging: rtl8723bs: remove code depending on cflag
Date: Mon, 9 Dec 2024 18:33:36 -0300 [thread overview]
Message-ID: <20241209213528.5917-1-rodrigo.gobbi.7@gmail.com> (raw)
In-Reply-To: <42d24db0-b403-4c4b-8607-38f3cd55cf63@stanley.mountain>
> The commit message should answer any kind of reasonable questions
> a review is probably going to ask but it doesn't give any information on
> this.
I'll try to improve this for future patches, tks for pointing that out.
> This commit would easier to review if it were broken up in a different
> way.
Ok, in that way, a patch series is the best approach here, right?
Despite the changes in the series being dependent on each other in this case.
Tks and regards.
next prev parent reply other threads:[~2024-12-09 21:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-06 22:53 Rodrigo Gobbi
2024-12-08 10:27 ` Dan Carpenter
2024-12-09 21:33 ` Rodrigo Gobbi [this message]
2024-12-10 7:28 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241209213528.5917-1-rodrigo.gobbi.7@gmail.com \
--to=rodrigo.gobbi.7@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=philipp.g.hortmann@gmail.com \
--cc=~lkcamp/patches@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®