From: Cindy Lu <lulu@redhat.com>
To: lulu@redhat.com, jasowang@redhat.com, mst@redhat.com,
michael.christie@oracle.com, sgarzare@redhat.com,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org
Subject: [PATCH v4 7/8] vhost: Add new UAPI to support change to task mode
Date: Wed, 11 Dec 2024 00:41:46 +0800 [thread overview]
Message-ID: <20241210164456.925060-8-lulu@redhat.com> (raw)
In-Reply-To: <20241210164456.925060-1-lulu@redhat.com>
Add a new UAPI to enable setting the vhost device to task mode.
The userspace application can use VHOST_SET_INHERIT_FROM_OWNER
to configure the mode if necessary.
This setting must be applied before VHOST_SET_OWNER, as the worker
will be created in the VHOST_SET_OWNER function
Signed-off-by: Cindy Lu <lulu@redhat.com>
---
drivers/vhost/vhost.c | 22 +++++++++++++++++++++-
include/uapi/linux/vhost.h | 18 ++++++++++++++++++
2 files changed, 39 insertions(+), 1 deletion(-)
diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index 3e9cb99da1b5..12c3bf3d1ed4 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
@@ -2257,15 +2257,35 @@ long vhost_dev_ioctl(struct vhost_dev *d, unsigned int ioctl, void __user *argp)
{
struct eventfd_ctx *ctx;
u64 p;
- long r;
+ long r = 0;
int i, fd;
+ u8 inherit_owner;
/* If you are not the owner, you can become one */
if (ioctl == VHOST_SET_OWNER) {
r = vhost_dev_set_owner(d);
goto done;
}
+ if (ioctl == VHOST_SET_INHERIT_FROM_OWNER) {
+ /*inherit_owner can only be modified before owner is set*/
+ if (vhost_dev_has_owner(d)) {
+ r = -EBUSY;
+ goto done;
+ }
+ if (copy_from_user(&inherit_owner, argp, sizeof(u8))) {
+ r = -EFAULT;
+ goto done;
+ }
+ /* Validate the inherit_owner value, ensuring it is either 0 or 1 */
+ if (inherit_owner > 1) {
+ r = -EINVAL;
+ goto done;
+ }
+
+ d->inherit_owner = (bool)inherit_owner;
+ goto done;
+ }
/* You must be the owner to do anything else */
r = vhost_dev_check_owner(d);
if (r)
diff --git a/include/uapi/linux/vhost.h b/include/uapi/linux/vhost.h
index b95dd84eef2d..d7564d62b76d 100644
--- a/include/uapi/linux/vhost.h
+++ b/include/uapi/linux/vhost.h
@@ -235,4 +235,22 @@
*/
#define VHOST_VDPA_GET_VRING_SIZE _IOWR(VHOST_VIRTIO, 0x82, \
struct vhost_vring_state)
+
+/**
+ * VHOST_SET_INHERIT_FROM_OWNER - Set the inherit_owner flag for the vhost device
+ *
+ * @param inherit_owner: An 8-bit value that determines the vhost thread mode
+ *
+ * When inherit_owner is set to 1:
+ * - The VHOST worker threads inherit its values/checks from
+ * the thread that owns the VHOST device, The vhost threads will
+ * be counted in the nproc rlimits.
+ *
+ * When inherit_owner is set to 0:
+ * - The VHOST worker threads will use the traditional kernel thread (kthread)
+ * implementation, which may be preferred by older userspace applications that
+ * do not utilize the newer vhost_task concept.
+ */
+#define VHOST_SET_INHERIT_FROM_OWNER _IOW(VHOST_VIRTIO, 0x83, __u8)
+
#endif
--
2.45.0
next prev parent reply other threads:[~2024-12-10 16:46 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-10 16:41 [PATCH v4 0/8] vhost: Add support of kthread API Cindy Lu
2024-12-10 16:41 ` [PATCH v4 1/8] vhost: Add a new parameter in vhost_dev to allow user select kthread Cindy Lu
2024-12-10 17:52 ` Stefano Garzarella
2024-12-18 8:36 ` Cindy Lu
2024-12-10 16:41 ` [PATCH v4 2/8] vhost: Add the vhost_worker to support kthread Cindy Lu
2024-12-10 17:52 ` Stefano Garzarella
2024-12-18 8:38 ` Cindy Lu
2024-12-10 16:41 ` [PATCH v4 3/8] vhost: Add the cgroup related function Cindy Lu
2024-12-10 17:53 ` Stefano Garzarella
2024-12-18 8:45 ` Cindy Lu
2024-12-10 16:41 ` [PATCH v4 4/8] vhost: Add kthread support in function vhost_worker_create Cindy Lu
2024-12-10 17:53 ` Stefano Garzarella
2024-12-10 16:41 ` [PATCH v4 5/8] vhost: Add kthread support in function vhost_worker_queue() Cindy Lu
2024-12-10 17:54 ` Stefano Garzarella
2024-12-10 16:41 ` [PATCH v4 6/8] vhost: Add kthread support in function vhost_worker_destroy() Cindy Lu
2024-12-10 16:41 ` Cindy Lu [this message]
2024-12-10 17:54 ` [PATCH v4 7/8] vhost: Add new UAPI to support change to task mode Stefano Garzarella
2024-12-30 12:38 ` Cindy Lu
2025-01-08 12:13 ` Michael S. Tsirkin
2025-01-13 2:36 ` Cindy Lu
2025-01-13 3:09 ` Jason Wang
2025-01-22 2:07 ` Cindy Lu
2025-01-22 7:18 ` Michael S. Tsirkin
2025-01-22 7:52 ` Cindy Lu
2024-12-10 16:41 ` [PATCH v4 8/8] vhost_scsi: Add check for inherit_owner status Cindy Lu
2024-12-10 17:51 ` [PATCH v4 0/8] vhost: Add support of kthread API Stefano Garzarella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241210164456.925060-8-lulu@redhat.com \
--to=lulu@redhat.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.christie@oracle.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sgarzare@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®