From: Alice Ryhl <aliceryhl@google.com>
To: Miguel Ojeda <ojeda@kernel.org>,
Matthew Wilcox <willy@infradead.org>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Vlastimil Babka <vbabka@suse.cz>,
John Hubbard <jhubbard@nvidia.com>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>,
Christian Brauner <brauner@kernel.org>,
Jann Horn <jannh@google.com>,
Suren Baghdasaryan <surenb@google.com>
Cc: "Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
rust-for-linux@vger.kernel.org,
"Alice Ryhl" <aliceryhl@google.com>
Subject: [PATCH v11 7/8] rust: miscdevice: add mmap support
Date: Wed, 11 Dec 2024 10:37:11 +0000 [thread overview]
Message-ID: <20241211-vma-v11-7-466640428fc3@google.com> (raw)
In-Reply-To: <20241211-vma-v11-0-466640428fc3@google.com>
Add the ability to write a file_operations->mmap hook in Rust when using
the miscdevice abstraction. The `vma` argument to the `mmap` hook uses
the `VmAreaNew` type from the previous commit; this type provides the
correct set of operations for a file_operations->mmap hook.
Acked-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com> (for mm bits)
Signed-off-by: Alice Ryhl <aliceryhl@google.com>
---
rust/kernel/miscdevice.rs | 37 +++++++++++++++++++++++++++++++++++++
1 file changed, 37 insertions(+)
diff --git a/rust/kernel/miscdevice.rs b/rust/kernel/miscdevice.rs
index 7e2a79b3ae26..e5366f9c6d7f 100644
--- a/rust/kernel/miscdevice.rs
+++ b/rust/kernel/miscdevice.rs
@@ -11,6 +11,8 @@
use crate::{
bindings,
error::{to_result, Error, Result, VTABLE_DEFAULT_ERROR},
+ fs::File,
+ mm::virt::VmAreaNew,
prelude::*,
str::CStr,
types::{ForeignOwnable, Opaque},
@@ -110,6 +112,15 @@ fn release(device: Self::Ptr) {
drop(device);
}
+ /// Handle for mmap.
+ fn mmap(
+ _device: <Self::Ptr as ForeignOwnable>::Borrowed<'_>,
+ _file: &File,
+ _vma: &VmAreaNew,
+ ) -> Result {
+ kernel::build_error!(VTABLE_DEFAULT_ERROR)
+ }
+
/// Handler for ioctls.
///
/// The `cmd` argument is usually manipulated using the utilties in [`kernel::ioctl`].
@@ -156,6 +167,7 @@ impl<T: MiscDevice> VtableHelper<T> {
const VTABLE: bindings::file_operations = bindings::file_operations {
open: Some(fops_open::<T>),
release: Some(fops_release::<T>),
+ mmap: maybe_fn(T::HAS_MMAP, fops_mmap::<T>),
unlocked_ioctl: maybe_fn(T::HAS_IOCTL, fops_ioctl::<T>),
#[cfg(CONFIG_COMPAT)]
compat_ioctl: if T::HAS_COMPAT_IOCTL {
@@ -216,6 +228,31 @@ impl<T: MiscDevice> VtableHelper<T> {
0
}
+/// # Safety
+///
+/// `file` must be a valid file that is associated with a `MiscDeviceRegistration<T>`.
+/// `vma` must be a vma that is currently being mmap'ed with this file.
+unsafe extern "C" fn fops_mmap<T: MiscDevice>(
+ file: *mut bindings::file,
+ vma: *mut bindings::vm_area_struct,
+) -> c_int {
+ // SAFETY: The mmap call of a file can access the private data.
+ let private = unsafe { (*file).private_data };
+ // SAFETY: Mmap calls can borrow the private data of the file.
+ let device = unsafe { <T::Ptr as ForeignOwnable>::borrow(private) };
+ // SAFETY: The caller provides a vma that is undergoing initial VMA setup.
+ let area = unsafe { VmAreaNew::from_raw(vma) };
+ // SAFETY:
+ // * The file is valid for the duration of this call.
+ // * There is no active fdget_pos region on the file on this thread.
+ let file = unsafe { File::from_raw_file(file) };
+
+ match T::mmap(device, file, area) {
+ Ok(()) => 0,
+ Err(err) => err.to_errno() as c_int,
+ }
+}
+
/// # Safety
///
/// `file` must be a valid file that is associated with a `MiscDeviceRegistration<T>`.
--
2.47.1.613.gc27f4b7a9f-goog
next prev parent reply other threads:[~2024-12-11 10:37 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <nGnC07PmUqofHiX7HfZAOCIK1-CPS7DF8kdGhDgJgPts5KYrCrimmovP-4YMVgI7WRmFnGwbdndTtxCfp278cg==@protonmail.internalid>
2024-12-11 10:37 ` [PATCH v11 0/8] Rust support for mm_struct, vm_area_struct, and mmap Alice Ryhl
2024-12-11 10:37 ` [PATCH v11 1/8] mm: rust: add abstraction for struct mm_struct Alice Ryhl
2024-12-16 11:31 ` Andreas Hindborg
2025-01-13 9:53 ` Alice Ryhl
2025-01-14 15:48 ` Lorenzo Stoakes
2025-01-15 1:54 ` John Hubbard
2025-01-15 12:13 ` Lorenzo Stoakes
2025-01-15 10:36 ` Andreas Hindborg
2025-01-15 20:20 ` John Hubbard
2025-01-17 0:45 ` Balbir Singh
2025-01-17 12:47 ` Alice Ryhl
2024-12-11 10:37 ` [PATCH v11 2/8] mm: rust: add vm_area_struct methods that require read access Alice Ryhl
2024-12-16 12:12 ` Andreas Hindborg
2025-01-08 12:21 ` Alice Ryhl
2025-01-09 8:02 ` Andreas Hindborg
2025-01-09 8:19 ` Lorenzo Stoakes
2025-01-09 9:50 ` Andreas Hindborg
2025-01-09 11:29 ` Lorenzo Stoakes
2025-01-09 15:32 ` Andreas Hindborg
2025-01-13 14:45 ` Lorenzo Stoakes
2025-01-14 9:50 ` Alice Ryhl
2025-01-14 11:57 ` Lorenzo Stoakes
2025-01-14 13:42 ` Alice Ryhl
2025-01-14 15:33 ` Lorenzo Stoakes
2025-01-15 11:02 ` Andreas Hindborg
2025-01-15 11:04 ` Alice Ryhl
2024-12-11 10:37 ` [PATCH v11 3/8] mm: rust: add vm_insert_page Alice Ryhl
2024-12-16 12:25 ` Andreas Hindborg
2025-01-13 10:02 ` Alice Ryhl
2025-01-15 9:33 ` Andreas Hindborg
2024-12-11 10:37 ` [PATCH v11 4/8] mm: rust: add lock_vma_under_rcu Alice Ryhl
2024-12-16 12:47 ` Andreas Hindborg
2025-01-13 10:04 ` Alice Ryhl
2025-01-15 9:34 ` Andreas Hindborg
2024-12-11 10:37 ` [PATCH v11 5/8] mm: rust: add mmput_async support Alice Ryhl
2024-12-16 13:10 ` Andreas Hindborg
2024-12-11 10:37 ` [PATCH v11 6/8] mm: rust: add VmAreaNew for f_ops->mmap() Alice Ryhl
2024-12-16 13:41 ` Andreas Hindborg
2025-01-08 12:23 ` Alice Ryhl
2025-01-09 8:19 ` Andreas Hindborg
2025-01-13 10:17 ` Alice Ryhl
2025-01-15 9:57 ` Andreas Hindborg
2024-12-17 9:31 ` Andreas Hindborg
2025-01-08 12:24 ` Alice Ryhl
2025-01-09 8:23 ` Andreas Hindborg
2025-01-13 10:18 ` Alice Ryhl
2025-01-10 13:34 ` Alice Ryhl
2025-01-10 16:09 ` Lorenzo Stoakes
2024-12-11 10:37 ` Alice Ryhl [this message]
2024-12-16 13:53 ` [PATCH v11 7/8] rust: miscdevice: add mmap support Andreas Hindborg
2024-12-11 10:37 ` [PATCH v11 8/8] task: rust: rework how current is accessed Alice Ryhl
2024-12-16 14:47 ` Andreas Hindborg
2025-01-08 12:32 ` Alice Ryhl
2025-01-09 8:42 ` Andreas Hindborg
2025-01-13 10:26 ` Alice Ryhl
2025-01-15 10:24 ` Andreas Hindborg
2024-12-16 23:40 ` Boqun Feng
2025-01-13 10:30 ` Alice Ryhl
2025-01-14 15:30 ` Boqun Feng
2024-12-11 10:47 ` [PATCH v11 0/8] Rust support for mm_struct, vm_area_struct, and mmap Alice Ryhl
2024-12-12 14:47 ` Konstantin Ryabitsev
2024-12-13 14:42 ` Alice Ryhl
2024-12-13 14:47 ` Konstantin Ryabitsev
2024-12-16 11:04 ` Andreas Hindborg
2024-12-16 11:46 ` Alice Ryhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241211-vma-v11-7-466640428fc3@google.com \
--to=aliceryhl@google.com \
--cc=Liam.Howlett@oracle.com \
--cc=a.hindborg@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alex.gaynor@gmail.com \
--cc=arnd@arndb.de \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=brauner@kernel.org \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=jannh@google.com \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=surenb@google.com \
--cc=tmgross@umich.edu \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®